Commit Graph

  • 0cbe665aea conductor(plan): nagent_review_v3 mark Phase 3 complete ed 2026-06-20 08:08:50 -04:00
  • caf04ca5b6 conductor(track): nagent_review_v3 §2 Conversation safety net cluster ed 2026-06-20 08:08:14 -04:00
  • 6dd41b3e6d conductor(plan): mark result_migration_baseline_cleanup_20260620 as active ed 2026-06-20 08:07:59 -04:00
  • 52dfece9ca conductor(plan): nagent_review_v3 mark Phase 2 complete ed 2026-06-20 08:04:57 -04:00
  • c81ea78273 conductor(track): nagent_review_v3 §1 Campaigns cluster ed 2026-06-20 08:04:09 -04:00
  • f76d73e822 conductor(plan): nagent_review_v3 mark Phase 1 complete ed 2026-06-20 08:00:23 -04:00
  • 5a28c8f316 conductor(track): nagent_review_v3 Phase 1 setup + audit ed 2026-06-20 07:57:53 -04:00
  • e90167494e conductor(plan): initialize result_migration_baseline_cleanup_20260620 (sub-track 5) ed 2026-06-20 07:48:15 -04:00
  • 9224be7ac3 conductor(plan): add TRACK_COMPLETION report + track artifacts for tier2_leak_prevention_20260620 ed 2026-06-20 07:46:10 -04:00
  • 977cfdb740 migration artifacts ed 2026-06-20 07:23:56 -04:00
  • d653bd5c9a Merge branch 'tier2/result_migration_gui_2_20260619' ed 2026-06-20 07:23:02 -04:00
  • 0a21627b8a conductor(track): nagent_review_v3 spec + plan ed 2026-06-20 07:10:11 -04:00
  • 4116e14ed1 conductor(plan): mark Phase 13 complete (final checkpoint + tracks.md update) ed 2026-06-20 02:55:37 -04:00
  • 4b20f395a4 docs(reports): TRACK_COMPLETION_result_migration_gui_2_20260619 (Phase 13, task 13.4) ed 2026-06-20 02:51:05 -04:00
  • 1efcd4fdbc perf(gui_2): use singleton success Result in _render_main_interface_result ed 2026-06-20 02:49:27 -04:00
  • f0ae074aec fix(gui_2): restore _last_imgui_assert as string (regression from Phase 10) ed 2026-06-20 02:39:47 -04:00
  • d96e54f2df test(gui_2): add 2 Phase 12 invariant tests + Phase 12 checkpoint ed 2026-06-20 02:26:42 -04:00
  • 28a55ea51c test(audit_heuristics): add 3 regression tests for lazy-loading (Phase 12) ed 2026-06-20 02:24:18 -04:00
  • f996aa1066 feat(audit): add lazy-loading sentinel fallback heuristic (Phase 12) ed 2026-06-20 02:17:19 -04:00
  • 4edd6a9583 chore: TIER-2 READ conductor/code_styleguides/error_handling.md (lazy-loading fallback) before Phase 12 ed 2026-06-20 02:08:15 -04:00
  • 541eb3d5ad test(gui_2): add 2 Phase 11 invariant tests + Phase 11 checkpoint ed 2026-06-20 02:06:00 -04:00
  • a5a06f8516 test(audit_heuristics): add 5 regression tests for dunder raise (Phase 11) ed 2026-06-20 01:57:33 -04:00
  • 6e03f5aee3 feat(audit): add dunder-method bare-raise heuristic (Phase 11) ed 2026-06-20 01:57:08 -04:00
  • 8f54deda9f chore(tier2): install pre-commit hook via setup_tier2_clone.ps1 ed 2026-06-20 01:47:58 -04:00
  • f5d8ea047a feat(audit): add audit_tier2_leaks.py for tier-2 sandbox file leak detection ed 2026-06-20 01:47:23 -04:00
  • 81e1fd7b2c feat(tier2): add pre-commit hook + denylist config to block sandbox-only files ed 2026-06-20 01:45:34 -04:00
  • de23dbe57a chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 625-690 (Re-Raise Patterns 1/2/3) before Phase 11 ed 2026-06-20 01:45:07 -04:00
  • 74b7b67a97 conductor(plan): Mark Phase 10 as complete (df481f7) ed 2026-06-20 01:43:17 -04:00
  • df481f72ea TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: fix(gui_2): restore App class structure with all 13 Phase 10 sites correctly migrated ed 2026-06-20 01:42:59 -04:00
  • 02dcca448f test(gui_2): add 2 Phase 10 invariant tests + Phase 10 checkpoint TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10. ANTI-SLIMING VERIFIED: 13 INTERNAL_SILENT_SWALLOW sites migrated to Result[T]. logging NOT a drain per the user's principle 2026-06-17. ed 2026-06-20 01:06:56 -04:00
  • 3c752eb2ae TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L7315 render_task_dag_panel ticket_id_parse to Result[T] (Phase 10 site 13) ed 2026-06-20 01:03:15 -04:00
  • b4a6ebc101 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L7271 render_task_dag_panel cycle_check to Result[T] (Phase 10 site 12) ed 2026-06-20 01:01:40 -04:00
  • e2d2105b16 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L6908 render_tier_stream_panel scroll_sync to Result[T] (Phase 10 site 11) ed 2026-06-20 01:00:31 -04:00
  • 602c1b48e7 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L4911 _on_warmup_complete_callback to Result[T] (Phase 10 site 10) ed 2026-06-20 00:58:10 -04:00
  • 1e5a742813 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L1693 render_main_interface autosave to Result[T] (Phase 10 site 9) ed 2026-06-20 00:56:58 -04:00
  • 9188e548ff TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L1647 render_main_interface focus_response to Result[T] (Phase 10 site 8) ed 2026-06-20 00:53:35 -04:00
  • 24191c827d TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L1466 _close_vscode_diff terminate to Result[T] (Phase 10 site 7) ed 2026-06-20 00:52:01 -04:00
  • 96886772fd TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L1152 _gui_func entry log to Result[T] (Phase 10 site 6) ed 2026-06-20 00:50:20 -04:00
  • cab4548f78 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L1052 shutdown save_ini to Result[T] (Phase 10 site 5) ed 2026-06-20 00:49:00 -04:00
  • ad702f7e88 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L728 run() immapp call to Result[T] (Phase 10 site 4) ed 2026-06-20 00:46:43 -04:00
  • e761244c4a TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L612 _post_init callback to Result[T] (Phase 10 site 3) ed 2026-06-20 00:44:30 -04:00
  • 6585cdc5e7 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L264 _resolve_font_path to Result[T] (Phase 10 site 2) ed 2026-06-20 00:43:29 -04:00
  • c73038382e TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L216 _detect_refresh_rate_win32 to Result[T] (Phase 10 site 1) ed 2026-06-20 00:42:06 -04:00
  • 11d331238d chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 462-540 (logging NOT a drain) before Phase 10 ed 2026-06-20 00:31:32 -04:00
  • a6c89dc754 fix(test): loosen Phase 6 invariant assertion to <=3 to remain robust after Phases 7-8 ed 2026-06-20 00:29:22 -04:00
  • 962cb16ae2 conductor(plan): Mark Phase 9 as complete (6b02f49) ed 2026-06-20 00:27:43 -04:00
  • 6b02f49253 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 9: conductor(gui_2): Phase 9 checkpoint — 0 helper/utility sites in this track ed 2026-06-20 00:27:30 -04:00
  • 26b8503f3d TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 9: re-read Helper/utility migration guidance (lines 1000-1020 in plan.md), drain plane section, and Result-recovery pattern. Phase 9 covers helper/utility module-level sites; the audit shows 0 INTERNAL_BROAD_CATCH sites in this category in src/gui_2.py. The one Phase 9 site from the inventory (L1398 _close_vscode_diff) is actually INTERNAL_SILENT_SWALLOW (the bare-except classification), which is handled in Phase 10 (logging NOT a drain). Phase 9 has no sites to migrate in this track. ed 2026-06-20 00:26:45 -04:00
  • e202b4408f conductor(plan): Mark Phase 8 as complete (7ec512c) ed 2026-06-20 00:26:36 -04:00
  • 7ec512c792 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 8: conductor(gui_2): Phase 8 checkpoint — 2 property setter sites migrated ed 2026-06-20 00:26:24 -04:00
  • f0c0de915c TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 8: refactor(gui_2): migrate L897 _capture_workspace_profile to Result[T] (Phase 8) ed 2026-06-20 00:25:33 -04:00
  • d3b71a7304 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 8: refactor(gui_2): migrate L591 _diag_layout_state to Result[T] (Phase 8) ed 2026-06-20 00:24:13 -04:00
  • 16079d930d TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 8: re-read Drain Plane section (lines 396-470, all 5 drain patterns), Result-recovery pattern, and the per-drain-plane routing. Phase 8 covers property setter / state sites. For startup callbacks (L591 _diag_layout_state), the canonical drain is app._startup_timeline_errors (the phase 2 drain plane). For property setters (L897 _capture_workspace_profile), the canonical drain is app._last_request_errors (per FR-BC-4 event-handler drain pattern). ed 2026-06-20 00:22:33 -04:00
  • b0d3915103 conductor(plan): Mark Phase 7 as complete (50ee495) ed 2026-06-20 00:22:09 -04:00
  • 50ee495199 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 7: conductor(gui_2): Phase 7 checkpoint — 1 worker site migrated ed 2026-06-20 00:21:57 -04:00
  • bcfb4887b1 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 7: refactor(gui_2): migrate L4321 worker to Result[T] (Phase 7) ed 2026-06-20 00:20:52 -04:00
  • d0de8e8a1a TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 7: re-read Thread-safe Result accumulation guidance (lines 244-251), Drain Plane section (lines 396-470, especially Pattern 4 telemetry emission), and the Result-recovery pattern (lines 396-460). Phase 7 covers worker/background sites that run on the io_pool thread; the canonical drain is pp.controller._report_worker_error(op_name, result) which acquires pp.controller._worker_errors_lock on append. The lock protects against concurrent appends from multiple worker threads corrupting the list (per app_controller.py:855-856). ed 2026-06-20 00:18:29 -04:00
  • 3f2faff5bc conductor(plan): Mark Phase 6 as complete (c574393) ed 2026-06-20 00:18:21 -04:00
  • c574393c57 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 6: conductor(gui_2): Phase 6 checkpoint — 0 signal-handler sites in this track ed 2026-06-20 00:18:07 -04:00
  • 5aaa411c6b TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 6: re-read Pattern 3 (Intentional app termination, lines 409-419), cross-thread safety section (lines 244-251), and thread-safe Result accumulation guidance. Phase 6 covers signal-handler category sites; the audit shows 0 INTERNAL_BROAD_CATCH sites in this category in src/gui_2.py (the inventory classifies signal-handler try/except under other categories — Phase 6 has no sites in this track). ed 2026-06-20 00:16:41 -04:00
  • d872899eac test(gui_2): add 2 Phase 5 invariant tests + Phase 5 checkpoint ed 2026-06-20 00:09:03 -04:00
  • 2c17fde57e TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L7208 render_beads_tab list to Result[T] (Phase 5) ed 2026-06-20 00:06:52 -04:00
  • 9a3be5eda8 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L5920 render_external_editor_panel config to Result[T] (Phase 5) ed 2026-06-20 00:04:53 -04:00
  • 82b5648f3b TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L5786 render_text_viewer_window ced to Result[T] (Phase 5) ed 2026-06-20 00:02:10 -04:00
  • 6119143400 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L5380 render_operations_hub ext_editor_panel to Result[T] (Phase 5) ed 2026-06-19 23:59:08 -04:00
  • f1cdc926cf TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L3582 render_context_batch_actions preview to Result[T] (Phase 5) ed 2026-06-19 23:56:37 -04:00
  • 5b341038a7 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L3163 render_tool_preset_manager_content bias_save to Result[T] (Phase 5) ed 2026-06-19 23:54:02 -04:00
  • b20ea145b3 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L1428 request_patch_from_tier4 to Result[T] (Phase 5) ed 2026-06-19 23:50:33 -04:00
  • 77a48b18bf TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L1393 _open_patch_in_external_editor to Result[T] (Phase 5) ed 2026-06-19 23:45:29 -04:00
  • 374866619d TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L1367 _apply_pending_patch to Result[T] (Phase 5) ed 2026-06-19 23:39:16 -04:00
  • ce289db999 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L1293 _populate_auto_slices file_read to Result[T] (Phase 5) ed 2026-06-19 23:33:04 -04:00
  • 38b6f5c00f TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L1284 _populate_auto_slices outline to Result[T] (Phase 5) ed 2026-06-19 23:29:10 -04:00
  • 3c34913caa chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 396-407 (Pattern 2 event handler drain) before Phase 5 ed 2026-06-19 22:59:06 -04:00
  • 19c534e54b TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: test(gui_2): add 2 Phase 4 invariant tests + relax Phase 3 invariant for decreasing count ed 2026-06-19 22:56:00 -04:00
  • a213677cf0 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: refactor(gui_2): migrate L3740 render_ast_inspector_modal file_content to Result[T] (Phase 4) ed 2026-06-19 22:52:32 -04:00
  • e558da81e1 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: refactor(gui_2): migrate L3718 render_ast_inspector_modal outline to Result[T] (Phase 4) ed 2026-06-19 22:48:43 -04:00
  • 1ef0e07093 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: refactor(gui_2): migrate L3398 render_persona_editor_window to Result[T] (Phase 4) ed 2026-06-19 22:43:46 -04:00
  • e80b5f787b chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 396-407 (Pattern 2 modal drain) before Phase 4 ed 2026-06-19 22:32:38 -04:00
  • fab2e55b84 fix(tier2): undo sandbox file leaks from 00e5a3f2 ed 2026-06-19 22:31:46 -04:00
  • c33a32c5da conductor(plan): mark Phase 3 complete (8 INTERNAL_BROAD_CATCH sites migrated) ed 2026-06-19 22:27:01 -04:00
  • e622f1ead6 test(gui_2): add 2 Phase 3 invariant tests + Phase 3 checkpoint ed 2026-06-19 22:26:20 -04:00
  • 82c0c1fafe test(gui_2): fix Phase 1 audit test to allow decreasing count (post-Phase 3) ed 2026-06-19 22:25:09 -04:00
  • 0dacbfce62 refactor(gui_2): migrate L4848 render_warmup_status_indicator to Result[T] (Phase 3) ed 2026-06-19 22:22:21 -04:00
  • 500108ea6d refactor(gui_2): migrate L1284 _handle_history_logic to Result[T] (Phase 3) ed 2026-06-19 22:18:53 -04:00
  • 44e2888979 refactor(gui_2): migrate L1222 _show_menus is_max to Result[T] (Phase 3) ed 2026-06-19 22:15:05 -04:00
  • f51abe0795 refactor(gui_2): migrate L1197 _show_menus hwnd to Result[T] (Phase 3) ed 2026-06-19 22:11:14 -04:00
  • bcbd46445f refactor(gui_2): migrate L1171 _show_menus do_generate to Result[T] (Phase 3) ed 2026-06-19 22:07:51 -04:00
  • 0f102612ad refactor(gui_2): migrate L1123 _gui_func render to Result[T] (Phase 3) ed 2026-06-19 22:03:24 -04:00
  • 61cf4055c8 refactor(gui_2): migrate L742 _load_fonts mono font to Result[T] (Phase 3) ed 2026-06-19 21:56:07 -04:00
  • 53412af1b3 refactor(gui_2): migrate L731 _load_fonts main font to Result[T] (Phase 3) ed 2026-06-19 21:53:03 -04:00
  • 8af65ab319 chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 356-518 (Pattern 2 drain) before Phase 3 ed 2026-06-19 21:34:58 -04:00
  • 4e9ab451dc conductor(plan): mark Phase 2 complete (drain plane: 3 render functions + 2 invariant tests) ed 2026-06-19 21:34:06 -04:00
  • 5b139e6ab1 feat(gui_2): add 3 drain-plane render functions (Phase 2, tasks 2.1-2.3) ed 2026-06-19 21:32:24 -04:00
  • 7c93a68f67 conductor(plan): mark Phase 1 complete (site inventory + classification) ed 2026-06-19 21:23:48 -04:00
  • 554fbbd541 test(gui_2): add Phase 1 invariant tests (test_gui_2_result.py, 2 tests) ed 2026-06-19 21:22:27 -04:00
  • a068934db0 chore(audit): Phase 1 - capture audit JSON + 42-site inventory (task 1.1+1.2) ed 2026-06-19 21:13:46 -04:00
  • 83bdc7b85a conductor(plan): mark Phase 0 complete (setup + styleguide re-read) ed 2026-06-19 20:58:05 -04:00
  • 62188d6b0c chore: TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 0 ed 2026-06-19 20:57:18 -04:00
  • bf94fb2b07 conductor(tracks): mark result_migration_gui_2_20260619 active (Phase 0, task 0.1) ed 2026-06-19 20:56:14 -04:00
  • 9dc4a51c8a docs(reports): RESULT_MIGRATION_CAMPAIGN_STATUS_20260619 (campaign 60% complete) ed 2026-06-19 20:49:53 -04:00