chore: TIER-2 READ conductor/code_styleguides/error_handling.md lines 396-407 (Pattern 2 event handler drain) before Phase 5
Per AI Agent Checklist Rule #0 (re-read per phase). Phase 5 focuses on the 13 INTERNAL_BROAD_CATCH sites inside event handler functions. Per the spec (FR-BC-4), the drain for event handlers is to accumulate in app._last_request_errors or a similar per-event accumulator (not imgui.open_popup, since the event handler is called from a button click, not a render frame). Event handler sites (per PHASE1_SITE_INVENTORY.md): - L1335, L1344 (_populate_auto_slices): mcp_client calls - L1418 (_apply_pending_patch): patch modal handler - L1444 (_open_patch_in_external_editor): external editor launch - L1479 (request_patch_from_tier4): tier4 patch generation - L3214 (render_tool_preset_manager_content): modal content render - L3633 (render_context_batch_actions): modal content render - L5430 (render_operations_hub): tab content render - L5836 (render_text_viewer_window): window render - L5970 (render_external_editor_panel): panel render - L7258 (render_beads_tab): tab render The legacy wrapper pattern: extract a _<site>_result helper that returns Result[bool]; the legacy wrapper routes errors to app._last_request_errors.append((op_name, ErrorInfo(...))).
This commit is contained in:
