ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity
3,185 Commits 10 Branches 1 Tag
25112f41577a85afc01ac41fda4ebddf2008b4a5
Commit Graph

3185 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ed 25112f4157 test(live_gui): adapt test_user_request_* to new send_result() flow 
The 2 tests in test_live_gui_integration_v2.py were mocking the old
ai_client.send() and asserting on the old error format. The FR1 fix
migrated _handle_request_event to ai_client.send_result() and routes
errors via ErrorInfo.ui_message() instead of f'ERROR: {e}'.

Updated:
- test_user_request_integration_flow: mock send_result instead of send
- test_user_request_error_handling: mock send_result returning an error
  Result; assert new error format (just the message, no 'ERROR:' prefix)

Per AGENTS.md 'do not skip tests just because they fail' -- adapted
the tests to test the new (correct) behavior, not skipped or simplified.
 2026-06-15 09:25:50 -04:00
ed 24ba249901 fix(ai_loop): route send_result() errors to Discussion Hub as error entries (FR1, Bug #2) 
Replaces deprecated ai_client.send() in _handle_request_event with
send_result() and branches on result.ok. On error, the first ErrorInfo
is routed to the event_queue as a 'response' with status='error',
allowing _on_comms_entry to add it to the discussion history.

The previous code called the @deprecated send() shim which silently
returns '' on error. The empty string was then filtered out by
_on_comms_entry (text_content.strip() check at line 3801), so users
saw no discussion entry for failed AI requests.

This also removes the dead 'except ai_client.ProviderError' clause at
line 3692 (the class was removed in commit 64b787b8). The 2 remaining
dead clauses at lines 305, 313 are fixed in the next commit (FR2).
 2026-06-15 09:22:47 -04:00
ed 9b280a43fb conductor(plan): mark Phase 1 (TDD red) complete 2026-06-15 09:20:41 -04:00
ed 44dc90bca8 test(ai_loop): add FR1/FR2/FR3 tests for ai_loop_regressions_20260614 (TDD red) 
3 bug groups, all reproducing documented regressions:
- test_fr1_*: error response becomes a discussion entry (Bug #2)
- test_fr2_*: no ProviderError references in src/app_controller.py (Bug #1)
- test_fr3_*: MiniMax thinking mono rendering in returned text (Bug #3)

4 critical tests fail for the documented reasons; 3 sanity checks pass.
 2026-06-15 09:18:07 -04:00
ed 52c01c6cbc config 2026-06-15 09:01:53 -04:00
ed f4c497b1e8 conductor: register ai_loop_regressions_20260614 in tracks.md (priority A, ready for Tier 2) 2026-06-15 00:48:12 -04:00
ed acc294ae4e conductor(track): metadata.json for ai_loop_regressions_20260614 2026-06-15 00:44:52 -04:00
ed 884e40b9d1 conductor(track): plan for ai_loop_regressions_20260614 (TDD-style, 5 phases, 17 tasks) 2026-06-15 00:41:57 -04:00
ed 7a4dcc9690 conductor(track): spec for ai_loop_regressions_20260614 (MiniMax/Gemini/Gemini CLI/DeepSeek) 2026-06-15 00:33:04 -04:00
ed 74e02485a1 files & media ux improvemetn with directory folding and file name vis 2026-06-14 23:29:43 -04:00
ed ae8d01d0f7 add missing region start comment. 2026-06-14 22:43:55 -04:00
ed 2d51199699 fix(regression): for adding files in the files & media panel. 2026-06-14 22:43:42 -04:00
ed dcdcaa92f6 tiny 2026-06-13 20:50:36 -04:00
ed 5030bd848f ai client pass (in gemini region) 2026-06-13 20:49:37 -04:00
ed 94ab6dcc6f config 2026-06-13 19:02:24 -04:00
ed c87bb46e4f docs(reports): add MiniMax & OpenAI test regression analysis report 2026-06-13 18:57:56 -04:00
ed 2e91cd7123 test(minimax): add client instantiation unit tests to catch credential and base URL regressions 2026-06-13 18:57:44 -04:00
ed 286f952417 docs(reports): add SSDL Context Curation and Caching Pipeline report 2026-06-13 18:51:14 -04:00
ed 385538f477 docs(reports): add SSDL Conductor Engine DAG execution loop report 2026-06-13 18:49:01 -04:00
ed bcd7ee14cb docs(reports): add SSDL Discussion AI Turn Cycle report 2026-06-13 18:44:57 -04:00
ed cc8771b99b docs(reports): add track completion report for ai_client_docs_20260613 2026-06-13 18:29:21 -04:00
ed 4b4721ded4 Track: Complete track ai_client_docs_20260613 2026-06-13 18:27:50 -04:00
ed 1ccef1685f docs(ai_client): add detailed SQLite-granularity docstrings to secondary senders and context helpers 2026-06-13 18:27:46 -04:00
ed 20b5544d3e doc: add detailed SSDL docstrings to primary provider functions in ai_client.py 2026-06-13 18:08:04 -04:00
ed 9ffd3576f9 Track: Complete Phase 1 of ai_client documentation 
Updates plan.md and state.toml to mark Phase 1 tasks (core loops and public entry points documentation) as completed.
 2026-06-13 18:05:45 -04:00
ed 82f21d7f55 docs(ai_client): add SQLite-granularity docstrings to tool execution functions 
Also fixes return-type discrepancy in tests/test_ai_client_tool_loop.py mock by wrapping NormalizedResponse inside Result.
 2026-06-13 18:05:12 -04:00
ed 94b9e2217a test(ai_client): fix mocked gemini provider send function name to match implementation 2026-06-13 18:00:14 -04:00
ed 752e874bf6 docs(ai_client): add detailed SQLite-granularity docstrings to send() and send_result() 2026-06-13 18:00:10 -04:00
ed 23a8554051 Initialize track: SQLite-Granularity Inline Docs for ai_client.py 
Creates spec, plan, and state configurations to document the dispatch loops, providers, and helper functions in src/ai_client.py.
 2026-06-13 17:55:48 -04:00
ed 501f112591 Fix: Configure base_url dynamically for MiniMax 
This resolves the 401 Unauthorized/invalid api_id error by letting the MiniMax client default to api.minimax.io/v1 (like the model listing logic) or read a custom base_url from credentials.toml.
 2026-06-13 17:53:22 -04:00
ed 3aa7bdca99 Fix: Return NormalizedResponse from send_openai_compatible 
This resolves the issue where calling 'send_openai_compatible' discarded the NormalizedResponse details, resulting in an AttributeError when accessing 'raw_response' inside the tool loop.
 2026-06-13 17:50:43 -04:00
ed fbcc1db495 Fix: NameError when instantiating MiniMax client 
Resolve name error where OpenAI was not defined in the scope of _ensure_minimax_client by calling openai.OpenAI directly.
 2026-06-13 17:47:40 -04:00
ed 6caa6680bf working on ai client 2026-06-13 17:46:38 -04:00
ed 3b6a9dd0dc remove clusters (artifacts forcing more token emission on gemini) 2026-06-13 16:57:51 -04:00
ed 1761aacff3 Docs: Complete detailed SSDL guide via cluster append 
This adds SSDL Cluster 2 (Branch Defusing Mechanics) and Cluster 3 (Python-to-SSDL Mapping Rules) to the docs and combines them into guide_ssdl.md.
 2026-06-13 16:56:11 -04:00
ed 661eebffa6 Docs: Add in-depth guide to SSDL (Sketch DSL) 2026-06-13 16:52:23 -04:00
ed fd1de30c5c Docs: Expand guide to ASCII UI Layout Map DSL with detailed sections 2026-06-13 16:49:09 -04:00
ed 9c650d0554 Docs: Add in-depth guide to ASCII UI Layout Map DSL 2026-06-13 16:47:48 -04:00
ed e02a865dea Docstrings: Complete registration of continued SQLite inline docs track 2026-06-13 16:45:23 -04:00
ed 4691848683 Docstrings: SSDL + ASCII Layout Map for Personas, Providers, and Command Palette 2026-06-13 16:45:12 -04:00
ed cb129aaed9 Docstrings: SSDL + ASCII Layout Map for Preset Managers and Windows 2026-06-13 16:30:34 -04:00
ed 1136273331 finished going through the entire gui_2.py minor sift through ai client 2026-06-13 16:16:03 -04:00
ed f2fa566064 oops 2026-06-13 12:02:21 -04:00
ed 9fc2c21e82 more gui_2.py 2026-06-13 12:00:33 -04:00
ed b61a2db01d reading more code, slight adjustment to ast structual file editor ux (radio buttons going off viewport) 2026-06-13 11:08:45 -04:00
ed 394020e50c reading throuogh gui_2.py (still reading) 2026-06-13 10:27:48 -04:00
ed 26b1ec77a4 curation pass on gui_2.py 2026-06-12 23:38:31 -04:00
ed d4fbcb16d9 more diagrams (claude on agy) 2026-06-12 22:48:09 -04:00
ed c00161a13d Adjust audi_line_count.py to take into account doc strings 2026-06-12 22:47:58 -04:00
ed aafdf3acc6 Docstrings: SSDL + ASCII Layout Map for Misc Tools and remaining MMA sub-functions 2026-06-12 22:38:38 -04:00