finished going through the entire gui_2.py minor sift through ai client

src/ai_client.py

@@ -79,10 +79,7 @@ events: EventEmitter = EventEmitter()
 #region: Provider Configuration
 
 def set_model_params(temp: float, max_tok: int, trunc_limit: int = 8000, top_p: float = 1.0) -> None:
- """
- Sets global generation parameters like temperature and max tokens.
- [C: src/app_controller.py:AppController._handle_request_event, src/app_controller.py:_api_generate]
- """
+ """Sets global generation parameters like temperature and max tokens."""
  global _temperature, _max_tokens, _history_trunc_limit, _top_p
  _temperature         = temp
  _max_tokens          = max_tok
@@ -150,17 +147,11 @@ _local_storage = threading.local()
 _tool_approval_modes: dict[str, str] = {}
 
 def get_current_tier() -> Optional[str]:
- """
- Returns the current tier from thread-local storage.
- [C: src/app_controller.py:AppController._on_tool_log, tests/test_ai_client_concurrency.py:intercepted_append]
- """
+ """Returns the current tier from thread-local storage."""
  return getattr(_local_storage, "current_tier", None)
 
 def set_current_tier(tier: Optional[str]) -> None:
- """
- Sets the current tier in thread-local storage.
- [C: src/app_controller.py:AppController._handle_request_event, src/conductor_tech_lead.py:generate_tickets, src/multi_agent_conductor.py:run_worker_lifecycle, tests/test_ai_client_concurrency.py:run_t1, tests/test_ai_client_concurrency.py:run_t2, tests/test_mma_agent_focus_phase1.py:reset_tier, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_none_when_unset, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_set_when_current_tier_set, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_tier2]
- """
+ """Sets the current tier in thread-local storage."""
  _local_storage.current_tier = tier
 
 # Increased to allow thorough code exploration before forcing a summary
@@ -198,10 +189,7 @@ _project_context_marker:         str = ""
 #region: System Prompt Management
 
 def set_custom_system_prompt(prompt: str) -> None:
- """
- Sets a custom system prompt to be combined with the default instructions.
- [C: simulation/user_agent.py:UserSimAgent.generate_response, src/app_controller.py:AppController._do_generate, src/app_controller.py:AppController._handle_request_event, src/app_controller.py:_api_generate, src/conductor_tech_lead.py:generate_tickets, src/multi_agent_conductor.py:run_worker_lifecycle, src/orchestrator_pm.py:generate_tracks, tests/test_system_prompt_exposure.py:TestSystemPromptExposure.setUp]
- """
+ """Sets a custom system prompt to be combined with the default instructions."""
  global _custom_system_prompt
  _custom_system_prompt = prompt
 
@@ -236,9 +224,6 @@ def _get_combined_system_prompt(preset: Optional[ToolPreset] = None, bias: Optio
  return base
 
 def get_combined_system_prompt(preset: Optional[ToolPreset] = None, bias: Optional[BiasProfile] = None) -> str:
- """
- [C: src/app_controller.py:AppController._do_generate, src/app_controller.py:AppController._handle_request_event]
- """
  return _get_combined_system_prompt(preset, bias)
 
 _comms_log: deque[dict[str, Any]] = deque(maxlen=1000)
@@ -250,27 +235,16 @@ COMMS_CLAMP_CHARS: int = 300
 #region: Comms Log
 
 def get_comms_log_callback() -> Optional[Callable[[dict[str, Any]], None]]:
- """
- Returns the comms log callback (thread-local with global fallback).
- [C: src/multi_agent_conductor.py:run_worker_lifecycle]
- """
  tl_cb = getattr(_local_storage, "comms_log_callback", None)
  if tl_cb: return tl_cb
  return comms_log_callback
 
 def set_comms_log_callback(cb: Optional[Callable[[dict[str, Any]], None]]) -> None:
- """
- Sets the comms log callback (both global and thread-local).
- [C: src/app_controller.py:AppController._init_ai_and_hooks, src/multi_agent_conductor.py:run_worker_lifecycle]
- """
  global comms_log_callback
  comms_log_callback = cb
  _local_storage.comms_log_callback = cb
 
 def _append_comms(direction: str, kind: str, payload: dict[str, Any]) -> None:
- """
- [C: tests/test_ai_client_concurrency.py:run_t1, tests/test_ai_client_concurrency.py:run_t2, tests/test_mma_agent_focus_phase1.py:test_append_comms_has_source_tier_key, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_none_when_unset, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_set_when_current_tier_set, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_tier2]
- """
  entry: dict[str, Any] = {
   "ts":          datetime.datetime.now().strftime("%H:%M:%S"),
   "direction":   direction,
@@ -287,27 +261,15 @@ def _append_comms(direction: str, kind: str, payload: dict[str, Any]) -> None:
   _cb(entry)
 
 def get_comms_log() -> list[dict[str, Any]]:
- """
- [C: src/app_controller.py:AppController._bg_task, src/app_controller.py:AppController._recalculate_session_usage, src/app_controller.py:AppController._start_track_logic, src/multi_agent_conductor.py:run_worker_lifecycle, tests/test_mma_agent_focus_phase1.py:test_append_comms_has_source_tier_key, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_none_when_unset, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_set_when_current_tier_set, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_tier2, tests/test_token_usage.py:test_token_usage_tracking]
- """
  return list(_comms_log)
 
 def clear_comms_log() -> None:
- """
- [C: src/app_controller.py:AppController._handle_reset_session, src/gui_2.py:App._render_comms_history_panel, src/gui_2.py:App._show_menus, tests/test_ai_client_concurrency.py:test_ai_client_tier_isolation, tests/test_token_usage.py:test_token_usage_tracking]
- """
  _comms_log.clear()
 
 def get_credentials_path() -> Path:
- """
-  [C: src/mcp_client.py:_is_allowed]
- """
  return Path(os.environ.get("SLOP_CREDENTIALS", str(Path(__file__).parent.parent / "credentials.toml")))
 
 def _load_credentials() -> dict[str, Any]:
- """
-  [C: src/ai_server.py:_send_anthropic, src/ai_server.py:_send_deepseek, src/ai_server.py:_send_gemini, src/ai_server.py:_send_minimax, src/ai_server.py:handle_command, tests/test_deepseek_infra.py:test_credentials_error_mentions_deepseek, tests/test_minimax_provider.py:test_minimax_credentials_template]
- """
  cred_path = get_credentials_path()
  try:
   with open(cred_path, "rb") as f:
@@ -407,15 +369,13 @@ def _classify_minimax_error(exc: Exception, source: str = "ai_client.minimax") -
  return ErrorInfo(kind=ErrorKind.UNKNOWN, message=body, source=source, original=exc)
 
 def set_provider(provider: str, model: str, validate: bool = True) -> None:
- """
- Updates the active LLM provider and model name.
+ """Updates the active LLM provider and model name.
 
  When validate is True (default), the model is checked against the provider's
  LIVE model list, which for gemini_cli/minimax means a blocking subprocess /
  network call (and importing the provider SDK). Pass validate=False during
  startup so the GUI's first frame is not blocked — AppController._fetch_models
  corrects the model against the live list shortly after, off the main thread.
- [C: src/app_controller.py:AppController._handle_reset_session, src/app_controller.py:AppController._init_ai_and_hooks, src/app_controller.py:AppController.current_model, src/app_controller.py:AppController.current_provider, src/app_controller.py:AppController.do_fetch, src/multi_agent_conductor.py:run_worker_lifecycle, src/orchestrator_pm.py:generate_tracks, tests/conftest.py:reset_ai_client, tests/test_ai_cache_tracking.py:test_gemini_cache_tracking, tests/test_ai_client_cli.py:test_ai_client_send_gemini_cli, tests/test_api_events.py:test_send_emits_events_proper, tests/test_api_events.py:test_send_emits_tool_events, tests/test_deepseek_provider.py:test_deepseek_completion_logic, tests/test_deepseek_provider.py:test_deepseek_model_selection, tests/test_deepseek_provider.py:test_deepseek_payload_verification, tests/test_deepseek_provider.py:test_deepseek_reasoner_payload_verification, tests/test_deepseek_provider.py:test_deepseek_reasoning_logic, tests/test_deepseek_provider.py:test_deepseek_streaming, tests/test_deepseek_provider.py:test_deepseek_tool_calling, tests/test_gemini_cli_edge_cases.py:test_gemini_cli_loop_termination, tests/test_gemini_cli_integration.py:test_gemini_cli_full_integration, tests/test_gemini_cli_integration.py:test_gemini_cli_rejection_and_history, tests/test_gemini_cli_parity_regression.py:test_send_invokes_adapter_send, tests/test_gui2_mcp.py:test_mcp_tool_call_is_dispatched, tests/test_minimax_provider.py:test_minimax_default_model, tests/test_minimax_provider.py:test_minimax_model_selection, tests/test_mma_agent_focus_phase1.py:test_append_comms_has_source_tier_key, tests/test_rag_integration.py:test_rag_integration, tests/test_tier4_interceptor.py:test_ai_client_passes_qa_callback, tests/test_tier4_interceptor.py:test_gemini_provider_passes_qa_callback_to_run_script, tests/test_token_usage.py:test_token_usage_tracking]
  """
  global _provider, _model
  _provider = provider
@@ -442,17 +402,11 @@ def set_provider(provider: str, model: str, validate: bool = True) -> None:
   _model = model
 
 def get_provider() -> str:
- """
-  Returns the current active provider name.
-  [C: src/multi_agent_conductor.py:run_worker_lifecycle]
- """
+ """Returns the current active provider name."""
  return _provider
 
 def cleanup() -> None:
- """
-  Performs cleanup operations like deleting server-side Gemini caches.
-  [C: src/app_controller.py:AppController.clear_cache, src/app_controller.py:AppController.shutdown, tests/test_ai_cache_tracking.py:test_gemini_cache_tracking_cleanup, tests/test_log_registry.py:TestLogRegistry.tearDown, tests/test_project_serialization.py:TestProjectSerialization.tearDown]
- """
+ """Performs cleanup operations like deleting server-side Gemini caches."""
  global _gemini_client, _gemini_cache, _gemini_cached_file_paths
  if _gemini_client and _gemini_cache:
   try:
@@ -462,10 +416,7 @@ def cleanup() -> None:
  _gemini_cached_file_paths = []
 
 def reset_session() -> None:
- """
-  Clears conversation history and resets provider-specific session state.
-  [C: src/app_controller.py:AppController._handle_reset_session, src/app_controller.py:AppController.current_model, src/app_controller.py:AppController.current_provider, src/app_controller.py:AppController.init_state, src/gui_2.py:App._render_provider_panel, src/gui_2.py:App._show_menus, src/multi_agent_conductor.py:run_worker_lifecycle, tests/conftest.py:live_gui, tests/conftest.py:reset_ai_client, tests/test_ai_cache_tracking.py:test_gemini_cache_tracking, tests/test_ai_client_cli.py:test_ai_client_send_gemini_cli, tests/test_api_events.py:test_send_emits_events_proper, tests/test_api_events.py:test_send_emits_tool_events, tests/test_deepseek_provider.py:test_deepseek_payload_verification, tests/test_deepseek_provider.py:test_deepseek_reasoner_payload_verification, tests/test_gemini_cli_integration.py:test_gemini_cli_full_integration, tests/test_gemini_cli_integration.py:test_gemini_cli_rejection_and_history, tests/test_gemini_metrics.py:test_get_gemini_cache_stats_with_mock_client, tests/test_headless_simulation.py:test_mma_track_lifecycle_simulation, tests/test_mma_agent_focus_phase1.py:test_append_comms_has_source_tier_key, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_none_when_unset, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_set_when_current_tier_set, tests/test_mma_agent_focus_phase1.py:test_append_comms_source_tier_tier2, tests/test_session_logger_reset.py:test_reset_session, tests/test_token_usage.py:test_token_usage_tracking]
- """
+ """Clears conversation history and resets provider-specific session state."""
  global _gemini_client, _gemini_chat, _gemini_cache
  global _gemini_cache_md_hash, _gemini_cache_created_at, _gemini_cached_file_paths
  global _anthropic_client, _anthropic_history
@@ -2208,7 +2159,7 @@ def _ensure_grok_client() -> Any:
   _grok_client = openai.OpenAI(api_key=api_key, base_url="https://api.x.ai/v1")
  return _grok_client
 
-def _send_grok_result(md_content: str, user_message: str, base_dir: str,
+def _send_grok(md_content: str, user_message: str, base_dir: str,
  file_items: list[dict[str, Any]] | None = None,
  discussion_history: str = "",
  stream: bool = False,
@@ -2260,7 +2211,7 @@ def _list_grok_models() -> list[str]:
  from src.vendor_capabilities import list_models_for_vendor
  return list_models_for_vendor("grok")
 
-def _send_minimax_result(md_content: str, user_message: str, base_dir: str,
+def _send_minimax(md_content: str, user_message: str, base_dir: str,
  file_items: list[dict[str, Any]] | None = None,
  discussion_history: str = "",
  stream: bool = False,
@@ -2432,7 +2383,7 @@ def _ensure_llama_client() -> Any:
   _llama_client = openai.OpenAI(api_key=_llama_api_key, base_url=_llama_base_url)
  return _llama_client
 
-def _send_llama_result(md_content: str, user_message: str, base_dir: str,
+def _send_llama(md_content: str, user_message: str, base_dir: str,
  file_items: list[dict[str, Any]] | None = None,
  discussion_history: str = "",
  stream: bool = False,
@@ -2497,7 +2448,7 @@ def ollama_chat(
  resp = requests.post(f"{base_url}/api/chat", json=payload, timeout=120)
  return resp.json()
 
-def _send_llama_native_result(md_content: str, user_message: str, base_dir: str,
+def _send_llama_native(md_content: str, user_message: str, base_dir: str,
  file_items: list[dict[str, Any]] | None = None,
  discussion_history: str = "",
  stream: bool = False,
@@ -2751,7 +2702,7 @@ def send_result(
      stream, pre_tool_callback, qa_callback, stream_callback, patch_callback
     )
    elif p == "minimax":
-    res = _send_minimax_result(
+    res = _send_minimax(
      md_content, user_message, base_dir, file_items, discussion_history,
      stream, pre_tool_callback, qa_callback, stream_callback, patch_callback
     )
@@ -2771,7 +2722,7 @@ def send_result(
      stream, pre_tool_callback, qa_callback, stream_callback, patch_callback
     )
    elif p == "llama_native":
-    res = _send_llama_native_result(
+    res = _send_llama_native(
      md_content, user_message, base_dir, file_items, discussion_history,
      stream, pre_tool_callback, qa_callback, stream_callback, patch_callback
     )