Commit Graph
100 Commits
Author SHA1 Message Date
Nikita Smith e8aaf00629 prune dead static imports with /OPT:REF 2026-08-25 00:10:50 -07:00
Nikita Smith 5894d3eaa2 count merged BSS in initialized data size 2026-08-25 00:10:50 -07:00
Nikita Smith f6116bbede match LINK resource section layout 2026-08-25 00:10:49 -07:00
Nikita Smith a11e2bf57b manifest generation fix 2026-08-25 00:10:30 -07:00
Nikita Smith d1171dcabb fix PE initialized data size 2026-08-25 00:10:30 -07:00
Nikita Smith e283952994 match LINK import encoding and load config 2026-08-25 00:10:30 -07:00
Nikita Smith c9acc3f1ad match LINK import group placement 2026-08-25 00:10:29 -07:00
Nikita Smith 0a328898d0 sort contributions after section merges 2026-08-24 22:27:27 -07:00
Nikita Smith ad8fe1c61e implement LINK-compatible map output 2026-08-24 22:27:26 -07:00
Nikita Smith da00fa9627 use iterators to access COFF sections and symbols 2026-08-24 22:27:25 -07:00
Nikita Smith e3d49069bf remove helper for patching symbols and update values directly 2026-08-24 22:27:23 -07:00
Nikita Smith a7e1b21e4e use base bit array for primary symbols 2026-08-24 22:27:22 -07:00
Nikita Smith 736a6c63a5 remove per-section linker side arrays 2026-08-24 22:27:21 -07:00
Nikita Smith 646ff97b3c centralize canonical COFF object data 2026-08-24 22:27:20 -07:00
Nikita Smith cf67aca7da keep COFF input metadata immutable 2026-08-24 22:27:19 -07:00
Nikita Smith 993df2d9d8 pack CodeView leaf refs and share radix sort
centralize leaf ref index casts
2026-08-24 22:27:17 -07:00
Nikita Smith 7633bd90ab use packed linker symbol and section contribution arrays 2026-08-24 22:27:16 -07:00
Nikita Smith 3c719de3f5 use callee info to disambiguate overlapping sibling inline sites 2026-08-21 10:56:19 -07:00
Nikita Smith 8b52934c66 set lower bound on CodeOffset 2026-08-21 10:56:18 -07:00
Nikita Smith 8fa5ba5b60 shift type index base for PCH objs 2026-08-21 10:56:17 -07:00
Nikita Smith 24e321925a update the change log 2026-08-21 10:56:16 -07:00
Nikita Smith 109180131a bugfix forwarder export detection 2026-08-21 10:56:16 -07:00
Nikita Smith 2767895b88 turn off diagnostic for unresolved symbols in debug sections on /DEBUG:NONE 2026-08-21 10:56:15 -07:00
Nikita Smith 2abbae4d90 improve unresolved symbols diagnostic
* show referenced by function
* show inline site that references unresolved symbol instead of the top function
2026-08-21 10:56:14 -07:00
Nikita Smith 4eae2a2ecc clang fixes 2026-08-21 10:56:14 -07:00
Nikita Smith 33f5a27fdd work around for the function overrides 2026-08-18 10:49:40 -07:00
Nikita Smith efe2a78019 type command-line option values
* pass argv inputs directly to the config command line
* define each option's value type in the switch table so comma splitting
  is applied only to list typed switches
2026-08-17 22:55:58 -07:00
Nikita Smith 76e267482f improve handling of the response files
* reject cyclic response files
* prepend and append command line defined in LINK and _LINK_
* reduce config wrappers
2026-08-17 18:21:05 -07:00
Nikita Smith b8574e3a0b left a todo in the linker IO code 2026-08-17 14:35:27 -07:00
Nikita Smith 84d88b3946 discard environment variable RAD_TYPE_SERVER
Linker already provides /RAD_TYPE_SERVER that switches linker into
the type server mode, having a environment variable is redundant
2026-08-17 13:11:24 -07:00
Nikita Smith e636345384 update memfun.h 2026-08-14 13:26:58 -07:00
Nikita Smith 3057d0b7da minor fix 2026-08-13 15:02:21 -07:00
Nikita Smith 1086d1d350 reduce arena footprint by using initial reserve and commit size parameters
`current` points to the most recently allocated arena. If that arena was
allocated by a large push, lets say 2 GiB, while the arena's initial
reserve size was 1 GiB, the next block would be allocated with a 2 GiB
reserve.
2026-08-13 15:02:20 -07:00
Nikita Smith 72c3dfd30c improve diagnostics for the missing entry point 2026-08-13 15:02:19 -07:00
Nikita Smith 6a34ee168f update /OPT:ICF
* pass over fold stats diagnostic
* implement /RAD_ICF_HASH_KIND
* rename color space -> scope
2026-08-13 15:02:18 -07:00
Nikita Smith 0c2f79d2f9 update natvis 2026-08-13 15:02:17 -07:00
Nikita Smith cd82268a07 polish ICF section color-space picker 2026-07-27 14:47:30 -07:00
Nikita Smith 4235fa85b4 search small libraries on the main thread to reduce wait times in barriers 2026-07-27 14:47:29 -07:00
Nikita Smith db0151c3e2 parallel radix sort and coalesce adjacent section contribs 2026-07-27 14:47:29 -07:00
Nikita Smith bbb136c9ea radix sort pass over section contribs 2026-07-27 14:47:28 -07:00
Nikita Smith 2d827ac15d make const data eligible for ICF 2026-07-27 14:47:28 -07:00
Nikita Smith c629c5b10e refactor PDB background file output
Add a shared multi-file background writer with lazy worker startup.
Represent PDB output as a file artifact, keep PDB output state internal
to the builder, and overlap deferred PDB writers with the file maps release.
2026-07-27 14:47:27 -07:00
Nikita Smith c96c9620d0 WIP PDB Writer Thread 2026-07-27 14:47:26 -07:00
Nikita Smith a73e3e0790 use cycle tracking only on weak and undefined symbols
* profile of /OPT:REF shows that early push to seen_hm dominates the pass;
  cost: 74.23ms -> 6.81ms (-90.8%)
2026-07-27 14:47:26 -07:00
Nikita Smith fcee35f3e9 rename RAD_TypeHashAlg; extend /RAD_DEBUG_TYPE_HASH with XXHASH option 2026-07-27 14:47:25 -07:00
Nikita Smith 97a1fe6006 radix sort PSI address map 2026-07-27 14:47:24 -07:00
Nikita Smith 134cfce799 merge debug info and llvm_addrsig finders into lnk_obj_initer to reduce
time spent in barrier_wait
2026-07-27 14:47:24 -07:00
Nikita Smith 4cc0f4813b WIP cache COFF symbol interp 2026-07-27 14:47:23 -07:00
Nikita Smith a779d3f1a5 WIP assigned symbols 2026-07-27 14:47:22 -07:00
Nikita Smith 493241c1da WIP light COFF symbol table parse 2026-07-27 14:47:22 -07:00
Nikita Smith bd2cbfc127 gate for page pre-faulting on windows 2026-07-27 14:47:21 -07:00
Nikita Smith cb6443ce4e release file maps before exit in parallel before exit 2026-07-27 14:47:20 -07:00
Nikita Smith 58b5b3d92d search chunks only grow while resolving libraries, so revisit only symbols appended since this library's last search 2026-07-27 14:47:20 -07:00
Nikita Smith b84d32d9fb optimize ICF refinement and COMDAT handling
Cache immutable section and relocation metadata before color refinement,
then reuse generated-tagged concurrent tables.

Parallelize grouping and fold marking.

Include associative COMDAT descendants in contribution hashes and
canonicalize relocation targets to selected COMDAT leaders.
2026-07-27 14:47:19 -07:00
Nikita Smith abfea7c33a update CHANGELOG.md 2026-07-27 14:47:18 -07:00
Nikita Smith d1b0bc0af7 refine COMDAT symlink handling
Stop treating COMDAT section-definition symbols as symlink anchors.
Keep zero-sized COMDAT sections only when they have an owned symlink,
so referenced empty COMDAT symbols still resolve while marker sections
like .gsspr/.gssep are skipped.

Update COMDAT/ICF tests to cover zero-sized COMDAT relocation behavior
and the adjusted removed-COMDAT handling.
2026-07-27 14:47:18 -07:00
Nikita Smith 8ec931d724 fix import data directory bounds
Include the null import descriptor in the import directory size and derive
the IAT directory RVA from the first import descriptor of the start of
the .idata contribution.
2026-07-27 14:47:17 -07:00
Nikita Smith 048b93b166 remove empty sections if it does not have any section contributions too 2026-07-27 14:47:17 -07:00
Nikita Smith f3d2792fb8 simplify COMDAT leader symbol patching
Collapse COMDAT leader symbol patching to a single raw-symbol write path
and make the same-object versus cross-object symlink handling explicit.
Preserve public symbol offsets for ICF folds while avoiding cross-object
section number rewrites.
2026-07-27 14:47:16 -07:00
Nikita Smith 7197398f31 split external-symbol handling from section-definition fallbacks 2026-07-27 14:47:15 -07:00
Nikita Smith d790412219 refactor radlink section gathering
Fold section definition and contributions collection into a worker-count
task with barriers around the serial merge. Share section filtering
between both phases and keep zero-size COMDATs so offset-zero symbols
still map to a section.
2026-07-27 14:47:15 -07:00
Nikita Smith b77c958b5f add DEF, GUARD, and SECTION config support
Parse /DEF, /GUARD, and /SECTION switches, including DEF
handling for NAME/LIBRARY, BASE, VERSION, HEAPSIZE, STACKSIZE, EXPORTS,
and SECTIONS.

Store section directives in linker config and apply them consistently
when gathering object sections when pushing/searching image sections.

Pull load-config symbols for /GUARD without setting GUARD_CF until guard
tables are emitted.

Add coverage for DEF file parity, section directives, and guard
load-config handling.
2026-07-27 14:47:14 -07:00
Nikita Smith 35722f2a01 handle BOMs in linker response files
Decode UTF-16LE response files with a BOM and strip UTF-8 BOMs before
parsing arguments. Add coverage for UTF-16 response-file input.
2026-07-27 14:47:13 -07:00
Nikita Smith 25430ea522 assign COMDAT symlinks after weak symbol replacement
Previously, COMDAT symlinks were assigned as each object batch was loaded.
Weak symbol replacement could later change the selected leader, leaving
objects from earlier passes with stale COMDAT leader refs. Library search
does not need symlinks to be valid, so solve this by doing a single sweep
assignment of COMDAT leaders after a fixed point is found.
2026-07-27 14:47:13 -07:00
Nikita Smith 65541eaf91 LLVM BC magic sniffer 2026-07-27 14:47:12 -07:00
Nikita Smith afd454b41f fix DBI SC image-section range mapping
Log and skip section contributions that fail to map into the linked image.
Keep a file-range-to-section-number map so compact file ranges produce the
correct DBI section numbers.
2026-07-27 14:47:12 -07:00
Nikita Smith 541727b819 debug log unresolved symbols specified in .llvm_addrsig 2026-07-27 14:47:11 -07:00
Nikita Smith 3eeae8d365 enable binary for stdout and stderr to bypass CRLF mangling issues in
captured output under build systems
2026-07-27 14:47:10 -07:00
Nikita Smith 83c55aebdc check that __imp_* archive symbols are import members before applying
import queue flags to the member
2026-07-27 14:47:09 -07:00
Nikita Smith 941b8a011e duplicate identical search aliases are not an error case 2026-07-27 14:47:09 -07:00
Nikita Smith d34e1a7802 implement /OPT:ICF
Add identical COMDAT folding using a color-refinement over foldable
read-only sections. Hash section contents, relocation targets, and target
colors until partitions stabilize, then redirect folded COMDAT symlinks
and discard duplicate sections.

Honor .llvm_addrsig via /LLVM_ADDRSIG so address-significant sections
are not folded, keep separate color space for code, unwind info, and
MSVC vftables, and update COMDAT symbol/section mapping after folding.

Add linker tests covering function folding, relocation-sensitive folds,
alignment, color-space separation, symlink chains, .llvm_addrsig,
pdata/xdata, and C++ ICF cases.
2026-07-27 14:47:08 -07:00
Nikita Smith 1ea9fae835 debug report live stats after /OPT:REF pass 2026-07-27 14:47:08 -07:00
Nikita Smith 4daefad31e map GNU lib extension 2026-06-23 12:32:52 -07:00
Nikita Smith 765b61152d sort import library member refs by input index 2026-06-23 12:32:52 -07:00
Nikita Smith ad20900fc0 import hash table -> hash map 2026-06-23 12:32:51 -07:00
Nikita Smith 8dbced6995 set flag on import member from the originally linked library, otherwise
on subsequent passes linker may queue same import
2026-06-23 12:32:50 -07:00
Nikita Smith 84d025e940 force inline string compars 2026-06-23 12:32:50 -07:00
Nikita Smith 4f899ac678 update memfun 2026-06-19 20:12:27 -07:00
Nikita Smith 05a024ddb3 remove /RAD_ALT_PCH_DIR
* Instead of matching on file path in LF_PRECOMP, loop over the objects
  with .debug$P and probe leaves at the index specified in LF_PRECOMP.
  If signatures match, use the PCH.
* Demote LNK_Error_PrecompObjNotFound to a recoverable error.
2026-06-19 20:12:27 -07:00
Nikita Smith 9b63131f37 ditch semaphores in thread pool in favor of barriers 2026-06-19 20:12:26 -07:00
Nikita Smith 6ea9bfc5a3 fix tail comparisons 2026-06-19 20:12:25 -07:00
Nikita Smith c81c072018 includes for rdi_from_codeview 2026-06-19 20:12:25 -07:00
Nikita Smith 3534100e8d lazy touch obj string tables 2026-06-19 20:12:24 -07:00
Nikita Smith 9616307503 add extra node to the symbol ref for better insertion per 2026-06-19 20:12:24 -07:00
Nikita Smith 871f94a202 use vectorized memory functions in the base strings 2026-06-19 20:12:23 -07:00
Nikita Smith ba32d7fdec use CL driver when compiling with clang on windows to simplify compile and link lines 2026-06-19 20:12:22 -07:00
Nikita Smith 8ef58def99 update torture
* factor test registration logic out of the macro to improve debuggability
* expand the test registration logic
* rename group -> layer for consistency
* fix indentation in the slow tests summary
2026-06-19 20:12:22 -07:00
Nikita Smith b8bad9a82e range helper that computes max part from min+size 2026-06-16 17:22:53 -07:00
Nikita Smith 267b8fc519 missing count in the range list concat 2026-06-16 17:22:52 -07:00
Nikita Smith 956df5527a switch type server from PDB to a custom file format (RRT) 2026-06-16 17:22:50 -07:00
Nikita Smith c030488814 fallback on PCH signature when file path match fails 2026-06-13 06:20:40 -07:00
Nikita Smith c6a4e4c02b skip broken tests 2026-06-12 15:34:30 -07:00
Nikita Smith 41e6470d28 fix radbin launch in p2r determinism test 2026-06-12 15:34:29 -07:00
Nikita Smith 7d8aa18e4d make debug hash section tests error number agnostic 2026-06-12 13:54:29 -07:00
Nikita Smith ac0c7d9441 on checkout do git LFS in github actions 2026-06-12 13:35:10 -07:00
Nikita Smith 7ad422f8ad make run_tests.sh executable 2026-06-12 13:21:31 -07:00
Nikita Smith 2a5070bb87 update change log 2026-06-12 13:17:21 -07:00
Nikita Smith ac8c3e7a2d do not emit relocation for empty resource entry 2026-06-12 12:05:45 -07:00
Nikita Smith 3f6d5df899 apply merge fixes 2026-06-12 11:53:15 -07:00
Nikita Smith 9ce6b9504b centralize section header reads and writes 2026-06-12 11:40:03 -07:00