Private
Public Access
0
0
Files
manual_slop/tests
ed 8d58d7fc46 fix(warmup): defer _done_event.set() until after callbacks fire
WarmupManager._record_success and _record_failure used to set
self._done_event.set() inside the with self._lock: block, BEFORE
calling the user-registered on_complete callbacks. This created
a race: a test thread calling mgr.wait() could observe
mgr.is_done() == True and proceed before the worker thread had
finished firing the callbacks. The mgr.on_complete caller would
then assert on state that the callback was supposed to mutate
(e.g. test_warmup_on_complete_callback_fires' `received` list).

Fix: move self._done_event.set() to AFTER the for cb in callbacks:
loop in both _record_success and _record_failure. The done event
is now set last, so wait() cannot return until all callbacks
have completed (or raised, which is swallowed by the try/except).

ALSO fix the previously-corrupted state of warmup.py (the result
of a misused set_file_slice edit that left orphaned code with no
def line for _record_failure). _record_failure is now a proper
class method with the def line restored.

ALSO fix tests/test_warmup.py:
  - test_warmup_on_complete_callback_fires: the test body was
    missing the pool/mgr setup. Added the missing lines.
  - test_warmup_done_event_set_after_all_complete: removed the
    racy `assert not mgr.is_done()` assertion that fires
    immediately after submit. On a fast machine, os/sys warmup
    completes in microseconds, so is_done() is already True
    by the time the assertion runs. The remaining assertion
    (`assert mgr.is_done()` after wait) still tests the
    semantic that the done event is set after completion.
  - Removed both `@pytest.mark.skip` markers; the underlying
    issues are now fixed in production code AND the tests.

Verified: 10/10 tests in tests/test_warmup.py pass (previously
2 skipped, 2 failed).
2026-06-07 16:02:30 -04:00
..
2026-03-05 17:13:59 -05:00
2026-05-10 15:14:54 -04:00
2026-05-20 07:51:58 -04:00
2026-03-05 16:37:30 -05:00
2026-03-05 17:13:59 -05:00
2026-03-05 16:37:30 -05:00
2026-03-07 20:32:59 -05:00
2026-03-06 22:03:59 -05:00
2026-03-05 17:13:59 -05:00
2026-03-12 19:08:51 -04:00
2026-03-05 15:10:53 -05:00
2026-03-12 19:08:51 -04:00
2026-03-12 19:08:51 -04:00
2026-05-20 07:51:58 -04:00
2026-05-20 07:51:58 -04:00
ok
2026-03-07 21:40:40 -05:00