ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

chore(conductor): Mark track 'fix_imgui_keys_down_20260601' as complete

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-06-01 17:56:24 -04:00
parent 2d035c1fda
commit 8f5565ed04
4 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks.md
+1 -1
View File
@@ -273,5 +273,5 @@ This file tracks all major tracks for the project. Each track has its own detail
---
- [ ] **Track: Fix `keys_down` AttributeError in ImGui IO**
- [x] **Track: Fix `keys_down` AttributeError in ImGui IO**
*Link: [./tracks/fix_imgui_keys_down_20260601/](./tracks/fix_imgui_keys_down_20260601/)*
conductor/tracks/fix_imgui_keys_down_20260601/plan.md
+10 -10
View File
@@ -1,13 +1,13 @@
# Implementation Plan: Fix `keys_down` AttributeError
## Phase 1: Investigation and Implementation
- [ ] Task: Investigate ImGui API
- [ ] Identify the correct `imgui-bundle` equivalent for `io.keys_down` (e.g., `imgui.is_key_pressed(imgui.Key.r, False)`).
- [ ] Search the codebase for any other instances of `io.keys_down` that need updating.
- [ ] Task: Apply Fixes
- [ ] Modify `src/gui_2.py` (around line 695) to replace `io.keys_down[ord('R')]` with the modern API call.
- [ ] Apply the same fix to any other locations found during the codebase search.
- [ ] Task: Verification
- [ ] Start the application locally and trigger the `Ctrl+Alt+R` shortcut to confirm it no longer crashes.
- [ ] Ensure general application stability.
- [ ] Task: Conductor - User Manual Verification 'Phase 1: Investigation and Implementation' (Protocol in workflow.md)
- [x] Task: Investigate ImGui API
- [x] Identify the correct `imgui-bundle` equivalent for `io.keys_down` (e.g., `imgui.is_key_pressed(imgui.Key.r, False)`).
- [x] Search the codebase for any other instances of `io.keys_down` that need updating.
- [x] Task: Apply Fixes
- [x] Modify `src/gui_2.py` (around line 695) to replace `io.keys_down[ord('R')]` with the modern API call.
- [x] Apply the same fix to any other locations found during the codebase search.
- [x] Task: Verification
- [x] Start the application locally and trigger the `Ctrl+Alt+R` shortcut to confirm it no longer crashes.
- [x] Ensure general application stability.
- [x] Task: Conductor - User Manual Verification 'Phase 1: Investigation and Implementation' (Protocol in workflow.md)
src/gui_2.py
+1 -1
View File
@@ -692,7 +692,7 @@ class App:
def _gui_func(self) -> None:
io = imgui.get_io()
if io.key_ctrl and io.key_alt and io.keys_down[ord('R')]:
if io.key_ctrl and io.key_alt and imgui.is_key_down(imgui.Key.r):
self._trigger_hot_reload()
render_custom_title_bar(self)
tests/test_hot_reload_integration.py
+3 -1
View File
@@ -124,8 +124,10 @@ class TestHotReloadTriggerIntegration:
mock_io = MagicMock()
mock_io.key_ctrl = True
mock_io.key_alt = True
mock_io.keys_down = {ord('R'): True}
mock_imgui.get_io.return_value = mock_io
mock_imgui.Key = MagicMock()
mock_imgui.Key.r = 'mock_r_key'
mock_imgui.is_key_down.side_effect = lambda k: k == 'mock_r_key'
mock_app = MagicMock()
mock_app._trigger_hot_reload = MagicMock(return_value=True)
mock_app.perf_profiling_enabled = False