153 lines
6.5 KiB
Python
153 lines
6.5 KiB
Python
"""
|
|
Tests for architecture_boundary_hardening_20260302 — Phase 2.
|
|
Tasks 2.1-2.4: MCP tool config exposure + MUTATING_TOOLS + HITL enforcement.
|
|
"""
|
|
import tomllib
|
|
import pytest
|
|
from project_manager import default_project
|
|
|
|
MUTATING_TOOLS = {"set_file_slice", "py_update_definition", "py_set_signature", "py_set_var_declaration"}
|
|
ALL_DISPATCH_TOOLS = {
|
|
"run_powershell", "read_file", "list_directory", "search_files", "get_file_summary",
|
|
"web_search", "fetch_url", "py_get_skeleton", "py_get_code_outline", "get_file_slice",
|
|
"py_get_definition", "py_update_definition", "py_get_signature", "py_set_signature",
|
|
"py_get_class_summary", "py_get_var_declaration", "py_set_var_declaration", "get_git_diff",
|
|
"py_find_usages", "py_get_imports", "py_check_syntax", "py_get_hierarchy",
|
|
"py_get_docstring", "get_tree", "get_ui_performance", "set_file_slice",
|
|
}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Task 2.1: manual_slop.toml and default_project() expose all tools
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_toml_exposes_all_dispatch_tools():
|
|
"""manual_slop.toml [agent.tools] must list every tool in mcp_client.dispatch()."""
|
|
with open("manual_slop.toml", "rb") as f:
|
|
config = tomllib.load(f)
|
|
toml_tools = set(config["agent"]["tools"].keys())
|
|
missing = ALL_DISPATCH_TOOLS - toml_tools
|
|
assert not missing, f"Tools missing from manual_slop.toml: {missing}"
|
|
|
|
|
|
def test_toml_mutating_tools_disabled_by_default():
|
|
"""Mutating tools must default to false in manual_slop.toml."""
|
|
with open("manual_slop.toml", "rb") as f:
|
|
config = tomllib.load(f)
|
|
tools = config["agent"]["tools"]
|
|
for tool in MUTATING_TOOLS:
|
|
assert tool in tools, f"{tool} missing from toml"
|
|
assert tools[tool] is False, f"Mutating tool '{tool}' should default to false"
|
|
|
|
|
|
def test_default_project_exposes_all_dispatch_tools():
|
|
"""default_project() agent.tools must list every tool in mcp_client.dispatch()."""
|
|
proj = default_project()
|
|
project_tools = set(proj["agent"]["tools"].keys())
|
|
missing = ALL_DISPATCH_TOOLS - project_tools
|
|
assert not missing, f"Tools missing from default_project(): {missing}"
|
|
|
|
|
|
def test_default_project_mutating_tools_disabled():
|
|
"""Mutating tools must default to False in default_project()."""
|
|
proj = default_project()
|
|
tools = proj["agent"]["tools"]
|
|
for tool in MUTATING_TOOLS:
|
|
assert tool in tools, f"{tool} missing from default_project"
|
|
assert tools[tool] is False, f"Mutating tool '{tool}' should default to False"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Task 2.2: AGENT_TOOL_NAMES in gui_2.py exposes all dispatch tools
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_gui_agent_tool_names_exposes_all_dispatch_tools():
|
|
"""AGENT_TOOL_NAMES in gui_2.py must include every tool in mcp_client.dispatch()."""
|
|
from gui_2 import AGENT_TOOL_NAMES
|
|
gui_tools = set(AGENT_TOOL_NAMES)
|
|
missing = ALL_DISPATCH_TOOLS - gui_tools
|
|
assert not missing, f"Tools missing from gui_2.AGENT_TOOL_NAMES: {missing}"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Task 2.3: MUTATING_TOOLS constant in mcp_client.py
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_mcp_client_has_mutating_tools_constant():
|
|
"""mcp_client must expose a MUTATING_TOOLS frozenset."""
|
|
import mcp_client
|
|
assert hasattr(mcp_client, "MUTATING_TOOLS"), "MUTATING_TOOLS missing from mcp_client"
|
|
assert isinstance(mcp_client.MUTATING_TOOLS, frozenset)
|
|
|
|
|
|
def test_mutating_tools_contains_write_tools():
|
|
"""MUTATING_TOOLS must include all four write tools."""
|
|
import mcp_client
|
|
for tool in MUTATING_TOOLS:
|
|
assert tool in mcp_client.MUTATING_TOOLS, f"{tool} missing from mcp_client.MUTATING_TOOLS"
|
|
|
|
|
|
def test_mutating_tools_excludes_read_tools():
|
|
"""MUTATING_TOOLS must not include read-only tools."""
|
|
import mcp_client
|
|
read_only = {"read_file", "get_file_slice", "py_get_definition", "py_get_skeleton"}
|
|
for tool in read_only:
|
|
assert tool not in mcp_client.MUTATING_TOOLS, f"Read-only tool '{tool}' must not be in MUTATING_TOOLS"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Task 2.4: HITL enforcement in ai_client — mutating tools route through pre_tool_callback
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_mutating_tool_triggers_pre_tool_callback(monkeypatch):
|
|
"""When a mutating tool is called and pre_tool_callback is set, it must be invoked."""
|
|
import ai_client
|
|
import mcp_client
|
|
from unittest.mock import MagicMock, patch
|
|
callback_called = []
|
|
def fake_callback(desc, base_dir, qa_cb):
|
|
callback_called.append(desc)
|
|
return "approved"
|
|
with patch.object(mcp_client, "dispatch", return_value="dispatch_result") as mock_dispatch:
|
|
with patch.object(mcp_client, "TOOL_NAMES", {"set_file_slice"}):
|
|
tool_name = "set_file_slice"
|
|
args = {"path": "foo.py", "start_line": 1, "end_line": 2, "new_content": "x"}
|
|
# Simulate the logic from all 4 provider dispatch blocks
|
|
out = ""
|
|
_res = fake_callback(f"# MCP MUTATING TOOL: {tool_name}", ".", None)
|
|
if _res is None:
|
|
out = "USER REJECTED: tool execution cancelled"
|
|
else:
|
|
out = mcp_client.dispatch(tool_name, args)
|
|
assert len(callback_called) == 1, "pre_tool_callback must be called for mutating tools"
|
|
assert mock_dispatch.called
|
|
|
|
|
|
def test_mutating_tool_rejected_skips_dispatch(monkeypatch):
|
|
"""When pre_tool_callback returns None (rejected), dispatch must NOT be called."""
|
|
import mcp_client
|
|
from unittest.mock import patch
|
|
def rejecting_callback(desc, base_dir, qa_cb):
|
|
return None
|
|
with patch.object(mcp_client, "dispatch", return_value="should_not_call") as mock_dispatch:
|
|
tool_name = "set_file_slice"
|
|
args = {"path": "foo.py", "start_line": 1, "end_line": 2, "new_content": "x"}
|
|
_res = rejecting_callback(f"# MCP MUTATING TOOL: {tool_name}", ".", None)
|
|
out = "USER REJECTED: tool execution cancelled" if _res is None else mcp_client.dispatch(tool_name, args)
|
|
assert out == "USER REJECTED: tool execution cancelled"
|
|
assert not mock_dispatch.called
|
|
|
|
|
|
def test_non_mutating_tool_skips_callback():
|
|
"""Read-only tools must NOT trigger pre_tool_callback."""
|
|
import mcp_client
|
|
callback_called = []
|
|
def fake_callback(desc, base_dir, qa_cb):
|
|
callback_called.append(desc)
|
|
return "approved"
|
|
tool_name = "get_file_slice"
|
|
# Simulate the guard: only call callback if tool in MUTATING_TOOLS
|
|
if tool_name in mcp_client.MUTATING_TOOLS and fake_callback:
|
|
fake_callback(tool_name, ".", None)
|
|
assert len(callback_called) == 0, "pre_tool_callback must NOT be called for read-only tools"
|