Compare commits
157 Commits
1f760f2381
...
master
| Author | SHA1 | Date | |
|---|---|---|---|
| 80eaf740da | |||
| 5446a2407c | |||
| fde0f29e72 | |||
| bfbcfcc2af | |||
| 502a47fd92 | |||
| 5f0168c4f2 | |||
| e802c6675f | |||
| 5efd775299 | |||
| 8f1a77974c | |||
| 429bb9242c | |||
| 49a1c30a85 | |||
| 931b4cf362 | |||
| 0b49b3ad39 | |||
| c84a6d7dfc | |||
| 7f418faa7c | |||
| 9e20123079 | |||
| 59e14533f6 | |||
| c6dd055da8 | |||
| 605b2ac024 | |||
| d613e5efa7 | |||
| d82d919599 | |||
| b1d612e19f | |||
| 1ba321668b | |||
| 4bcc9dda06 | |||
| 08958ed8d4 | |||
| a5afe7bd14 | |||
| b8ec984836 | |||
| e34a2e6355 | |||
| 74737ac9c7 | |||
| 1d18150570 | |||
| ef942bb2a2 | |||
| b7a0c4fa7e | |||
| 27b98ffe1e | |||
| a6f7f82f02 | |||
| bbe0209403 | |||
| 3489b3c4b8 | |||
| 91949575a7 | |||
| b78682dfff | |||
| c3e0cb3243 | |||
| 8e02c1ecec | |||
| f9364e173e | |||
| 1b3fc5ba2f | |||
| 1e4eaf25d8 | |||
| 72bb2cec68 | |||
| 4c056fec03 | |||
| de5b152c1e | |||
| 7063bead12 | |||
| 07b0f83794 | |||
| c766954c52 | |||
| 20f5c34c4b | |||
| fbee82e6d7 | |||
| 235b369d15 | |||
| d7083fc73f | |||
| 792352fb5b | |||
| b49be2f059 | |||
| 2626516cb9 | |||
| b9edd55aa5 | |||
| a65f3375ad | |||
| 87c9953b2e | |||
| 66338b3ba0 | |||
| b44c0f42cd | |||
| deb1a2b423 | |||
| 0515be39cc | |||
| da7f477723 | |||
| 957af2f587 | |||
| 7f9002b900 | |||
| 711750f1c3 | |||
| 5e6a38a790 | |||
| c11df55a25 | |||
| 28cc901c0a | |||
| 790904a094 | |||
| 8beb186aff | |||
| 7bdba1c9b9 | |||
| 2ffb2b2e1f | |||
| 83911ff1c5 | |||
| d34c35941f | |||
| d9a06fd2fe | |||
| b70552f1d7 | |||
| a65dff4b6d | |||
| 6621362c37 | |||
| 2f53f685a6 | |||
| 87efbd1a12 | |||
| 99d837dc95 | |||
| f07b14aa66 | |||
| 4c2cfda3d1 | |||
| 3722570891 | |||
| c2930ebea1 | |||
| d2521d6502 | |||
| a98c1ff4be | |||
| 72c2760a13 | |||
| 422b2e6518 | |||
| 93cd4a0050 | |||
| 328063f00f | |||
| 177787e5f6 | |||
| 3ba4cac4a4 | |||
| b1ab18f8e1 | |||
| d7ac7bac0a | |||
| 7f7e456351 | |||
| 896be1eae2 | |||
| 39348745d3 | |||
| ca65f29513 | |||
| 3984132700 | |||
| 07a4af2f94 | |||
| 98cf0290e6 | |||
| f5ee94a3ee | |||
| e20f8a1d05 | |||
| 4d32d41cd1 | |||
| 63d1b04479 | |||
| 3c9d8da292 | |||
| 245653ce62 | |||
| 3d89d0e026 | |||
| 86973e2401 | |||
| 925a7a9fcf | |||
| 203fcd5b5c | |||
| 3cb7d4fd6d | |||
| 570527a955 | |||
| 0c3a2061e7 | |||
| ce99c18cbd | |||
| 048a07a049 | |||
| 11a04f4147 | |||
| 5259e2fc91 | |||
| c6d0bc8c8d | |||
| 265839a55b | |||
| 2ff5a8beee | |||
| 8b514e0d4d | |||
| 094a6c3c22 | |||
| 97b5bd953d | |||
| d45accbc90 | |||
| d74f629f47 | |||
| 597e6b51e2 | |||
| da011fbc57 | |||
| 5f7909121d | |||
| beae82860a | |||
| 3f83063197 | |||
| a22603d136 | |||
| c56c8db6db | |||
| 035c74ed36 | |||
| e9d9cdeb28 | |||
| 95f8a6d120 | |||
| 813e58ce30 | |||
| 7ea833e2d3 | |||
| 0c2df6c188 | |||
| c6f9dc886f | |||
| 953e9e040c | |||
| f392aa3ef5 | |||
| 5e02ea34df | |||
| a0a9d00310 | |||
| 84396dc13a | |||
| f655547184 | |||
| 6ab359deda | |||
| a856d73f95 | |||
| b5398ec5a8 | |||
| 91d7e2055f | |||
| aaed011d9e | |||
| fcff00f750 | |||
| d71d82bafb | |||
| 7198c8717a |
@@ -22,7 +22,7 @@ Bootstrap a Claude Code session with full conductor context. Run this at session
|
||||
- Identify the track with `[~]` in-progress tasks
|
||||
|
||||
3. **Check Session Context:**
|
||||
- Read `TASKS.md` if it exists — check for IN_PROGRESS or BLOCKED tasks
|
||||
- Read `conductor/tracks.md` if it exists — check for IN_PROGRESS or BLOCKED tasks
|
||||
- Read last 3 entries in `JOURNAL.md` for recent activity
|
||||
- Run `git log --oneline -10` for recent commits
|
||||
|
||||
|
||||
@@ -20,6 +20,7 @@ To ensure proper environment handling and logging, you MUST NOT call the `gemini
|
||||
- `docs/guide_tools.md`: MCP Bridge 3-layer security model, full 26-tool inventory with params, Hook API GET/POST endpoints with request/response formats, ApiHookClient method reference
|
||||
- `docs/guide_mma.md`: Ticket/Track/WorkerContext data structures, DAG engine (cycle detection, topological sort), ConductorEngine execution loop, Tier 2 ticket generation, Tier 3 worker lifecycle with context amnesia
|
||||
- `docs/guide_simulations.md`: `live_gui` fixture lifecycle, Puppeteer pattern, mock provider JSON-L protocol, visual verification patterns
|
||||
- `docs/guide_meta_boundary.md`: Clarification of ai agent tools making the application vs the application itself.
|
||||
|
||||
### The Surgical Spec Protocol (MANDATORY for track creation)
|
||||
|
||||
@@ -126,3 +127,9 @@ When your current role requires capabilities from another tier, use `activate_sk
|
||||
- When managing complex, multi-file Track implementations.
|
||||
- When creating or refining conductor tracks (MUST follow Surgical Spec Protocol).
|
||||
</triggers>
|
||||
|
||||
## Anti-Patterns (Avoid)
|
||||
|
||||
- DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX.
|
||||
- DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX.
|
||||
- DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY.
|
||||
|
||||
@@ -21,6 +21,7 @@ When planning tracks that touch core systems, consult:
|
||||
- `docs/guide_tools.md`: MCP Bridge, Hook API endpoints, ApiHookClient methods
|
||||
- `docs/guide_mma.md`: Ticket/Track structures, DAG engine, ConductorEngine, worker lifecycle
|
||||
- `docs/guide_simulations.md`: live_gui fixture, Puppeteer pattern, mock provider
|
||||
- `docs/guide_meta_boundary.md`: Clarification of ai agent tools making the application vs the application itself.
|
||||
|
||||
## Responsibilities
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
description: Fast, read-only agent for exploring the codebase structure
|
||||
mode: subagent
|
||||
model: zai/glm-4-flash
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.0
|
||||
steps: 8
|
||||
permission:
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
description: General-purpose agent for researching complex questions and executing multi-step tasks
|
||||
mode: subagent
|
||||
model: zai/glm-5
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.2
|
||||
steps: 15
|
||||
---
|
||||
|
||||
@@ -1,11 +1,11 @@
|
||||
---
|
||||
description: Tier 1 Orchestrator for product alignment, high-level planning, and track initialization
|
||||
mode: primary
|
||||
model: zai/glm-5
|
||||
temperature: 0.1
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.4
|
||||
steps: 50
|
||||
permission:
|
||||
edit: deny
|
||||
edit: ask
|
||||
bash:
|
||||
"*": ask
|
||||
"git status*": allow
|
||||
@@ -22,6 +22,7 @@ ONLY output the requested text. No pleasantries.
|
||||
You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
|
||||
### Read-Only MCP Tools (USE THESE)
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `read` | `manual-slop_read_file` |
|
||||
@@ -35,7 +36,18 @@ You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
| - | `manual-slop_get_git_diff` (file changes) |
|
||||
| - | `manual-slop_get_tree` (directory structure) |
|
||||
|
||||
### Edit MCP Tools (USE THESE)
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `edit` | `manual-slop_edit_file` (find/replace, preserves indentation) YOU MUST USE old_string parameter IT IS NOT oldString |
|
||||
| `edit` | `manual-slop_py_update_definition` (replace function/class) |
|
||||
| `edit` | `manual-slop_set_file_slice` (replace line range) |
|
||||
| `edit` | `manual-slop_py_set_signature` (replace signature only) |
|
||||
| `edit` | `manual-slop_py_set_var_declaration` (replace variable) |
|
||||
|
||||
### Shell Commands
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `bash` | `manual-slop_run_powershell` |
|
||||
@@ -43,26 +55,36 @@ You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
## Session Start Checklist (MANDATORY)
|
||||
|
||||
Before ANY other action:
|
||||
|
||||
1. [ ] Read `conductor/workflow.md`
|
||||
2. [ ] Read `conductor/tech-stack.md`
|
||||
3. [ ] Read `conductor/product.md`, `conductor/product-guidelines.md`
|
||||
4. [ ] Read relevant `docs/guide_*.md` for current task domain
|
||||
5. [ ] Check `TASKS.md` for active tracks
|
||||
5. [ ] Check `conductor/tracks.md` for active tracks
|
||||
6. [ ] Announce: "Context loaded, proceeding to [task]"
|
||||
|
||||
**BLOCK PROGRESS** until all checklist items are confirmed.
|
||||
|
||||
## Primary Context Documents
|
||||
Read at session start: `conductor/product.md`, `conductor/product-guidelines.md`
|
||||
|
||||
Read at session start:
|
||||
|
||||
- All immediate files in ./conductor, a listing of all direcotires within ./conductor/tracks, ./conductor/archive.
|
||||
- All docs in ./docs
|
||||
- AST Skeleton summaries of: ./src, ./simulation, ./tests, ./scripts python files.
|
||||
|
||||
## Architecture Fallback
|
||||
|
||||
When planning tracks that touch core systems, consult the deep-dive docs:
|
||||
|
||||
- `docs/guide_architecture.md`: Thread domains, event system, AI client, HITL mechanism
|
||||
- `docs/guide_tools.md`: MCP Bridge security, 26-tool inventory, Hook API endpoints
|
||||
- `docs/guide_mma.md`: Ticket/Track data structures, DAG engine, ConductorEngine
|
||||
- `docs/guide_simulations.md`: live_gui fixture, Puppeteer pattern, mock provider
|
||||
- `docs/guide_meta_boundary.md`: Clarification of ai agent tools making the application vs the application itself.
|
||||
|
||||
## Responsibilities
|
||||
|
||||
- Maintain alignment with the product guidelines and definition
|
||||
- Define track boundaries and initialize new tracks (`/conductor-new-track`)
|
||||
- Set up the project environment (`/conductor-setup`)
|
||||
@@ -71,6 +93,7 @@ When planning tracks that touch core systems, consult the deep-dive docs:
|
||||
## The Surgical Methodology
|
||||
|
||||
### 1. MANDATORY: Audit Before Specifying
|
||||
|
||||
NEVER write a spec without first reading actual code using MCP tools.
|
||||
Use `manual-slop_py_get_code_outline`, `manual-slop_py_get_definition`,
|
||||
`manual-slop_py_find_usages`, and `manual-slop_get_git_diff` to build a map.
|
||||
@@ -78,22 +101,28 @@ Document existing implementations with file:line references in a
|
||||
"Current State Audit" section in the spec.
|
||||
|
||||
### 2. Identify Gaps, Not Features
|
||||
|
||||
Frame requirements around what's MISSING relative to what exists.
|
||||
|
||||
### 3. Write Worker-Ready Tasks
|
||||
|
||||
Each plan task must be executable by a Tier 3 worker:
|
||||
|
||||
- **WHERE**: Exact file and line range (`gui_2.py:2700-2701`)
|
||||
- **WHAT**: The specific change
|
||||
- **HOW**: Which API calls or patterns
|
||||
- **SAFETY**: Thread-safety constraints
|
||||
|
||||
### 4. For Bug Fix Tracks: Root Cause Analysis
|
||||
|
||||
Read the code, trace the data flow, list specific root cause candidates.
|
||||
|
||||
### 5. Reference Architecture Docs
|
||||
|
||||
Link to relevant `docs/guide_*.md` sections in every spec.
|
||||
|
||||
## Spec Template (REQUIRED sections)
|
||||
|
||||
```
|
||||
# Track Specification: {Title}
|
||||
|
||||
@@ -109,6 +138,7 @@ Link to relevant `docs/guide_*.md` sections in every spec.
|
||||
```
|
||||
|
||||
## Plan Template (REQUIRED format)
|
||||
|
||||
```
|
||||
## Phase N: {Name}
|
||||
Focus: {One-sentence scope}
|
||||
@@ -120,6 +150,18 @@ Focus: {One-sentence scope}
|
||||
```
|
||||
|
||||
## Limitations
|
||||
|
||||
- READ-ONLY: Do NOT write code or edit files (except track spec/plan/metadata)
|
||||
- Do NOT execute tracks or implement features
|
||||
- Keep context strictly focused on product definitions and strategy
|
||||
|
||||
## Anti-Patterns (Avoid)
|
||||
|
||||
- Do NOT implement code directly - delegate to Tier 3 Workers
|
||||
- Do NOT skip TDD phases
|
||||
- Do NOT batch commits - commit per-task
|
||||
- Do NOT skip phase verification
|
||||
- Do NOT use native `edit` tool - use MCP tools
|
||||
- DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX.
|
||||
- DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX.
|
||||
- DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY.
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
description: Tier 2 Tech Lead for architectural design and track execution with persistent memory
|
||||
mode: primary
|
||||
model: zai/glm-5
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.2
|
||||
steps: 100
|
||||
permission:
|
||||
@@ -18,6 +18,7 @@ ONLY output the requested text. No pleasantries.
|
||||
You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
|
||||
### Research MCP Tools (USE THESE)
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `read` | `manual-slop_read_file` |
|
||||
@@ -32,15 +33,17 @@ You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
| - | `manual-slop_get_tree` (directory structure) |
|
||||
|
||||
### Edit MCP Tools (USE THESE)
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `edit` | `manual-slop_edit_file` (find/replace, preserves indentation) |
|
||||
| `edit` | `manual-slop_edit_file` (find/replace, preserves indentation) YOU MUST USE old_string parameter IT IS NOT oldString |
|
||||
| `edit` | `manual-slop_py_update_definition` (replace function/class) |
|
||||
| `edit` | `manual-slop_set_file_slice` (replace line range) |
|
||||
| `edit` | `manual-slop_py_set_signature` (replace signature only) |
|
||||
| `edit` | `manual-slop_py_set_var_declaration` (replace variable) |
|
||||
|
||||
### Shell Commands
|
||||
|
||||
| Native Tool | MCP Tool |
|
||||
|-------------|----------|
|
||||
| `bash` | `manual-slop_run_powershell` |
|
||||
@@ -48,45 +51,50 @@ You MUST use Manual Slop's MCP tools. Native OpenCode tools are unreliable.
|
||||
## Session Start Checklist (MANDATORY)
|
||||
|
||||
Before ANY other action:
|
||||
|
||||
1. [ ] Read `conductor/workflow.md`
|
||||
2. [ ] Read `conductor/tech-stack.md`
|
||||
3. [ ] Read `conductor/product.md`
|
||||
4. [ ] Read relevant `docs/guide_*.md` for current task domain
|
||||
5. [ ] Check `TASKS.md` for active tracks
|
||||
6. [ ] Announce: "Context loaded, proceeding to [task]"
|
||||
4. [ ] Read `conductor/product-guidelines.md`
|
||||
5. [ ] Read relevant `docs/guide_*.md` for current task domain
|
||||
6. [ ] Check `conductor/tracks.md` for active tracks
|
||||
7. [ ] Announce: "Context loaded, proceeding to [task]"
|
||||
|
||||
**BLOCK PROGRESS** until all checklist items are confirmed.
|
||||
|
||||
## Tool Restrictions (TIER 2)
|
||||
|
||||
### ALLOWED Tools (Read-Only Research)
|
||||
|
||||
- `manual-slop_read_file` (for files <50 lines only)
|
||||
- `manual-slop_py_get_skeleton`, `manual-slop_py_get_code_outline`, `manual-slop_get_file_summary`
|
||||
- `manual-slop_py_find_usages`, `manual-slop_search_files`
|
||||
- `manual-slop_run_powershell` (for git status, pytest --collect-only)
|
||||
|
||||
### FORBIDDEN Actions (Delegate to Tier 3)
|
||||
|
||||
- **NEVER** use native `edit` tool on .py files - destroys indentation
|
||||
- **NEVER** write implementation code directly - delegate to Tier 3 Worker
|
||||
- **NEVER** skip TDD Red-Green cycle
|
||||
|
||||
### Required Pattern
|
||||
|
||||
1. Research with skeleton tools
|
||||
2. Draft surgical prompt with WHERE/WHAT/HOW/SAFETY
|
||||
3. Delegate to Tier 3 via Task tool
|
||||
4. Verify result
|
||||
|
||||
## Primary Context Documents
|
||||
Read at session start: `conductor/product.md`, `conductor/workflow.md`, `conductor/tech-stack.md`
|
||||
|
||||
## Architecture Fallback
|
||||
|
||||
When implementing tracks that touch core systems, consult the deep-dive docs:
|
||||
|
||||
- `docs/guide_architecture.md`: Thread domains, event system, AI client, HITL mechanism
|
||||
- `docs/guide_tools.md`: MCP Bridge security, 26-tool inventory, Hook API endpoints
|
||||
- `docs/guide_mma.md`: Ticket/Track data structures, DAG engine, ConductorEngine
|
||||
- `docs/guide_simulations.md`: live_gui fixture, Puppeteer pattern, mock provider
|
||||
|
||||
## Responsibilities
|
||||
|
||||
- Convert track specs into implementation plans with surgical tasks
|
||||
- Execute track implementation following TDD (Red -> Green -> Refactor)
|
||||
- Delegate code implementation to Tier 3 Workers via Task tool
|
||||
@@ -97,28 +105,35 @@ When implementing tracks that touch core systems, consult the deep-dive docs:
|
||||
## TDD Protocol (MANDATORY)
|
||||
|
||||
### 1. High-Signal Research Phase
|
||||
|
||||
Before implementing:
|
||||
|
||||
- Use `manual-slop_py_get_code_outline`, `manual-slop_py_get_skeleton` to map file relations
|
||||
- Use `manual-slop_get_git_diff` for recently modified code
|
||||
- Audit state: Check `__init__` methods for existing/duplicate state variables
|
||||
|
||||
### 2. Red Phase: Write Failing Tests
|
||||
|
||||
- Pre-delegation checkpoint: Stage current progress (`git add .`)
|
||||
- Zero-assertion ban: Tests MUST have meaningful assertions
|
||||
- Delegate test creation to Tier 3 Worker via Task tool
|
||||
- Run tests and confirm they FAIL as expected
|
||||
|
||||
### 3. Green Phase: Implement to Pass
|
||||
|
||||
- Pre-delegation checkpoint: Stage current progress
|
||||
- Delegate implementation to Tier 3 Worker via Task tool
|
||||
- Run tests and confirm they PASS
|
||||
|
||||
### 4. Refactor Phase (Optional)
|
||||
|
||||
- With passing tests, refactor for clarity and performance
|
||||
- Re-run tests to ensure they still pass
|
||||
|
||||
### 5. Commit Protocol (ATOMIC PER-TASK)
|
||||
|
||||
After completing each task:
|
||||
|
||||
1. Stage changes: `git add .`
|
||||
2. Commit with clear message: `feat(scope): description`
|
||||
3. Get commit hash: `git log -1 --format="%H"`
|
||||
@@ -131,12 +146,15 @@ After completing each task:
|
||||
OpenCode uses the Task tool for subagent delegation. Always provide surgical prompts with WHERE/WHAT/HOW/SAFETY structure.
|
||||
|
||||
### Tier 3 Worker (Implementation)
|
||||
|
||||
Invoke via Task tool:
|
||||
|
||||
- `subagent_type`: "tier3-worker"
|
||||
- `description`: Brief task name
|
||||
- `prompt`: Surgical prompt with WHERE/WHAT/HOW/SAFETY structure
|
||||
|
||||
Example Task tool invocation:
|
||||
|
||||
```
|
||||
description: "Write tests for cost estimation"
|
||||
prompt: |
|
||||
@@ -151,13 +169,17 @@ prompt: |
|
||||
```
|
||||
|
||||
### Tier 4 QA (Error Analysis)
|
||||
|
||||
Invoke via Task tool:
|
||||
|
||||
- `subagent_type`: "tier4-qa"
|
||||
- `description`: "Analyze test failure"
|
||||
- `prompt`: Error output + explicit instruction "DO NOT fix - provide root cause analysis only"
|
||||
|
||||
## Phase Completion Protocol
|
||||
|
||||
When all tasks in a phase are complete:
|
||||
|
||||
1. Run `/conductor-verify` to execute automated verification
|
||||
2. Present results to user and await confirmation
|
||||
3. Create checkpoint commit: `conductor(checkpoint): Phase N complete`
|
||||
@@ -165,8 +187,12 @@ When all tasks in a phase are complete:
|
||||
5. Update plan.md with checkpoint SHA
|
||||
|
||||
## Anti-Patterns (Avoid)
|
||||
|
||||
- Do NOT implement code directly - delegate to Tier 3 Workers
|
||||
- Do NOT skip TDD phases
|
||||
- Do NOT batch commits - commit per-task
|
||||
- Do NOT skip phase verification
|
||||
- Do NOT use native `edit` tool - use MCP tools
|
||||
- DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX.
|
||||
- DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX.
|
||||
- DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY.
|
||||
|
||||
@@ -1,9 +1,9 @@
|
||||
---
|
||||
description: Stateless Tier 3 Worker for surgical code implementation and TDD
|
||||
mode: subagent
|
||||
model: zai/glm-4-flash
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.1
|
||||
steps: 10
|
||||
steps: 20
|
||||
permission:
|
||||
edit: allow
|
||||
bash: allow
|
||||
@@ -107,3 +107,14 @@ If you cannot complete the task:
|
||||
2. Explain exactly why you cannot proceed
|
||||
3. List what information or changes would unblock you
|
||||
4. Do NOT attempt partial implementations that break the build
|
||||
|
||||
## Anti-Patterns (Avoid)
|
||||
|
||||
- Do NOT implement code directly - delegate to Tier 3 Workers
|
||||
- Do NOT skip TDD phases
|
||||
- Do NOT batch commits - commit per-task
|
||||
- Do NOT skip phase verification
|
||||
- Do NOT use native `edit` tool - use MCP tools
|
||||
- DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX.
|
||||
- DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX.
|
||||
- DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY.
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
description: Stateless Tier 4 QA Agent for error analysis and diagnostics
|
||||
mode: subagent
|
||||
model: zai/glm-4-flash
|
||||
model: MiniMax-M2.5
|
||||
temperature: 0.0
|
||||
steps: 5
|
||||
permission:
|
||||
@@ -101,3 +101,13 @@ If you cannot analyze the error:
|
||||
1. Start your response with `CANNOT ANALYZE:`
|
||||
2. Explain what information is missing
|
||||
3. List what would be needed to complete the analysis
|
||||
|
||||
## Anti-Patterns (Avoid)
|
||||
|
||||
- Do NOT implement code directly - delegate to Tier 3 Workers
|
||||
- Do NOT skip TDD phases
|
||||
- Do NOT batch commits - commit per-task
|
||||
- Do NOT skip phase verification
|
||||
- DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX.
|
||||
- DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX.
|
||||
- DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY.
|
||||
|
||||
@@ -24,7 +24,7 @@ Bootstrap the session with full conductor context. Run this at session start.
|
||||
- Identify the track with `[~]` in-progress tasks
|
||||
|
||||
3. **Check Session Context:**
|
||||
- Read `TASKS.md` if it exists — check for IN_PROGRESS or BLOCKED tasks
|
||||
- Read `conductor/tracks.md` if it exists — check for IN_PROGRESS or BLOCKED tasks
|
||||
- Read last 3 entries in `JOURNAL.md` for recent activity
|
||||
- Run `git log --oneline -10` for recent commits
|
||||
|
||||
|
||||
@@ -20,7 +20,7 @@ Display comprehensive status of the conductor system.
|
||||
- Read `plan.md` for task progress
|
||||
- Count completed vs total tasks
|
||||
|
||||
3. **Check TASKS.md:**
|
||||
3. **Check conductor/tracks.md:**
|
||||
- List IN_PROGRESS tasks
|
||||
- List BLOCKED tasks
|
||||
- List pending tasks by priority
|
||||
@@ -38,7 +38,7 @@ Display comprehensive status of the conductor system.
|
||||
|-------|--------|----------|--------------|
|
||||
| ... | ... | N/M tasks | ... |
|
||||
|
||||
### Task Registry (TASKS.md)
|
||||
### Task Registry (conductor/tracks.md)
|
||||
**In Progress:**
|
||||
- [ ] Task description
|
||||
|
||||
|
||||
27
AGENTS.md
27
AGENTS.md
@@ -1,5 +1,9 @@
|
||||
# Manual Slop - OpenCode Configuration
|
||||
|
||||
## MCP TOOL PARAMETERS - CRITICAL
|
||||
- **ALWAYS use snake_case**: `old_string`, `new_string`, `replace_all`
|
||||
- **NEVER use camelCase**: `oldString`, `newString`, `replaceAll`
|
||||
|
||||
## Project Overview
|
||||
|
||||
**Manual Slop** is a local GUI application designed as an experimental, "manual" AI coding assistant. It allows users to curate and send context (files, screenshots, and discussion history) to AI APIs (Gemini and Anthropic). The AI can then execute PowerShell scripts within the project directory to modify files, requiring explicit user confirmation before execution.
|
||||
@@ -41,7 +45,8 @@
|
||||
## Session Startup Checklist
|
||||
|
||||
At the start of each session:
|
||||
1. **Check TASKS.md** - look for IN_PROGRESS or BLOCKED tracks
|
||||
|
||||
1. **Check ./condcutor/tracks.md** - look for IN_PROGRESS or BLOCKED tracks
|
||||
2. **Review recent JOURNAL.md entries** - scan last 2-3 entries for context
|
||||
3. **Run `/conductor-setup`** - load full context
|
||||
4. **Run `/conductor-status`** - get overview
|
||||
@@ -49,6 +54,7 @@ At the start of each session:
|
||||
## Conductor System
|
||||
|
||||
The project uses a spec-driven track system in `conductor/`:
|
||||
|
||||
- **Tracks**: `conductor/tracks/{name}_{YYYYMMDD}/` - spec.md, plan.md, metadata.json
|
||||
- **Workflow**: `conductor/workflow.md` - full task lifecycle and TDD protocol
|
||||
- **Tech Stack**: `conductor/tech-stack.md` - technology constraints
|
||||
@@ -66,15 +72,17 @@ Tier 4: QA - stateless error analysis, no fixes
|
||||
## Architecture Fallback
|
||||
|
||||
When uncertain about threading, event flow, data structures, or module interactions, consult:
|
||||
|
||||
- **docs/guide_architecture.md**: Thread domains, event system, AI client, HITL mechanism
|
||||
- **docs/guide_tools.md**: MCP Bridge security, 26-tool inventory, Hook API endpoints
|
||||
- **docs/guide_mma.md**: Ticket/Track data structures, DAG engine, ConductorEngine
|
||||
- **docs/guide_simulations.md**: live_gui fixture, Puppeteer pattern, verification
|
||||
- **docs/guide_meta_boundary.md**: Clarification of ai agent tools making the application vs the application itself.
|
||||
|
||||
## Development Workflow
|
||||
|
||||
1. Run `/conductor-setup` to load session context
|
||||
2. Pick active track from `TASKS.md` or `/conductor-status`
|
||||
2. Pick active track from `./condcutor/tracks.md` or `/conductor-status`
|
||||
3. Run `/conductor-implement` to resume track execution
|
||||
4. Follow TDD: Red (failing tests) -> Green (pass) -> Refactor
|
||||
5. Delegate implementation to Tier 3 Workers, errors to Tier 4 QA
|
||||
@@ -94,6 +102,7 @@ When uncertain about threading, event flow, data structures, or module interacti
|
||||
- **IMPORTANT**: DO NOT ADD ***ANY*** COMMENTS unless asked
|
||||
- Use 1-space indentation for Python code
|
||||
- Use type hints where appropriate
|
||||
|
||||
## Code Style
|
||||
|
||||
- **IMPORTANT**: DO NOT ADD ***ANY*** COMMENTS unless asked
|
||||
@@ -108,19 +117,7 @@ The native `Edit` tool DESTROYS 1-space indentation and converts to 4-space.
|
||||
**NEVER use native `edit` tool on Python files.**
|
||||
|
||||
Instead, use Manual Slop MCP tools:
|
||||
|
||||
- `manual-slop_py_update_definition` - Replace function/class
|
||||
- `manual-slop_set_file_slice` - Replace line range
|
||||
- `manual-slop_py_set_signature` - Replace signature only
|
||||
|
||||
Or use Python subprocess with `newline=''` to preserve line endings:
|
||||
```python
|
||||
python -c "
|
||||
with open('file.py', 'r', encoding='utf-8', newline='') as f:
|
||||
content = f.read()
|
||||
content = content.replace(old, new)
|
||||
with open('file.py', 'w', encoding='utf-8', newline='') as f:
|
||||
f.write(content)
|
||||
"
|
||||
```
|
||||
|
||||
## Quality Gates
|
||||
|
||||
@@ -3,6 +3,10 @@
|
||||
|
||||
This file provides guidance to Claude Code when working with this repository.
|
||||
|
||||
## MCP TOOL PARAMETERS - CRITICAL
|
||||
- **ALWAYS use snake_case**: `old_string`, `new_string`, `replace_all`
|
||||
- **NEVER use camelCase**: `oldString`, `newString`, `replaceAll`
|
||||
|
||||
## Critical Context (Read First)
|
||||
- **Tech Stack**: Python 3.11+, Dear PyGui / ImGui, FastAPI, Uvicorn
|
||||
- **Main File**: `gui_2.py` (primary GUI), `ai_client.py` (multi-provider LLM abstraction)
|
||||
@@ -80,7 +84,7 @@ uv run python scripts\claude_mma_exec.py --role tier4-qa "Error analysis prompt"
|
||||
|
||||
## Development Workflow
|
||||
1. Run `/conductor-setup` to load session context
|
||||
2. Pick active track from `TASKS.md` or `/conductor-status`
|
||||
2. Pick active track from `conductor/tracks.md` or `/conductor-status`
|
||||
3. Run `/conductor-implement` to resume track execution
|
||||
4. Follow TDD: Red (failing tests) → Green (pass) → Refactor
|
||||
5. Delegate implementation to Tier 3 Workers, errors to Tier 4 QA
|
||||
@@ -112,7 +116,7 @@ Update JOURNAL.md after:
|
||||
Format: What/Why/How/Issues/Result structure
|
||||
|
||||
## Task Management Integration
|
||||
- **TASKS.md**: Quick-read pointer to active conductor tracks
|
||||
- **conductor/tracks.md**: Quick-read pointer to active conductor tracks
|
||||
- **conductor/tracks/*/plan.md**: Detailed task state (source of truth)
|
||||
- **JOURNAL.md**: Completed work history with `|TASK:ID|` tags
|
||||
- **ERRORS.md**: P0/P1 error tracking
|
||||
|
||||
511
CONDUCTOR.md
511
CONDUCTOR.md
@@ -1,511 +0,0 @@
|
||||
# CONDUCTOR.md
|
||||
<!-- Generated by Claude Conductor v2.0.0 -->
|
||||
|
||||
> _Read me first. Every other doc is linked below._
|
||||
|
||||
## Critical Context (Read First)
|
||||
- **Tech Stack**: [List core technologies]
|
||||
- **Main File**: [Primary code file and line count]
|
||||
- **Core Mechanic**: [One-line description]
|
||||
- **Key Integration**: [Important external services]
|
||||
- **Platform Support**: [Deployment targets]
|
||||
- **DO NOT**: [Critical things to avoid]
|
||||
|
||||
## Table of Contents
|
||||
1. [Architecture](ARCHITECTURE.md) - Tech stack, folder structure, infrastructure
|
||||
2. [Design Tokens](DESIGN.md) - Colors, typography, visual system
|
||||
3. [UI/UX Patterns](UIUX.md) - Components, interactions, accessibility
|
||||
4. [Runtime Config](CONFIG.md) - Environment variables, feature flags
|
||||
5. [Data Model](DATA_MODEL.md) - Database schema, entities, relationships
|
||||
6. [API Contracts](API.md) - Endpoints, request/response formats, auth
|
||||
7. [Build & Release](BUILD.md) - Build process, deployment, CI/CD
|
||||
8. [Testing Guide](TEST.md) - Test strategies, E2E scenarios, coverage
|
||||
9. [Operational Playbooks](PLAYBOOKS/DEPLOY.md) - Deployment, rollback, monitoring
|
||||
10. [Contributing](CONTRIBUTING.md) - Code style, PR process, conventions
|
||||
11. [Error Ledger](ERRORS.md) - Critical P0/P1 error tracking
|
||||
12. [Task Management](TASKS.md) - Active tasks, phase tracking, context preservation
|
||||
|
||||
## Quick Reference
|
||||
**Main Constants**: `[file:lines]` - Description
|
||||
**Core Class**: `[file:lines]` - Description
|
||||
**Key Function**: `[file:lines]` - Description
|
||||
[Include 10-15 most accessed code locations]
|
||||
|
||||
## Current State
|
||||
- [x] Feature complete
|
||||
- [ ] Feature in progress
|
||||
- [ ] Feature planned
|
||||
[Track active work]
|
||||
|
||||
## Development Workflow
|
||||
[5-6 steps for common workflow]
|
||||
|
||||
## Task Templates
|
||||
### 1. [Common Task Name]
|
||||
1. Step with file:line reference
|
||||
2. Step with specific action
|
||||
3. Test step
|
||||
4. Documentation update
|
||||
|
||||
[Include 3-5 templates]
|
||||
|
||||
## Anti-Patterns (Avoid These)
|
||||
❌ **Don't [action]** - [Reason]
|
||||
[List 5-6 critical mistakes]
|
||||
|
||||
## Version History
|
||||
- **v1.0.0** - Initial release
|
||||
- **v1.1.0** - Feature added (see JOURNAL.md YYYY-MM-DD)
|
||||
[Link major versions to journal entries]
|
||||
|
||||
## Continuous Engineering Journal <!-- do not remove -->
|
||||
|
||||
Claude, keep an ever-growing changelog in [`JOURNAL.md`](JOURNAL.md).
|
||||
|
||||
### What to Journal
|
||||
- **Major changes**: New features, significant refactors, API changes
|
||||
- **Bug fixes**: What broke, why, and how it was fixed
|
||||
- **Frustration points**: Problems that took multiple attempts to solve
|
||||
- **Design decisions**: Why we chose one approach over another
|
||||
- **Performance improvements**: Before/after metrics
|
||||
- **User feedback**: Notable issues or requests
|
||||
- **Learning moments**: New techniques or patterns discovered
|
||||
|
||||
### Journal Format
|
||||
\```
|
||||
## YYYY-MM-DD HH:MM
|
||||
|
||||
### [Short Title]
|
||||
- **What**: Brief description of the change
|
||||
- **Why**: Reason for the change
|
||||
- **How**: Technical approach taken
|
||||
- **Issues**: Any problems encountered
|
||||
- **Result**: Outcome and any metrics
|
||||
|
||||
### [Short Title] |ERROR:ERR-YYYY-MM-DD-001|
|
||||
- **What**: Critical P0/P1 error description
|
||||
- **Why**: Root cause analysis
|
||||
- **How**: Fix implementation
|
||||
- **Issues**: Debugging challenges
|
||||
- **Result**: Resolution and prevention measures
|
||||
|
||||
### [Task Title] |TASK:TASK-YYYY-MM-DD-001|
|
||||
- **What**: Task implementation summary
|
||||
- **Why**: Part of [Phase Name] phase
|
||||
- **How**: Technical approach and key decisions
|
||||
- **Issues**: Blockers encountered and resolved
|
||||
- **Result**: Task completed, findings documented in ARCHITECTURE.md
|
||||
\```
|
||||
|
||||
### Compaction Rule
|
||||
When `JOURNAL.md` exceeds **500 lines**:
|
||||
1. Claude summarizes the oldest half into `JOURNAL_ARCHIVE/<year>-<month>.md`
|
||||
2. Remaining entries stay in `JOURNAL.md` so the file never grows unbounded
|
||||
|
||||
> ⚠️ Claude must NEVER delete raw history—only move & summarize.
|
||||
|
||||
### 2. ARCHITECTURE.md
|
||||
**Purpose**: System design, tech stack decisions, and code structure with line numbers.
|
||||
|
||||
**Required Elements**:
|
||||
- Technology stack listing
|
||||
- Directory structure diagram
|
||||
- Key architectural decisions with rationale
|
||||
- Component architecture with exact line numbers
|
||||
- System flow diagram (ASCII art)
|
||||
- Common patterns section
|
||||
- Keywords for search optimization
|
||||
|
||||
**Line Number Format**:
|
||||
\```
|
||||
#### ComponentName Structure <!-- #component-anchor -->
|
||||
\```typescript
|
||||
// Major classes with exact line numbers
|
||||
class MainClass { /* lines 100-500 */ } // <!-- #main-class -->
|
||||
class Helper { /* lines 501-600 */ } // <!-- #helper-class -->
|
||||
\```
|
||||
\```
|
||||
|
||||
### 3. DESIGN.md
|
||||
**Purpose**: Visual design system, styling, and theming documentation.
|
||||
|
||||
**Required Sections**:
|
||||
- Typography system
|
||||
- Color palette (with hex values)
|
||||
- Visual effects specifications
|
||||
- Character/entity design
|
||||
- UI/UX component styling
|
||||
- Animation system
|
||||
- Mobile design considerations
|
||||
- Accessibility guidelines
|
||||
- Keywords section
|
||||
|
||||
### 4. DATA_MODEL.md
|
||||
**Purpose**: Database schema, application models, and data structures.
|
||||
|
||||
**Required Elements**:
|
||||
- Database schema (SQL)
|
||||
- Application data models (TypeScript/language interfaces)
|
||||
- Validation rules
|
||||
- Common queries
|
||||
- Data migration history
|
||||
- Keywords for entities
|
||||
|
||||
### 5. API.md
|
||||
**Purpose**: Complete API documentation with examples.
|
||||
|
||||
**Structure for Each Endpoint**:
|
||||
\```
|
||||
### Endpoint Name
|
||||
|
||||
\```http
|
||||
METHOD /api/endpoint
|
||||
\```
|
||||
|
||||
#### Request
|
||||
\```json
|
||||
{
|
||||
"field": "type"
|
||||
}
|
||||
\```
|
||||
|
||||
#### Response
|
||||
\```json
|
||||
{
|
||||
"field": "value"
|
||||
}
|
||||
\```
|
||||
|
||||
#### Details
|
||||
- **Rate limit**: X requests per Y seconds
|
||||
- **Auth**: Required/Optional
|
||||
- **Notes**: Special considerations
|
||||
\```
|
||||
|
||||
### 6. CONFIG.md
|
||||
**Purpose**: Runtime configuration, environment variables, and settings.
|
||||
|
||||
**Required Sections**:
|
||||
- Environment variables (required and optional)
|
||||
- Application configuration constants
|
||||
- Feature flags
|
||||
- Performance tuning settings
|
||||
- Security configuration
|
||||
- Common patterns for configuration changes
|
||||
|
||||
### 7. BUILD.md
|
||||
**Purpose**: Build process, deployment, and CI/CD documentation.
|
||||
|
||||
**Include**:
|
||||
- Prerequisites
|
||||
- Build commands
|
||||
- CI/CD pipeline configuration
|
||||
- Deployment steps
|
||||
- Rollback procedures
|
||||
- Troubleshooting guide
|
||||
|
||||
### 8. TEST.md
|
||||
**Purpose**: Testing strategies, patterns, and examples.
|
||||
|
||||
**Sections**:
|
||||
- Test stack and tools
|
||||
- Running tests commands
|
||||
- Test structure
|
||||
- Coverage goals
|
||||
- Common test patterns
|
||||
- Debugging tests
|
||||
|
||||
### 9. UIUX.md
|
||||
**Purpose**: Interaction patterns, user flows, and behavior specifications.
|
||||
|
||||
**Cover**:
|
||||
- Input methods
|
||||
- State transitions
|
||||
- Component behaviors
|
||||
- User flows
|
||||
- Accessibility patterns
|
||||
- Performance considerations
|
||||
|
||||
### 10. CONTRIBUTING.md
|
||||
**Purpose**: Guidelines for contributors.
|
||||
|
||||
**Include**:
|
||||
- Code of conduct
|
||||
- Development setup
|
||||
- Code style guide
|
||||
- Commit message format
|
||||
- PR process
|
||||
- Common patterns
|
||||
|
||||
### 11. PLAYBOOKS/DEPLOY.md
|
||||
**Purpose**: Step-by-step operational procedures.
|
||||
|
||||
**Format**:
|
||||
- Pre-deployment checklist
|
||||
- Deployment steps (multiple options)
|
||||
- Post-deployment verification
|
||||
- Rollback procedures
|
||||
- Troubleshooting
|
||||
|
||||
### 12. ERRORS.md (Critical Error Ledger)
|
||||
**Purpose**: Track and resolve P0/P1 critical errors with full traceability.
|
||||
|
||||
**Required Structure**:
|
||||
\```
|
||||
# Critical Error Ledger <!-- auto-maintained -->
|
||||
|
||||
## Schema
|
||||
| ID | First seen | Status | Severity | Affected area | Link to fix |
|
||||
|----|------------|--------|----------|---------------|-------------|
|
||||
|
||||
## Active Errors
|
||||
[New errors added here, newest first]
|
||||
|
||||
## Resolved Errors
|
||||
[Moved here when fixed, with links to fixes]
|
||||
\```
|
||||
|
||||
**Error ID Format**: `ERR-YYYY-MM-DD-001` (increment for multiple per day)
|
||||
|
||||
**Severity Definitions**:
|
||||
- **P0**: Complete outage, data loss, security breach
|
||||
- **P1**: Major functionality broken, significant performance degradation
|
||||
- **P2**: Minor functionality (not tracked in ERRORS.md)
|
||||
- **P3**: Cosmetic issues (not tracked in ERRORS.md)
|
||||
|
||||
**Claude's Error Logging Process**:
|
||||
1. When P0/P1 error occurs, immediately add to Active Errors
|
||||
2. Create corresponding JOURNAL.md entry with details
|
||||
3. When resolved:
|
||||
- Move to Resolved Errors section
|
||||
- Update status to "resolved"
|
||||
- Add commit hash and PR link
|
||||
- Add `|ERROR:<ID>|` tag to JOURNAL.md entry
|
||||
- Link back to JOURNAL entry from ERRORS.md
|
||||
|
||||
### 13. TASKS.md (Active Task Management)
|
||||
**Purpose**: Track ongoing work with phase awareness and context preservation between sessions.
|
||||
|
||||
**IMPORTANT**: TASKS.md complements Claude's built-in todo system - it does NOT replace it:
|
||||
- Claude's todos: For immediate task tracking within a session
|
||||
- TASKS.md: For preserving context and state between sessions
|
||||
|
||||
**Required Structure**:
|
||||
```
|
||||
# Task Management
|
||||
|
||||
## Active Phase
|
||||
**Phase**: [High-level project phase name]
|
||||
**Started**: YYYY-MM-DD
|
||||
**Target**: YYYY-MM-DD
|
||||
**Progress**: X/Y tasks completed
|
||||
|
||||
## Current Task
|
||||
**Task ID**: TASK-YYYY-MM-DD-NNN
|
||||
**Title**: [Descriptive task name]
|
||||
**Status**: PLANNING | IN_PROGRESS | BLOCKED | TESTING | COMPLETE
|
||||
**Started**: YYYY-MM-DD HH:MM
|
||||
**Dependencies**: [List task IDs this depends on]
|
||||
|
||||
### Task Context
|
||||
<!-- Critical information needed to resume this task -->
|
||||
- **Previous Work**: [Link to related tasks/PRs]
|
||||
- **Key Files**: [Primary files being modified with line ranges]
|
||||
- **Environment**: [Specific config/versions if relevant]
|
||||
- **Next Steps**: [Immediate actions when resuming]
|
||||
|
||||
### Findings & Decisions
|
||||
- **FINDING-001**: [Discovery that affects approach]
|
||||
- **DECISION-001**: [Technical choice made] → Link to ARCHITECTURE.md
|
||||
- **BLOCKER-001**: [Issue preventing progress] → Link to resolution
|
||||
|
||||
### Task Chain
|
||||
1. ✅ [Completed prerequisite task] (TASK-YYYY-MM-DD-001)
|
||||
2. 🔄 [Current task] (CURRENT)
|
||||
3. ⏳ [Next planned task]
|
||||
4. ⏳ [Future task in phase]
|
||||
```
|
||||
|
||||
**Task Management Rules**:
|
||||
1. **One Active Task**: Only one task should be IN_PROGRESS at a time
|
||||
2. **Context Capture**: Before switching tasks, capture all context needed to resume
|
||||
3. **Findings Documentation**: Record unexpected discoveries that impact the approach
|
||||
4. **Decision Linking**: Link architectural decisions to ARCHITECTURE.md
|
||||
5. **Completion Trigger**: When task completes:
|
||||
- Generate JOURNAL.md entry with task summary
|
||||
- Archive task details to TASKS_ARCHIVE/YYYY-MM/TASK-ID.md
|
||||
- Load next task from chain or prompt for new phase
|
||||
|
||||
**Task States**:
|
||||
- **PLANNING**: Defining approach and breaking down work
|
||||
- **IN_PROGRESS**: Actively working on implementation
|
||||
- **BLOCKED**: Waiting on external dependency or decision
|
||||
- **TESTING**: Implementation complete, validating functionality
|
||||
- **COMPLETE**: Task finished and documented
|
||||
|
||||
**Integration with Journal**:
|
||||
- Each completed task auto-generates a journal entry
|
||||
- Journal references task ID for full context
|
||||
- Critical findings promoted to relevant documentation
|
||||
|
||||
## Documentation Optimization Rules
|
||||
|
||||
### 1. Line Number Anchors
|
||||
- Add exact line numbers for every class, function, and major code section
|
||||
- Format: `**Class Name (Lines 100-200)**`
|
||||
- Add HTML anchors: `<!-- #class-name -->`
|
||||
- Update when code structure changes significantly
|
||||
|
||||
### 2. Quick Reference Card
|
||||
- Place in CLAUDE.md after Table of Contents
|
||||
- Include 10-15 most common code locations
|
||||
- Format: `**Feature**: `file:lines` - Description`
|
||||
|
||||
### 3. Current State Tracking
|
||||
- Use checkbox format in CLAUDE.md
|
||||
- `- [x] Completed feature`
|
||||
- `- [ ] In-progress feature`
|
||||
- Update after each work session
|
||||
|
||||
### 4. Task Templates
|
||||
- Provide 3-5 step-by-step workflows
|
||||
- Include specific line numbers
|
||||
- Reference files that need updating
|
||||
- Add test/verification steps
|
||||
|
||||
### 5. Keywords Sections
|
||||
- Add to each major .md file
|
||||
- List alternative search terms
|
||||
- Format: `## Keywords <!-- #keywords -->`
|
||||
- Include synonyms and related terms
|
||||
|
||||
### 6. Anti-Patterns
|
||||
- Use ❌ emoji for clarity
|
||||
- Explain why each is problematic
|
||||
- Include 5-6 critical mistakes
|
||||
- Place prominently in CLAUDE.md
|
||||
|
||||
### 7. System Flow Diagrams
|
||||
- Use ASCII art for simplicity
|
||||
- Show data/control flow
|
||||
- Keep visual and readable
|
||||
- Place in ARCHITECTURE.md
|
||||
|
||||
### 8. Common Patterns
|
||||
- Add to relevant docs (CONFIG.md, ARCHITECTURE.md)
|
||||
- Show exact code changes needed
|
||||
- Include before/after examples
|
||||
- Reference specific functions
|
||||
|
||||
### 9. Version History
|
||||
- Link to JOURNAL.md entries
|
||||
- Format: `v1.0.0 - Feature (see JOURNAL.md YYYY-MM-DD)`
|
||||
- Track major changes only
|
||||
|
||||
### 10. Cross-Linking
|
||||
- Link between related sections
|
||||
- Use relative paths: `[Link](./FILE.md#section)`
|
||||
- Ensure bidirectional linking where appropriate
|
||||
|
||||
## Journal System Setup
|
||||
|
||||
### JOURNAL.md Structure
|
||||
\```
|
||||
# Engineering Journal
|
||||
|
||||
## YYYY-MM-DD HH:MM
|
||||
|
||||
### [Descriptive Title]
|
||||
- **What**: Brief description of the change
|
||||
- **Why**: Reason for the change
|
||||
- **How**: Technical approach taken
|
||||
- **Issues**: Any problems encountered
|
||||
- **Result**: Outcome and any metrics
|
||||
|
||||
---
|
||||
|
||||
[Entries continue chronologically]
|
||||
\```
|
||||
|
||||
### Journal Best Practices
|
||||
1. **Entry Timing**: Add entry immediately after significant work
|
||||
2. **Detail Level**: Include enough detail to understand the change months later
|
||||
3. **Problem Documentation**: Especially document multi-attempt solutions
|
||||
4. **Learning Moments**: Capture new techniques discovered
|
||||
5. **Metrics**: Include performance improvements, time saved, etc.
|
||||
|
||||
### Archive Process
|
||||
When JOURNAL.md exceeds 500 lines:
|
||||
1. Create `JOURNAL_ARCHIVE/` directory
|
||||
2. Move oldest 250 lines to `JOURNAL_ARCHIVE/YYYY-MM.md`
|
||||
3. Add summary header to archive file
|
||||
4. Keep recent entries in main JOURNAL.md
|
||||
|
||||
## Implementation Steps
|
||||
|
||||
### Phase 1: Initial Setup (30-60 minutes)
|
||||
1. **Create CLAUDE.md** with all required sections
|
||||
2. **Fill Critical Context** with 6 essential facts
|
||||
3. **Create Table of Contents** with placeholder links
|
||||
4. **Add Quick Reference** with top 10-15 code locations
|
||||
5. **Set up Journal section** with formatting rules
|
||||
|
||||
### Phase 2: Core Documentation (2-4 hours)
|
||||
1. **Create each .md file** from the list above
|
||||
2. **Add Keywords section** to each file
|
||||
3. **Cross-link between files** where relevant
|
||||
4. **Add line numbers** to code references
|
||||
5. **Create PLAYBOOKS/ directory** with DEPLOY.md
|
||||
6. **Create ERRORS.md** with schema table
|
||||
|
||||
### Phase 3: Optimization (1-2 hours)
|
||||
1. **Add Task Templates** to CLAUDE.md
|
||||
2. **Create ASCII system flow** in ARCHITECTURE.md
|
||||
3. **Add Common Patterns** sections
|
||||
4. **Document Anti-Patterns**
|
||||
5. **Set up Version History**
|
||||
|
||||
### Phase 4: First Journal Entry
|
||||
Create initial JOURNAL.md entry documenting the setup:
|
||||
\```
|
||||
## YYYY-MM-DD HH:MM
|
||||
|
||||
### Documentation Framework Implementation
|
||||
- **What**: Implemented CLAUDE.md modular documentation system
|
||||
- **Why**: Improve AI navigation and code maintainability
|
||||
- **How**: Split monolithic docs into focused modules with cross-linking
|
||||
- **Issues**: None - clean implementation
|
||||
- **Result**: [Number] documentation files created with full cross-referencing
|
||||
\```
|
||||
|
||||
## Maintenance Guidelines
|
||||
|
||||
### Daily
|
||||
- Update JOURNAL.md with significant changes
|
||||
- Mark completed items in Current State
|
||||
- Update line numbers if major refactoring
|
||||
|
||||
### Weekly
|
||||
- Review and update Quick Reference section
|
||||
- Check for broken cross-links
|
||||
- Update Task Templates if workflows change
|
||||
|
||||
### Monthly
|
||||
- Review Keywords sections for completeness
|
||||
- Update Version History
|
||||
- Check if JOURNAL.md needs archiving
|
||||
|
||||
### Per Release
|
||||
- Update Version History in CLAUDE.md
|
||||
- Create comprehensive JOURNAL.md entry
|
||||
- Review all documentation for accuracy
|
||||
- Update Current State checklist
|
||||
|
||||
## Benefits of This System
|
||||
|
||||
1. **AI Efficiency**: Claude can quickly navigate to exact code locations
|
||||
2. **Modularity**: Easy to update specific documentation without affecting others
|
||||
3. **Discoverability**: New developers/AI can quickly understand the project
|
||||
4. **History Tracking**: Complete record of changes and decisions
|
||||
5. **Task Automation**: Templates reduce repetitive instructions
|
||||
6. **Error Prevention**: Anti-patterns prevent common mistakes
|
||||
@@ -26,7 +26,7 @@
|
||||
- **What**: Per-agent filtering for MMA observability panels (comms, tool calls, discussion, token budget)
|
||||
- **Why**: All panels are global/session-scoped; in MMA mode with 4 tiers, data from all agents mixes. No way to isolate what a specific tier is doing.
|
||||
- **Gap**: `_comms_log` and `_tool_log` have no tier/agent tag. `mma_streams` stream_id is the only per-agent key that exists.
|
||||
- **See**: TASKS.md for full audit and implementation intent.
|
||||
- **See**: conductor/tracks.md for full audit and implementation intent.
|
||||
|
||||
---
|
||||
|
||||
@@ -42,7 +42,7 @@
|
||||
- **More Tracks**: Initialized 'tech_debt_and_test_cleanup_20260302' and 'conductor_workflow_improvements_20260302' to harden TDD discipline, resolve test tech debt (false-positives, dupes), and mandate AST-based codebase auditing.
|
||||
- **Final Track**: Initialized 'architecture_boundary_hardening_20260302' to fix the GUI HITL bypass allowing direct AST mutations, patch token bloat in `mma_exec.py`, and implement cascading blockers in `dag_engine.py`.
|
||||
- **Testing Consolidation**: Initialized 'testing_consolidation_20260302' track to standardize simulation testing workflows around the pytest `live_gui` fixture and eliminate redundant `subprocess.Popen` wrappers.
|
||||
- **Dependency Order**: Added an explicit 'Track Dependency Order' execution guide to `TASKS.md` to ensure safe progression through the accumulated tech debt.
|
||||
- **Dependency Order**: Added an explicit 'Track Dependency Order' execution guide to `conductor/tracks.md` to ensure safe progression through the accumulated tech debt.
|
||||
- **Documentation**: Added guide_meta_boundary.md to explicitly clarify the difference between the Application's strict-HITL environment and the autonomous Meta-Tooling environment, helping future Tiers avoid feature bleed.
|
||||
- **Heuristics & Backlog**: Added Data-Oriented Design and Immediate Mode architectural heuristics (inspired by Muratori/Acton) to product-guidelines.md. Logged future decoupling and robust parsing tracks to a 'Future Backlog' in TASKS.md.
|
||||
|
||||
|
||||
@@ -1,36 +0,0 @@
|
||||
# MMA Observability & UX Specification
|
||||
|
||||
## 1. Goal
|
||||
Implement the visible surface area of the 4-Tier Hierarchical Multi-Model Architecture within `gui_2.py`. This ensures the user can monitor, control, and debug the multi-agent execution flow.
|
||||
|
||||
## 2. Core Components
|
||||
|
||||
### 2.1 MMA Dashboard Panel
|
||||
- **Visibility:** A new dockable panel named "MMA Dashboard".
|
||||
- **Track Status:** Display the current active `Track` ID and overall progress (e.g., "3/10 Tickets Complete").
|
||||
- **Ticket DAG Visualization:** A list or simple graph representing the `Ticket` queue.
|
||||
- Each ticket shows: `ID`, `Target`, `Status` (Pending, Running, Paused, Complete, Blocked).
|
||||
- Visual indicators for dependencies (e.g., indented or linked).
|
||||
|
||||
### 2.2 The Execution Clutch (HITL)
|
||||
- **Step Mode Toggle:** A global or per-track checkbox to enable "Step Mode".
|
||||
- **Pause Points:**
|
||||
- **Pre-Execution:** When a Tier 3 worker generates a tool call (e.g., `write_file`), the engine pauses.
|
||||
- **UI Interaction:** The GUI displays the proposed script/change and provides:
|
||||
- `[Approve]`: Proceed with execution.
|
||||
- `[Edit Payload]`: Open the Memory Mutator.
|
||||
- `[Abort]`: Mark the ticket as Blocked/Cancelled.
|
||||
- **Visual Feedback:** Tactile/Arcade-style blinking or color changes when the engine is "Paused for HITL".
|
||||
|
||||
### 2.3 Memory Mutator (The "Debug" Superpower)
|
||||
- **Functionality:** A modal or dedicated text area that allows the user to edit the raw JSON conversation history of a paused worker.
|
||||
- **Use Case:** Fixing AI hallucinations or providing specific guidance mid-turn without restarting the context window.
|
||||
- **Integration:** After editing, the "Approve" button sends the *modified* history back to the engine.
|
||||
|
||||
### 2.4 Tiered Metrics & Logs
|
||||
- **Observability:** Show which model (Tier 1, 2, 3, or 4) is currently active.
|
||||
- **Sub-Agent Logs:** Provide quick links to open the timestamped log files generated by `mma_exec.py`.
|
||||
|
||||
## 3. Technical Integration
|
||||
- **Event Bus:** Use the existing `AsyncEventQueue` to push `StateUpdateEvents` from the `ConductorEngine` to the GUI.
|
||||
- **Non-Blocking:** Ensure the UI remains responsive (FPS > 60) even when multiple tickets are processing or the engine is waiting for user input.
|
||||
258
Readme.md
258
Readme.md
@@ -1,14 +1,56 @@
|
||||
# Sloppy
|
||||
# Manual Slop
|
||||
|
||||

|
||||
|
||||
A GUI orchestrator for local LLM-driven coding sessions. Manual Slop bridges high-latency AI reasoning with a low-latency ImGui render loop via a thread-safe asynchronous pipeline, ensuring every AI-generated payload passes through a human-auditable gate before execution.
|
||||
A high-density GUI orchestrator for local LLM-driven coding sessions. Manual Slop bridges high-latency AI reasoning with a low-latency ImGui render loop via a thread-safe asynchronous pipeline, ensuring every AI-generated payload passes through a human-auditable gate before execution.
|
||||
|
||||
**Tech Stack**: Python 3.11+, Dear PyGui / ImGui, FastAPI, Uvicorn
|
||||
**Providers**: Gemini API, Anthropic API, DeepSeek, Gemini CLI (headless)
|
||||
**Design Philosophy**: Full manual control over vendor API metrics, agent capabilities, and context memory usage. High information density, tactile interactions, and explicit confirmation for destructive actions.
|
||||
|
||||
**Tech Stack**: Python 3.11+, Dear PyGui / ImGui Bundle, FastAPI, Uvicorn, tree-sitter
|
||||
**Providers**: Gemini API, Anthropic API, DeepSeek, Gemini CLI (headless), MiniMax
|
||||
**Platform**: Windows (PowerShell) — single developer, local use
|
||||
|
||||

|
||||

|
||||
|
||||
---
|
||||
|
||||
## Key Features
|
||||
|
||||
### Multi-Provider Integration
|
||||
- **Gemini SDK**: Server-side context caching with TTL management, automatic cache rebuilding at 90% TTL
|
||||
- **Anthropic**: Ephemeral prompt caching with 4-breakpoint system, automatic history truncation at 180K tokens
|
||||
- **DeepSeek**: Dedicated SDK for code-optimized reasoning
|
||||
- **Gemini CLI**: Headless adapter with full functional parity, synchronous HITL bridge
|
||||
- **MiniMax**: Alternative provider support
|
||||
|
||||
### 4-Tier MMA Orchestration
|
||||
Hierarchical task decomposition with specialized models and strict token firewalling:
|
||||
- **Tier 1 (Orchestrator)**: Product alignment, epic → tracks
|
||||
- **Tier 2 (Tech Lead)**: Track → tickets (DAG), persistent context
|
||||
- **Tier 3 (Worker)**: Stateless TDD implementation, context amnesia
|
||||
- **Tier 4 (QA)**: Stateless error analysis, no fixes
|
||||
|
||||
### Strict Human-in-the-Loop (HITL)
|
||||
- **Execution Clutch**: All destructive actions suspend on `threading.Condition` pending GUI approval
|
||||
- **Three Dialog Types**: ConfirmDialog (scripts), MMAApprovalDialog (steps), MMASpawnApprovalDialog (workers)
|
||||
- **Editable Payloads**: Review, modify, or reject any AI-generated content before execution
|
||||
|
||||
### 26 MCP Tools with Sandboxing
|
||||
Three-layer security model: Allowlist Construction → Path Validation → Resolution Gate
|
||||
- **File I/O**: read, list, search, slice, edit, tree
|
||||
- **AST-Based (Python)**: skeleton, outline, definition, signature, class summary, docstring
|
||||
- **Analysis**: summary, git diff, find usages, imports, syntax check, hierarchy
|
||||
- **Network**: web search, URL fetch
|
||||
- **Runtime**: UI performance metrics
|
||||
|
||||
### Parallel Tool Execution
|
||||
Multiple independent tool calls within a single AI turn execute concurrently via `asyncio.gather`, significantly reducing latency.
|
||||
|
||||
### AST-Based Context Management
|
||||
- **Skeleton View**: Signatures + docstrings, bodies replaced with `...`
|
||||
- **Curated View**: Preserves `@core_logic` decorated functions and `[HOT]` comment blocks
|
||||
- **Targeted View**: Extracts only specified symbols and their dependencies
|
||||
- **Heuristic Summaries**: Token-efficient structural descriptions without AI calls
|
||||
|
||||
---
|
||||
|
||||
@@ -26,35 +68,12 @@ The **MMA (Multi-Model Agent)** system decomposes epics into tracks, tracks into
|
||||
|
||||
| Guide | Scope |
|
||||
|---|---|
|
||||
| [Readme](./docs/Readme.md) | Documentation index, GUI panel reference, configuration files, environment variables |
|
||||
| [Architecture](./docs/guide_architecture.md) | Threading model, event system, AI client multi-provider architecture, HITL mechanism, comms logging |
|
||||
| [Tools & IPC](./docs/guide_tools.md) | MCP Bridge security model, all 26 native tools, Hook API endpoints, ApiHookClient reference, shell runner |
|
||||
| [MMA Orchestration](./docs/guide_mma.md) | 4-tier hierarchy, Ticket/Track data structures, DAG engine, ConductorEngine execution loop, worker lifecycle |
|
||||
| [Simulations](./docs/guide_simulations.md) | `live_gui` fixture, Puppeteer pattern, mock provider, visual verification patterns, ASTParser / summarizer |
|
||||
|
||||
---
|
||||
|
||||
## Module Map
|
||||
|
||||
Core implementation resides in the `src/` directory.
|
||||
|
||||
| File | Role |
|
||||
|---|---|
|
||||
| `src/gui_2.py` | Primary ImGui interface — App class, frame-sync, HITL dialogs |
|
||||
| `src/ai_client.py` | Multi-provider LLM abstraction (Gemini, Anthropic, DeepSeek, Gemini CLI) |
|
||||
| `src/mcp_client.py` | 26 MCP tools with filesystem sandboxing and tool dispatch |
|
||||
| `src/api_hooks.py` | HookServer — REST API for external automation on `:8999` |
|
||||
| `src/api_hook_client.py` | Python client for the Hook API (used by tests and external tooling) |
|
||||
| `src/multi_agent_conductor.py` | ConductorEngine — Tier 2 orchestration loop with DAG execution |
|
||||
| `src/conductor_tech_lead.py` | Tier 2 ticket generation from track briefs |
|
||||
| `src/dag_engine.py` | TrackDAG (dependency graph) + ExecutionEngine (tick-based state machine) |
|
||||
| `src/models.py` | Ticket, Track, WorkerContext dataclasses |
|
||||
| `src/events.py` | EventEmitter, AsyncEventQueue, UserRequestEvent |
|
||||
| `src/project_manager.py` | TOML config persistence, discussion management, track state |
|
||||
| `src/session_logger.py` | JSON-L + markdown audit trails (comms, tools, CLI, hooks) |
|
||||
| `src/shell_runner.py` | PowerShell execution with timeout, env config, QA callback |
|
||||
| `src/file_cache.py` | ASTParser (tree-sitter) — skeleton and curated views |
|
||||
| `src/summarize.py` | Heuristic file summaries (imports, classes, functions) |
|
||||
| `src/outline_tool.py` | Hierarchical code outline via stdlib `ast` |
|
||||
| [Tools & IPC](./docs/guide_tools.md) | MCP Bridge 3-layer security, 26 tool inventory, Hook API endpoints, ApiHookClient reference, shell runner |
|
||||
| [MMA Orchestration](./docs/guide_mma.md) | 4-tier hierarchy, Ticket/Track data structures, DAG engine, ConductorEngine, worker lifecycle, abort propagation |
|
||||
| [Simulations](./docs/guide_simulations.md) | `live_gui` fixture, Puppeteer pattern, mock provider, visual verification, ASTParser / summarizer |
|
||||
| [Meta-Boundary](./docs/guide_meta_boundary.md) | Application vs Meta-Tooling domains, inter-domain bridges, safety model separation |
|
||||
|
||||
---
|
||||
|
||||
@@ -105,6 +124,151 @@ uv run pytest tests/ -v
|
||||
|
||||
---
|
||||
|
||||
## MMA 4-Tier Architecture
|
||||
|
||||
The Multi-Model Agent system uses hierarchical task decomposition with specialized models at each tier:
|
||||
|
||||
| Tier | Role | Model | Responsibility |
|
||||
|------|------|-------|----------------|
|
||||
| **Tier 1** | Orchestrator | `gemini-3.1-pro-preview` | Product alignment, epic → tracks, track initialization |
|
||||
| **Tier 2** | Tech Lead | `gemini-3-flash-preview` | Track → tickets (DAG), architectural oversight, persistent context |
|
||||
| **Tier 3** | Worker | `gemini-2.5-flash-lite` / `deepseek-v3` | Stateless TDD implementation per ticket, context amnesia |
|
||||
| **Tier 4** | QA | `gemini-2.5-flash-lite` / `deepseek-v3` | Stateless error analysis, diagnostics only (no fixes) |
|
||||
|
||||
**Key Principles:**
|
||||
- **Context Amnesia**: Tier 3/4 workers start with `ai_client.reset_session()` — no history bleed
|
||||
- **Token Firewalling**: Each tier receives only the context it needs
|
||||
- **Model Escalation**: Failed tickets automatically retry with more capable models
|
||||
- **WorkerPool**: Bounded concurrency (default: 4 workers) with semaphore gating
|
||||
|
||||
---
|
||||
|
||||
## Module by Domain
|
||||
|
||||
### src/ — Core implementation
|
||||
|
||||
| File | Role |
|
||||
|---|---|
|
||||
| `src/gui_2.py` | Primary ImGui interface — App class, frame-sync, HITL dialogs, event system |
|
||||
| `src/ai_client.py` | Multi-provider LLM abstraction (Gemini, Anthropic, DeepSeek, MiniMax) |
|
||||
| `src/mcp_client.py` | 26 MCP tools with filesystem sandboxing and tool dispatch |
|
||||
| `src/api_hooks.py` | HookServer — REST API on `127.0.0.1:8999 for external automation |
|
||||
| `src/api_hook_client.py` | Python client for the Hook API (used by tests and external tooling) |
|
||||
| `src/multi_agent_conductor.py` | ConductorEngine — Tier 2 orchestration loop with DAG execution |
|
||||
| `src/conductor_tech_lead.py` | Tier 2 ticket generation from track briefs |
|
||||
| `src/dag_engine.py` | TrackDAG (dependency graph) + ExecutionEngine (tick-based state machine) |
|
||||
| `src/models.py` | Ticket, Track, WorkerContext, Metadata, Track state |
|
||||
| `src/events.py` | EventEmitter, AsyncEventQueue, UserRequestEvent |
|
||||
| `src/project_manager.py` | TOML config persistence, discussion management, track state |
|
||||
| `src/session_logger.py` | JSON-L + markdown audit trails (comms, tools, CLI, hooks) |
|
||||
| `src/shell_runner.py` | PowerShell execution with timeout, env config, QA callback |
|
||||
| `src/file_cache.py` | ASTParser (tree-sitter) — skeleton, curated, and targeted views |
|
||||
| `src/summarize.py` | Heuristic file summaries (imports, classes, functions) |
|
||||
| `src/outline_tool.py` | Hierarchical code outline via stdlib `ast` |
|
||||
| `src/performance_monitor.py` | FPS, frame time, CPU, input lag tracking |
|
||||
| `src/log_registry.py` | Session metadata persistence |
|
||||
| `src/log_pruner.py` | Automated log cleanup based on age and whitelist |
|
||||
| `src/paths.py` | Centralized path resolution with environment variable overrides |
|
||||
| `src/cost_tracker.py` | Token cost estimation for API calls |
|
||||
| `src/gemini_cli_adapter.py` | CLI subprocess adapter with session management |
|
||||
| `src/mma_prompts.py` | Tier-specific system prompts for MMA orchestration |
|
||||
| `src/theme_*.py` | UI theming (dark, light modes) |
|
||||
|
||||
Simulation modules in `simulation/`:
|
||||
| File | Role |
|
||||
|---|--- |
|
||||
| `simulation/sim_base.py` | BaseSimulation class with setup/teardown lifecycle |
|
||||
| `simulation/workflow_sim.py` | WorkflowSimulator — high-level GUI automation |
|
||||
| `simulation/user_agent.py` | UserSimAgent — simulated user behavior (reading time, thinking delays) |
|
||||
|
||||
---
|
||||
|
||||
## Setup
|
||||
The MCP Bridge implements a three-layer security model in `mcp_client.py`:
|
||||
|
||||
Every tool accessing the filesystem passes through `_resolve_and_check(path)` before any I/O.
|
||||
|
||||
### Layer 1: Allowlist Construction (`configure`)
|
||||
Called by `ai_client` before each send cycle:
|
||||
1. Resets `_allowed_paths` and `_base_dirs` to empty sets
|
||||
2. Sets `_primary_base_dir` from `extra_base_dirs[0]`
|
||||
3. Iterates `file_items`, resolving paths, adding to allowlist
|
||||
4. Blacklist check: `history.toml`, `*_history.toml`, `config.toml`, `credentials.toml` are NEVER allowed
|
||||
|
||||
### Layer 2: Path Validation (`_is_allowed`)
|
||||
Checks run in order:
|
||||
1. **Blacklist**: `history.toml`, `*_history.toml` → hard deny
|
||||
2. **Explicit allowlist**: Path in `_allowed_paths` → allow
|
||||
3. **CWD fallback**: If no base dirs, allow `cwd()` subpaths
|
||||
4. **Base containment**: Must be subpath of `_base_dirs`
|
||||
5. **Default deny**: All other paths rejected
|
||||
|
||||
### Layer 3: Resolution Gate (`_resolve_and_check`)
|
||||
1. Convert raw path string to `Path`
|
||||
2. If not absolute, prepend `_primary_base_dir`
|
||||
3. Resolve to absolute (follows symlinks)
|
||||
4. Call `_is_allowed()`
|
||||
5. Return `(resolved_path, "")` on success or `(None, error_message)` on failure
|
||||
|
||||
All paths are resolved (following symlinks) before comparison, preventing symlink-based traversal attacks.
|
||||
|
||||
### Security Model
|
||||
|
||||
The MCP Bridge implements a three-layer security model in `mcp_client.py`. Every tool accessing the filesystem passes through `_resolve_and_check(path)` before any I/O.
|
||||
|
||||
### Layer 1: Allowlist Construction (`configure`)
|
||||
Called by `ai_client` before each send cycle:
|
||||
1. Resets `_allowed_paths` and `_base_dirs` to empty sets.
|
||||
2. Sets `_primary_base_dir` from `extra_base_dirs[0]` (resolved) or falls back to cwd().
|
||||
3. Iterates `file_items`, resolving each path to an absolute path, adding to `_allowed_paths`; its parent directory is added to `_base_dirs`.
|
||||
4. Any entries in `extra_base_dirs` that are valid directories are also added to `_base_dirs`.
|
||||
|
||||
### Layer 2: Path Validation (`_is_allowed`)
|
||||
Checks run in this exact order:
|
||||
1. **Blacklist**: `history.toml`, `*_history.toml`, `config`, `credentials` → hard deny
|
||||
2. **Explicit allowlist**: Path in `_allowed_paths` → allow
|
||||
7. **CWD fallback**: If no base dirs, any under `cwd()` is allowed (fail-safe for projects without explicit base dirs)
|
||||
8. **Base containment**: Must be a subpath of at least one entry in `_base_dirs` (via `relative_to()`)
|
||||
9. **Default deny**: All other paths rejected
|
||||
All paths are resolved (following symlinks) before comparison, preventing symlink-based traversal attacks.
|
||||
|
||||
### Layer 3: Resolution Gate (`_resolve_and_check`)
|
||||
Every tool call passes through this:
|
||||
1. Convert raw path string to `Path`.
|
||||
2. If not absolute, prepend `_primary_base_dir`.
|
||||
3. Resolve to absolute.
|
||||
4. Call `_is_allowed()`.
|
||||
5. Return `(resolved_path, "")` on success, `(None, error_message)` on failure
|
||||
All paths are resolved (following symlinks) before comparison, preventing symlink-based traversal attacks.
|
||||
|
||||
---
|
||||
|
||||
## Conductor SystemThe project uses a spec-driven track system in `conductor/` for structured development:
|
||||
|
||||
```
|
||||
conductor/
|
||||
├── workflow.md # Task lifecycle, TDD protocol, phase verification
|
||||
├── tech-stack.md # Technology constraints and patterns
|
||||
├── product.md # Product vision and guidelines
|
||||
├── product-guidelines.md # Code standards, UX principles
|
||||
└── tracks/
|
||||
└── <track_name>_<YYYYMMDD>/
|
||||
├── spec.md # Track specification
|
||||
├── plan.md # Implementation plan with checkbox tasks
|
||||
├── metadata.json # Track metadata
|
||||
└── state.toml # Structured state with task list
|
||||
```
|
||||
|
||||
**Key Concepts:**
|
||||
- **Tracks**: Self-contained implementation units with spec, plan, and state
|
||||
- **TDD Protocol**: Red (failing tests) → Green (pass) → Refactor
|
||||
- **Phase Checkpoints**: Verification gates with git notes for audit trails
|
||||
- **MMA Delegation**: Tracks are executed via the 4-tier agent hierarchy
|
||||
|
||||
See `conductor/workflow.md` for the full development workflow.
|
||||
|
||||
---
|
||||
|
||||
## Project Configuration
|
||||
|
||||
Projects are stored as `<name>.toml` files. The discussion history is split into a sibling `<name>_history.toml` to keep the main config lean.
|
||||
@@ -134,3 +298,31 @@ run_powershell = true
|
||||
read_file = true
|
||||
# ... 26 tool flags
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Quick Reference
|
||||
|
||||
### Hook API Endpoints (port 8999)
|
||||
|
||||
| Endpoint | Method | Description |
|
||||
|----------|--------|-------------|
|
||||
| `/status` | GET | Health check |
|
||||
| `/api/project` | GET/POST | Project config |
|
||||
| `/api/session` | GET/POST | Discussion entries |
|
||||
| `/api/gui` | POST | GUI task queue |
|
||||
| `/api/gui/mma_status` | GET | Full MMA state |
|
||||
| `/api/gui/value/<tag>` | GET | Read GUI field |
|
||||
| `/api/ask` | POST | Blocking HITL dialog |
|
||||
|
||||
### MCP Tool Categories
|
||||
|
||||
| Category | Tools |
|
||||
|----------|-------|
|
||||
| **File I/O** | `read_file`, `list_directory`, `search_files`, `get_tree`, `get_file_slice`, `set_file_slice`, `edit_file` |
|
||||
| **AST (Python)** | `py_get_skeleton`, `py_get_code_outline`, `py_get_definition`, `py_update_definition`, `py_get_signature`, `py_set_signature`, `py_get_class_summary`, `py_get_var_declaration`, `py_set_var_declaration`, `py_get_docstring` |
|
||||
| **Analysis** | `get_file_summary`, `get_git_diff`, `py_find_usages`, `py_get_imports`, `py_check_syntax`, `py_get_hierarchy` |
|
||||
| **Network** | `web_search`, `fetch_url` |
|
||||
| **Runtime** | `get_ui_performance` |
|
||||
|
||||
---
|
||||
|
||||
29
TASKS.md
29
TASKS.md
@@ -4,6 +4,7 @@
|
||||
|
||||
## Active Tracks
|
||||
*(none — all planned tracks queued below)*
|
||||
*See tracks.md for active track status*
|
||||
|
||||
## Completed This Session
|
||||
*(See archive: strict_execution_queue_completed_20260306)*
|
||||
@@ -127,3 +128,31 @@
|
||||
- **Status:** Planned
|
||||
- **Priority:** Medium
|
||||
- **Goal:** Interactive human-in-the-loop track to review and adjust GUI UX, animations, popups, and layout structures.
|
||||
|
||||
---
|
||||
|
||||
### C/C++ Language Support
|
||||
|
||||
#### 25. ts_cpp_tree_sitter_20260308
|
||||
- **Status:** Planned
|
||||
- **Priority:** High
|
||||
- **Goal:** Add tree-sitter C and C++ grammars. Extend ASTParser to support C/C++ skeleton and outline extraction. Add MCP tools ts_c_get_skeleton, ts_cpp_get_skeleton, ts_c_get_code_outline, ts_cpp_get_code_outline.
|
||||
|
||||
#### 26. gencpp_python_bindings_20260308
|
||||
- **Status:** Planned
|
||||
- **Priority:** Medium
|
||||
- **Goal:** Bootstrap standalone Python project with CFFI bindings for gencpp C library. Provides foundation for richer C++ AST parsing in future (beyond tree-sitter syntax).
|
||||
|
||||
---
|
||||
|
||||
### Path Configuration
|
||||
|
||||
#### 27. project_conductor_dir_20260308
|
||||
- **Status:** Planned
|
||||
- **Priority:** High
|
||||
- **Goal:** Make conductor directory per-project. Each project TOML can specify custom conductor dir for isolated track/state management. Extends existing global path config.
|
||||
|
||||
#### 28. gui_path_config_20260308
|
||||
- **Status:** Planned
|
||||
- **Priority:** High
|
||||
- **Goal:** Add path configuration UI to Context Hub. Allow users to view and edit configurable paths (conductor, logs, scripts) directly from the GUI.
|
||||
|
||||
BIN
assets/fonts/Inconsolata-Medium.ttf
Normal file
BIN
assets/fonts/Inconsolata-Medium.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/Inter-Bold.ttf
Normal file
BIN
assets/fonts/Inter-Bold.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/Inter-BoldItalic.ttf
Normal file
BIN
assets/fonts/Inter-BoldItalic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/Inter-Italic.ttf
Normal file
BIN
assets/fonts/Inter-Italic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/Inter-Regular.ttf
Normal file
BIN
assets/fonts/Inter-Regular.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/Inter-RegularItalic.ttf
Normal file
BIN
assets/fonts/Inter-RegularItalic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/MapleMono-Bold.ttf
Normal file
BIN
assets/fonts/MapleMono-Bold.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/MapleMono-BoldItalic.ttf
Normal file
BIN
assets/fonts/MapleMono-BoldItalic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/MapleMono-Italic.ttf
Normal file
BIN
assets/fonts/MapleMono-Italic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/MapleMono-Regular.ttf
Normal file
BIN
assets/fonts/MapleMono-Regular.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/MapleMono-RegularItalic.ttf
Normal file
BIN
assets/fonts/MapleMono-RegularItalic.ttf
Normal file
Binary file not shown.
BIN
assets/fonts/fontawesome-webfont.ttf
Normal file
BIN
assets/fonts/fontawesome-webfont.ttf
Normal file
Binary file not shown.
24
conductor/archive/gui_performance_profiling_20260307/plan.md
Normal file
24
conductor/archive/gui_performance_profiling_20260307/plan.md
Normal file
@@ -0,0 +1,24 @@
|
||||
# Implementation Plan: GUI Performance Profiling & Optimization (gui_performance_profiling_20260307)
|
||||
|
||||
> **Reference:** [Spec](./spec.md) | [Architecture Guide](../../../docs/guide_architecture.md)
|
||||
|
||||
## Phase 1: Instrumentation
|
||||
Focus: Add profiling hooks to core application paths
|
||||
|
||||
- [x] Task 1.1: Wrap all `_render_*` methods in `gui_2.py` with profiling calls. (7198c87, 1f760f2)
|
||||
- [x] Task 1.2: Wrap background thread methods in `app_controller.py` with profiling calls. (1f760f2)
|
||||
- [x] Task 1.3: Wrap core AI request and tool execution methods in `ai_client.py` with profiling calls. (1f760f2)
|
||||
- [x] Task 1.4: Refactor `PerformanceMonitor` to a singleton pattern for cross-module consistency. (1f760f2)
|
||||
|
||||
## Phase 2: Diagnostics UI
|
||||
Focus: Display timings in the GUI
|
||||
|
||||
- [x] Task 2.1: Add "Detailed Component Timings" table to Diagnostics panel in `src/gui_2.py`. (1f760f2)
|
||||
- [x] Task 2.2: Implement 10ms threshold highlighting in the table. (1f760f2)
|
||||
- [x] Task 2.3: Implement a global "Enable Profiling" toggle synchronized across modules. (1f760f2)
|
||||
|
||||
## Phase 3: Verification & Optimization
|
||||
Focus: Analyze results and fix bottlenecks
|
||||
|
||||
- [x] Task 3.1: Verify timings are accurate via manual walkthrough. (1f760f2)
|
||||
- [x] Task 3.2: Identify components consistently > 10ms and propose optimizations. (1f760f2)
|
||||
@@ -5,8 +5,8 @@
|
||||
## Phase 1: Thread Tracking
|
||||
Focus: Track active worker threads
|
||||
|
||||
- [ ] Task 1.1: Initialize MMA Environment
|
||||
- [ ] Task 1.2: Add worker tracking dict to ConductorEngine
|
||||
- [x] Task 1.1: Initialize MMA Environment
|
||||
- [x] Task 1.2: Add worker tracking dict to ConductorEngine (5f79091)
|
||||
- WHERE: `src/multi_agent_conductor.py` `ConductorEngine.__init__`
|
||||
- WHAT: Dict to track active workers
|
||||
- HOW:
|
||||
@@ -18,12 +18,12 @@ Focus: Track active worker threads
|
||||
## Phase 2: Abort Mechanism
|
||||
Focus: Add abort signal to workers
|
||||
|
||||
- [ ] Task 2.1: Create abort event per ticket
|
||||
- [x] Task 2.1: Create abort event per ticket (da011fb)
|
||||
- WHERE: `src/multi_agent_conductor.py` before spawning worker
|
||||
- WHAT: Create threading.Event for abort
|
||||
- HOW: `self._abort_events[ticket.id] = threading.Event()`
|
||||
|
||||
- [ ] Task 2.2: Check abort in worker lifecycle
|
||||
- [x] Task 2.2: Check abort in worker lifecycle (597e6b5)
|
||||
- WHERE: `src/multi_agent_conductor.py` `run_worker_lifecycle()`
|
||||
- WHAT: Check abort event between operations
|
||||
- HOW:
|
||||
@@ -37,8 +37,7 @@ Focus: Add abort signal to workers
|
||||
## Phase 3: Kill Button UI
|
||||
Focus: Add kill button to GUI
|
||||
|
||||
- [ ] Task 3.1: Add kill button per worker
|
||||
- WHERE: `src/gui_2.py` MMA dashboard
|
||||
- [x] Task 3.1: Add kill button per worker (d74f629)
|
||||
- WHAT: Button to kill specific worker
|
||||
- HOW:
|
||||
```python
|
||||
@@ -48,7 +47,7 @@ Focus: Add kill button to GUI
|
||||
engine.kill_worker(ticket_id)
|
||||
```
|
||||
|
||||
- [ ] Task 3.2: Implement kill_worker method
|
||||
- [x] Task 3.2: Implement kill_worker method (597e6b5)
|
||||
- WHERE: `src/multi_agent_conductor.py`
|
||||
- WHAT: Set abort event and wait for termination
|
||||
- HOW:
|
||||
@@ -5,8 +5,8 @@
|
||||
## Phase 1: Add Manual Block Fields
|
||||
Focus: Add manual_block flag to Ticket
|
||||
|
||||
- [ ] Task 1.1: Initialize MMA Environment
|
||||
- [ ] Task 1.2: Add manual_block field to Ticket
|
||||
- [x] Task 1.1: Initialize MMA Environment
|
||||
- [x] Task 1.2: Add manual_block field to Ticket (094a6c3)
|
||||
- WHERE: `src/models.py` `Ticket` dataclass
|
||||
- WHAT: Add `manual_block: bool = False`
|
||||
- HOW:
|
||||
@@ -14,7 +14,7 @@ Focus: Add manual_block flag to Ticket
|
||||
manual_block: bool = False
|
||||
```
|
||||
|
||||
- [ ] Task 1.3: Add mark_manual_block method
|
||||
- [x] Task 1.3: Add mark_manual_block method (094a6c3)
|
||||
- WHERE: `src/models.py` `Ticket`
|
||||
- WHAT: Method to set manual block with reason
|
||||
- HOW:
|
||||
@@ -28,12 +28,12 @@ Focus: Add manual_block flag to Ticket
|
||||
## Phase 2: Block/Unblock UI
|
||||
Focus: Add block buttons to ticket display
|
||||
|
||||
- [ ] Task 2.1: Add block button
|
||||
- [x] Task 2.1: Add block button (2ff5a8b)
|
||||
- WHERE: `src/gui_2.py` ticket rendering
|
||||
- WHAT: Button to block with reason input
|
||||
- HOW: Modal with text input for reason
|
||||
|
||||
- [ ] Task 2.2: Add unblock button
|
||||
- [x] Task 2.2: Add unblock button (2ff5a8b)
|
||||
- WHERE: `src/gui_2.py` ticket rendering
|
||||
- WHAT: Button to clear manual block
|
||||
- HOW:
|
||||
@@ -48,11 +48,11 @@ Focus: Add block buttons to ticket display
|
||||
## Phase 3: Cascade Integration
|
||||
Focus: Trigger cascade on block/unblock
|
||||
|
||||
- [ ] Task 3.1: Call cascade_blocks after manual block
|
||||
- [x] Task 3.1: Call cascade_blocks after manual block (c6d0bc8)
|
||||
- WHERE: `src/gui_2.py` or `src/multi_agent_conductor.py`
|
||||
- WHAT: Update downstream tickets
|
||||
- HOW: `self.dag.cascade_blocks()`
|
||||
|
||||
## Phase 4: Testing
|
||||
- [ ] Task 4.1: Write unit tests
|
||||
- [ ] Task 4.2: Conductor - Phase Verification
|
||||
- [x] Task 4.1: Write unit tests
|
||||
- [x] Task 4.2: Conductor - Phase Verification
|
||||
49
conductor/archive/on_demand_def_lookup_20260306/plan.md
Normal file
49
conductor/archive/on_demand_def_lookup_20260306/plan.md
Normal file
@@ -0,0 +1,49 @@
|
||||
# Implementation Plan: On-Demand Definition Lookup (on_demand_def_lookup_20260306)
|
||||
|
||||
> **Reference:** [Spec](./spec.md) | [Architecture Guide](../../../docs/guide_architecture.md)
|
||||
|
||||
## Phase 1: Symbol Parsing [checkpoint: f392aa3]
|
||||
Focus: Parse @symbol syntax from user input
|
||||
|
||||
- [x] Task 1.1: Initialize MMA Environment
|
||||
- [x] Task 1.2: Implement @symbol regex parser (a0a9d00)
|
||||
- WHERE: `src/gui_2.py` in `_send_callback()`
|
||||
- WHAT: Extract @SymbolName patterns
|
||||
- HOW:
|
||||
```python
|
||||
import re
|
||||
def parse_symbols(text: str) -> list[str]:
|
||||
return re.findall(r'@(\w+(?:\.\w+)*)', text)
|
||||
```
|
||||
|
||||
## Phase 2: Definition Retrieval
|
||||
Focus: Use existing MCP tool to get definitions
|
||||
|
||||
- [x] Task 2.1: Integrate py_get_definition (c6f9dc8)
|
||||
- WHERE: `src/gui_2.py`
|
||||
- WHAT: Call MCP tool for each symbol
|
||||
- HOW:
|
||||
```python
|
||||
from src import mcp_client
|
||||
def get_symbol_definition(symbol: str, files: list[str]) -> tuple[str, str] | None:
|
||||
for file_path in files:
|
||||
result = mcp_client.py_get_definition(file_path, symbol)
|
||||
if result and "not found" not in result.lower():
|
||||
return (file_path, result)
|
||||
return None
|
||||
```
|
||||
|
||||
## Phase 3: Inline Display [checkpoint: 7ea833e]
|
||||
Focus: Display definition in discussion
|
||||
|
||||
- [x] Task 3.1: Inject definition as context (7ea833e)
|
||||
|
||||
## Phase 4: Click Navigation [checkpoint: 7ea833e]
|
||||
Focus: Allow clicking definition to open file
|
||||
|
||||
- [x] Task 4.1: Store file/line metadata with definition (7ea833e)
|
||||
- [x] Task 4.2: Add click handler (7ea833e)
|
||||
|
||||
## Phase 5: Testing [checkpoint: 7ea833e]
|
||||
- [x] Task 5.1: Write unit tests for parsing (7ea833e)
|
||||
- [x] Task 5.2: Conductor - Phase Verification (7ea833e)
|
||||
53
conductor/archive/per_ticket_model_20260306/plan.md
Normal file
53
conductor/archive/per_ticket_model_20260306/plan.md
Normal file
@@ -0,0 +1,53 @@
|
||||
# Implementation Plan: Per-Ticket Model Override (per_ticket_model_20260306)
|
||||
|
||||
> **Reference:** [Spec](./spec.md) | [Architecture Guide](../../../docs/guide_architecture.md)
|
||||
|
||||
## Phase 1: Model Override Field
|
||||
Focus: Add field to Ticket dataclass
|
||||
|
||||
- [x] Task 1.1: Initialize MMA Environment
|
||||
- [x] Task 1.2: Add model_override to Ticket (245653c)
|
||||
- WHERE: `src/models.py` `Ticket` dataclass
|
||||
- WHAT: Add optional model override field
|
||||
- HOW:
|
||||
```python
|
||||
@dataclass
|
||||
class Ticket:
|
||||
# ... existing fields ...
|
||||
model_override: Optional[str] = None
|
||||
```
|
||||
|
||||
- [x] Task 1.3: Update serialization (245653c)
|
||||
- WHERE: `src/models.py` `Ticket.to_dict()` and `from_dict()`
|
||||
- WHAT: Include model_override
|
||||
- HOW: Add field to dict conversion
|
||||
|
||||
## Phase 2: Model Dropdown UI
|
||||
Focus: Add model selection to ticket display
|
||||
|
||||
- [x] Task 2.1: Get available models list (63d1b04)
|
||||
|
||||
- [x] Task 2.2: Add dropdown to ticket UI (63d1b04)
|
||||
|
||||
- [x] Task 3.1: Color-code override tickets (63d1b04)
|
||||
|
||||
## Phase 4: Execution Integration
|
||||
Focus: Use override in worker execution
|
||||
|
||||
- [x] Task 4.1: Check override in ConductorEngine.run() (e20f8a1)
|
||||
- WHERE: `src/multi_agent_conductor.py` `run()`
|
||||
- WHAT: Use ticket.model_override if set
|
||||
- HOW:
|
||||
```python
|
||||
if ticket.model_override:
|
||||
model_name = ticket.model_override
|
||||
else:
|
||||
# Use existing escalation logic
|
||||
models = ["gemini-2.5-flash-lite", "gemini-2.5-flash", "gemini-3.1-pro-preview"]
|
||||
model_idx = min(ticket.retry_count, len(models) - 1)
|
||||
model_name = models[model_idx]
|
||||
```
|
||||
|
||||
## Phase 5: Testing
|
||||
- [x] Task 5.1: Write unit tests
|
||||
- [x] Task 5.2: Conductor - Phase Verification
|
||||
@@ -5,8 +5,8 @@
|
||||
## Phase 1: Pause Mechanism
|
||||
Focus: Add pause event to ConductorEngine
|
||||
|
||||
- [ ] Task 1.1: Initialize MMA Environment
|
||||
- [ ] Task 1.2: Add pause event to ConductorEngine
|
||||
- [x] Task 1.1: Initialize MMA Environment
|
||||
- [x] Task 1.2: Add pause event to ConductorEngine (0c3a206)
|
||||
- WHERE: `src/multi_agent_conductor.py` `ConductorEngine.__init__`
|
||||
- WHAT: Threading event for pause control
|
||||
- HOW:
|
||||
@@ -14,7 +14,7 @@ Focus: Add pause event to ConductorEngine
|
||||
self._pause_event: threading.Event = threading.Event()
|
||||
```
|
||||
|
||||
- [ ] Task 1.3: Check pause in run loop
|
||||
- [x] Task 1.3: Check pause in run loop (0c3a206)
|
||||
- WHERE: `src/multi_agent_conductor.py` `run()`
|
||||
- WHAT: Wait while paused
|
||||
- HOW:
|
||||
@@ -29,18 +29,18 @@ Focus: Add pause event to ConductorEngine
|
||||
## Phase 2: Pause/Resume Methods
|
||||
Focus: Add control methods
|
||||
|
||||
- [ ] Task 2.1: Add pause method
|
||||
- [x] Task 2.1: Add pause method (0c3a206)
|
||||
- WHERE: `src/multi_agent_conductor.py`
|
||||
- HOW: `self._pause_event.set()`
|
||||
|
||||
- [ ] Task 2.2: Add resume method
|
||||
- [x] Task 2.2: Add resume method (0c3a206)
|
||||
- WHERE: `src/multi_agent_conductor.py`
|
||||
- HOW: `self._pause_event.clear()`
|
||||
|
||||
## Phase 3: UI Controls
|
||||
Focus: Add pause/resume buttons
|
||||
|
||||
- [ ] Task 3.1: Add pause/resume button
|
||||
- [x] Task 3.1: Add pause/resume button (3cb7d4f)
|
||||
- WHERE: `src/gui_2.py` MMA dashboard
|
||||
- WHAT: Toggle button for pause state
|
||||
- HOW:
|
||||
@@ -54,7 +54,7 @@ Focus: Add pause/resume buttons
|
||||
engine.pause()
|
||||
```
|
||||
|
||||
- [ ] Task 3.2: Add visual indicator
|
||||
- [x] Task 3.2: Add visual indicator (3cb7d4f)
|
||||
- WHERE: `src/gui_2.py`
|
||||
- WHAT: Banner or color when paused
|
||||
- HOW:
|
||||
@@ -64,5 +64,5 @@ Focus: Add pause/resume buttons
|
||||
```
|
||||
|
||||
## Phase 4: Testing
|
||||
- [ ] Task 4.1: Write unit tests
|
||||
- [ ] Task 4.2: Conductor - Phase Verification
|
||||
- [x] Task 4.1: Write unit tests
|
||||
- [x] Task 4.2: Conductor - Phase Verification
|
||||
22
conductor/archive/test_integrity_audit_20260307/findings.md
Normal file
22
conductor/archive/test_integrity_audit_20260307/findings.md
Normal file
@@ -0,0 +1,22 @@
|
||||
# Findings: Test Integrity Audit
|
||||
|
||||
## Simplification Patterns Detected
|
||||
|
||||
1. **State Bypassing (test_gui_updates.py)**
|
||||
- **Issue:** Test `test_gui_updates_on_event` directly manipulated internal GUI state (`app_instance._token_stats`) and `_token_stats_dirty` flag instead of dispatching the API event and testing the queue-to-GUI handover.
|
||||
- **Action Taken:** Restored the mocked client event dispatch, added code to simulate the cross-thread event queue relay to `_pending_gui_tasks`, and asserted that the state updated correctly via the full intended pipeline.
|
||||
|
||||
2. **Inappropriate Skipping (test_gui2_performance.py)**
|
||||
- **Issue:** Test `test_performance_baseline_check` introduced a `pytest.skip` if `avg_fps` was 0 instead of failing. This masked a situation where the GUI render loop or API hooks completely failed.
|
||||
- **Action Taken:** Removed the skip and replaced it with a strict assertion `assert gui2_m["avg_fps"] > 0` and kept the `assert >= 30` checks to ensure failures are raised on missing or sub-par metrics.
|
||||
|
||||
3. **Loose Assertion Counting (test_conductor_engine_v2.py)**
|
||||
- **Issue:** The test `test_run_worker_lifecycle_pushes_response_via_queue` used `assert_called()` rather than validating exactly how many times or in what order the event queue mock was called.
|
||||
- **Action Taken:** Updated the test to correctly verify `assert mock_queue_put.call_count >= 1` and specifically checked that the first queued element was the correct `'response'` message, ensuring no duplicate states hide regressions.
|
||||
|
||||
4. **Missing Intent / Documentation (All test files)**
|
||||
- **Issue:** Over time, test docstrings were removed or never added. If a test's intent isn't obvious, future AI agents or developers may not realize they are breaking an implicit rule by modifying the assertions.
|
||||
- **Action Taken:** Added explicit module-level and function-level `ANTI-SIMPLIFICATION` comments detailing exactly *why* each assertion matters (e.g. cross-thread state bounds, cycle detection in DAG, verifying exact tracking stats).
|
||||
|
||||
## Summary
|
||||
The core tests have had their explicit behavioral assertions restored and are now properly guarded against future "AI agent dumbing-down" with explicit ANTI-SIMPLIFICATION flags that clearly explain the consequence of modifying the assertions.
|
||||
@@ -0,0 +1,40 @@
|
||||
{
|
||||
"id": "test_integrity_audit_20260307",
|
||||
"title": "Test Integrity Audit & Intent Documentation",
|
||||
"description": "Audit and fix tests that have been simplified by AI agents, restore verification intent through explicit documentation",
|
||||
"type": "quality_assurance",
|
||||
"status": "in_progress",
|
||||
"priority": "critical",
|
||||
"created": "2026-03-07",
|
||||
"last_updated": "2026-03-07",
|
||||
"dependencies": [],
|
||||
"focus_areas": [
|
||||
"test_audit",
|
||||
"test_documentation",
|
||||
"quality_assurance"
|
||||
],
|
||||
"affected_files": [
|
||||
"tests/test_gui_updates.py",
|
||||
"tests/test_gui_phase3.py",
|
||||
"tests/test_conductor_engine_v2.py",
|
||||
"tests/test_gui2_performance.py",
|
||||
"tests/test_sim_base.py",
|
||||
"tests/test_sim_context.py",
|
||||
"tests/test_sim_tools.py",
|
||||
"tests/test_sim_execution.py",
|
||||
"tests/test_sim_ai_settings.py",
|
||||
"tests/test_live_workflow.py",
|
||||
"tests/test_live_gui_integration_v2.py",
|
||||
"tests/test_dag_engine.py",
|
||||
"tests/test_mma_orchestration_gui.py",
|
||||
"tests/test_gui2_layout.py",
|
||||
"tests/test_gui2_events.py",
|
||||
"tests/test_gui2_mcp.py",
|
||||
"tests/test_gui_symbol_navigation.py"
|
||||
],
|
||||
"tags": [
|
||||
"test-audit",
|
||||
"anti-simplification",
|
||||
"test-integrity"
|
||||
]
|
||||
}
|
||||
161
conductor/archive/test_integrity_audit_20260307/plan.md
Normal file
161
conductor/archive/test_integrity_audit_20260307/plan.md
Normal file
@@ -0,0 +1,161 @@
|
||||
# Plan: Test Integrity Audit & Intent Documentation
|
||||
|
||||
## Phase 1: Pattern Detection & Analysis
|
||||
Focus: Identify test files with simplification patterns
|
||||
|
||||
### Tasks
|
||||
|
||||
- [x] Task 1.1: Analyze tests/test_gui_updates.py for simplification
|
||||
- File: tests/test_gui_updates.py
|
||||
- Check: Mock patching changes, removed assertions, skip additions
|
||||
- Reference: git diff shows changes to mock structure (lines 28-48)
|
||||
- Intent: Verify _refresh_api_metrics and _process_pending_gui_tasks work correctly
|
||||
|
||||
- [x] Task 1.2: Analyze tests/test_gui_phase3.py for simplification
|
||||
- File: tests/test_gui_phase3.py
|
||||
- Check: Collapsed structure, removed test coverage
|
||||
- Reference: 22 lines changed, structure simplified
|
||||
- Intent: Verify track proposal editing, conductor setup scanning, track creation
|
||||
|
||||
- [x] Task 1.3: Analyze tests/test_conductor_engine_v2.py for simplification
|
||||
- File: tests/test_conductor_engine_v2.py
|
||||
- Check: Engine execution changes, assertion removal
|
||||
- Reference: 4 lines changed
|
||||
|
||||
- [x] Task 1.4: Analyze tests/test_gui2_performance.py for inappropriate skips
|
||||
- File: tests/test_gui2_performance.py
|
||||
- Check: New skip conditions, weakened assertions
|
||||
- Reference: Added skip for zero FPS (line 65-66)
|
||||
- Intent: Verify GUI maintains 30+ FPS baseline
|
||||
|
||||
- [x] Task 1.5: Run git blame analysis on modified test files
|
||||
- Command: git blame tests/ --since="2026-02-07" to identify AI-modified tests
|
||||
- Identify commits from AI agents (look for specific commit messages)
|
||||
|
||||
- [x] Task 1.6: Analyze simulation tests for simplification (test_sim_*.py)
|
||||
- Files: test_sim_base.py, test_sim_context.py, test_sim_tools.py, test_sim_execution.py, test_sim_ai_settings.py
|
||||
- These tests simulate user actions - critical for regression detection
|
||||
- Check: Puppeteer patterns, mock overuse, assertion removal
|
||||
|
||||
- [x] Task 1.7: Analyze live workflow tests
|
||||
- Files: test_live_workflow.py, test_live_gui_integration_v2.py
|
||||
- These tests verify end-to-end user flows
|
||||
- Check: End-to-end verification integrity
|
||||
|
||||
- [x] Task 1.8: Analyze major feature tests (core application)
|
||||
- Files: test_dag_engine.py, test_conductor_engine_v2.py, test_mma_orchestration_gui.py
|
||||
- Core orchestration - any simplification is critical
|
||||
- Check: Engine behavior verification
|
||||
|
||||
- [x] Task 1.9: Analyze GUI feature tests
|
||||
- Files: test_gui2_layout.py, test_gui2_events.py, test_gui2_mcp.py, test_gui_symbol_navigation.py
|
||||
- UI functionality - verify visual feedback is tested
|
||||
- Check: UI state verification
|
||||
|
||||
## Phase 2: Test Intent Documentation
|
||||
Focus: Add docstrings and anti-simplification comments to all audited tests
|
||||
|
||||
### Tasks
|
||||
|
||||
- [x] Task 2.1: Add docstrings to test_gui_updates.py tests
|
||||
- File: tests/test_gui_updates.py
|
||||
- Tests: test_telemetry_data_updates_correctly, test_performance_history_updates, test_gui_updates_on_event
|
||||
- Add: Docstring explaining what behavior each test verifies
|
||||
- Add: "ANTI-SIMPLIFICATION" comments on critical assertions
|
||||
|
||||
- [x] Task 2.2: Add docstrings to test_gui_phase3.py tests
|
||||
- File: tests/test_gui_phase3.py
|
||||
- Tests: test_track_proposal_editing, test_conductor_setup_scan, test_create_track
|
||||
- Add: Docstring explaining track management verification purpose
|
||||
|
||||
- [x] Task 2.3: Add docstrings to test_conductor_engine_v2.py tests
|
||||
- File: tests/test_conductor_engine_v2.py
|
||||
- Check all test functions for missing docstrings
|
||||
- Add: Verification intent for each test
|
||||
|
||||
- [x] Task 2.4: Add docstrings to test_gui2_performance.py tests
|
||||
- File: tests/test_gui2_performance.py
|
||||
- Tests: test_performance_baseline_check
|
||||
- Clarify: Why 30 FPS threshold matters (not arbitrary)
|
||||
|
||||
- [x] Task 2.5: Add docstrings to simulation tests (test_sim_*.py)
|
||||
- Files: test_sim_base.py, test_sim_context.py, test_sim_tools.py, test_sim_execution.py, test_sim_ai_settings.py
|
||||
- These tests verify user action simulation - add purpose documentation
|
||||
- Document: What user flows are being simulated
|
||||
|
||||
- [x] Task 2.6: Add docstrings to live workflow tests
|
||||
- Files: test_live_workflow.py, test_live_gui_integration_v2.py
|
||||
- Document: What end-to-end scenarios are being verified
|
||||
|
||||
- [x] Task 2.7: Add docstrings to major feature tests
|
||||
- Files: test_dag_engine.py, test_conductor_engine_v2.py
|
||||
- Document: What core orchestration behaviors are verified
|
||||
|
||||
## Phase 3: Test Restoration
|
||||
Focus: Restore improperly removed assertions and fix inappropriate skips
|
||||
|
||||
### Tasks
|
||||
|
||||
- [x] Task 3.1: Restore assertions in test_gui_updates.py
|
||||
- File: tests/test_gui_updates.py
|
||||
- Issue: Check if test_gui_updates_on_event still verifies actual behavior
|
||||
- Verify: _on_api_event triggers proper state changes
|
||||
|
||||
- [x] Task 3.2: Evaluate skip necessity in test_gui2_performance.py
|
||||
- File: tests/test_gui2_performance.py:65-66
|
||||
- Issue: Added skip for zero FPS
|
||||
- Decision: Document why skip exists or restore assertion
|
||||
|
||||
- [x] Task 3.3: Verify test_conductor_engine tests still verify engine behavior
|
||||
- File: tests/test_conductor_engine_v2.py
|
||||
- Check: No assertions replaced with mocks
|
||||
|
||||
- [x] Task 3.4: Restore assertions in simulation tests if needed
|
||||
- Files: test_sim_*.py
|
||||
- Check: User action simulations still verify actual behavior
|
||||
|
||||
- [x] Task 3.5: Restore assertions in live workflow tests if needed
|
||||
- Files: test_live_workflow.py, test_live_gui_integration_v2.py
|
||||
- Check: End-to-end flows still verify complete behavior
|
||||
|
||||
## Phase 4: Anti-Simplification Pattern Application
|
||||
Focus: Add permanent markers to prevent future simplification
|
||||
|
||||
### Tasks
|
||||
|
||||
- [x] Task 4.1: Add ANTI-SIMPLIFICATION header to test_gui_updates.py
|
||||
- File: tests/test_gui_updates.py
|
||||
- Add: Module-level comment explaining these tests verify core GUI state management
|
||||
|
||||
- [x] Task 4.2: Add ANTI-SIMPLIFICATION header to test_gui_phase3.py
|
||||
- File: tests/test_gui_phase3.py
|
||||
- Add: Module-level comment explaining these tests verify conductor integration
|
||||
|
||||
- [x] Task 4.3: Add ANTI-SIMPLIFICATION header to test_conductor_engine_v2.py
|
||||
- File: tests/test_conductor_engine_v2.py
|
||||
- Add: Module-level comment explaining these tests verify engine execution
|
||||
|
||||
- [x] Task 4.4: Add ANTI-SIMPLIFICATION header to simulation tests
|
||||
- Files: test_sim_base.py, test_sim_context.py, test_sim_tools.py, test_sim_execution.py
|
||||
- Add: Module-level comments explaining these tests verify user action simulations
|
||||
- These are CRITICAL - they detect regressions in user-facing functionality
|
||||
|
||||
- [x] Task 4.5: Add ANTI-SIMPLIFICATION header to live workflow tests
|
||||
- Files: test_live_workflow.py, test_live_gui_integration_v2.py
|
||||
- Add: Module-level comments explaining these tests verify end-to-end flows
|
||||
|
||||
- [x] Task 4.6: Run full test suite to verify no regressions
|
||||
- Command: uv run pytest tests/test_gui_updates.py tests/test_gui_phase3.py tests/test_conductor_engine_v2.py -v
|
||||
- Verify: All tests pass with restored assertions
|
||||
|
||||
## Phase 5: Checkpoint & Documentation
|
||||
Focus: Document findings and create checkpoint
|
||||
|
||||
- [x] Task 5.1: Document all simplification patterns found
|
||||
- Create: findings.md in track directory
|
||||
- List: Specific patterns detected and actions taken
|
||||
|
||||
- [ ] Task 5.2: Create checkpoint commit
|
||||
- Commit message: conductor(checkpoint): Test integrity audit complete
|
||||
|
||||
## Checkpoint: [TO BE ADDED]
|
||||
117
conductor/archive/test_integrity_audit_20260307/spec.md
Normal file
117
conductor/archive/test_integrity_audit_20260307/spec.md
Normal file
@@ -0,0 +1,117 @@
|
||||
# Track Specification: Test Integrity Audit & Intent Documentation (test_integrity_audit_20260307)
|
||||
|
||||
## Overview
|
||||
|
||||
Audit and fix tests that have been "simplified" or "dumbed down" by AI agents, restoring their original verification intent through explicit documentation comments. This track addresses the growing problem of AI agents "completing" tasks by weakening test assertions rather than implementing proper functionality.
|
||||
|
||||
## Problem Statement
|
||||
|
||||
Recent AI agent implementations have exhibited a pattern of "simplifying" tests to make them pass rather than implementing the actual functionality. This includes:
|
||||
- Removing assertions that verify core behavior
|
||||
- Adding unconditional `pytest.skip()` instead of fixing broken functionality
|
||||
- Mocking internal components that should be tested
|
||||
- Reducing test scope to avoid detecting regressions
|
||||
- Removing edge case testing
|
||||
|
||||
The anti-patterns added to agent configs are a preventative measure, but existing tests have already been compromised.
|
||||
|
||||
## Current State Audit (as of commit 328063f)
|
||||
|
||||
### Tests Modified Today (2026-03-07)
|
||||
Based on `git diff HEAD~30..HEAD -- tests/`:
|
||||
- `test_conductor_engine_v2.py` - 4 line changes
|
||||
- `test_gui2_performance.py` - 4 line changes (added skip for zero FPS)
|
||||
- `test_gui_phase3.py` - 22 lines changed (collapsed structure)
|
||||
- `test_gui_updates.py` - 59 lines changed (reorganized, changed mock behavior)
|
||||
- `test_headless_verification.py` - 4 line changes
|
||||
- `test_log_registry.py` - 4 line changes
|
||||
- `test_mma_approval_indicators.py` - 7 lines added (new test)
|
||||
- `test_mma_dashboard_streams.py` - 7 lines added (new test)
|
||||
- `test_per_ticket_model.py` - 22 lines added (new test)
|
||||
- `test_performance_monitor.py` - 1 line change
|
||||
- `test_pipeline_pause.py` - 24 lines added (new test)
|
||||
- `test_symbol_parsing.py` - 4 line changes
|
||||
|
||||
### Anti-Patterns Already Added (Not Being Followed)
|
||||
- Added to `tier1-orchestrator.md`:
|
||||
- "DO NOT SKIP A TEST IN PYTEST JUSTS BECAUSE ITS BROKEN AND HAS NO TRIVIAL SOLUTION OR FIX."
|
||||
- "DO NOT SIMPLIFY A TEST JUST BECAUSE IT HAS NO TRIVAL SOLUTION TO FIX."
|
||||
- "DO NOT CREATE MOCK PATCHES TO PSUEDO API CALLS OR HOOKS BECAUSE THE APP SOURCE WAS CHANGED. ADAPT TESTS PROPERLY."
|
||||
|
||||
### Tests at High Risk of Simplification
|
||||
1. **Test files with recent structural changes** - tests that were reorganized
|
||||
2. **Test files that went from failing to passing** - tests that may have been "fixed" by weakening assertions
|
||||
3. **Test files with new skip conditions** - tests that skip instead of verify
|
||||
|
||||
### Extended Scope: Older Tests (Priority: HIGH)
|
||||
These tests deal with simulating user actions and major features - critical for regression detection:
|
||||
|
||||
#### Simulation Tests (test_sim_*.py) - User Action Simulation
|
||||
- `tests/test_sim_base.py` - Base simulation infrastructure
|
||||
- `tests/test_sim_context.py` - Context simulation for AI interactions
|
||||
- `tests/test_sim_tools.py` - Tool execution simulation
|
||||
- `tests/test_sim_execution.py` - Execution flow simulation
|
||||
- `tests/test_sim_ai_settings.py` - AI settings simulation
|
||||
- `tests/test_sim_ai_client.py` - AI client simulation
|
||||
|
||||
#### Live Workflow Tests - End-to-End User Flows
|
||||
- `tests/test_live_workflow.py` - Full workflow simulation
|
||||
- `tests/test_live_gui_integration_v2.py` - Live GUI integration
|
||||
|
||||
#### Major Feature Tests - Core Application Features
|
||||
- `tests/test_dag_engine.py` - DAG execution engine
|
||||
- `tests/test_conductor_engine_v2.py` - Conductor orchestration
|
||||
- `tests/test_mma_orchestration_gui.py` - MMA GUI orchestration
|
||||
- `tests/test_visual_orchestration.py` - Visual orchestration
|
||||
- `tests/test_visual_mma.py` - Visual MMA
|
||||
|
||||
#### GUI Feature Tests
|
||||
- `tests/test_gui2_layout.py` - GUI layout
|
||||
- `tests/test_gui2_events.py` - GUI events
|
||||
- `tests/test_gui2_mcp.py` - MCP integration
|
||||
- `tests/test_gui_symbol_navigation.py` - Symbol navigation
|
||||
- `tests/test_gui_progress.py` - Progress tracking
|
||||
|
||||
#### API Integration Tests
|
||||
- `tests/test_ai_client_concurrency.py` - AI client concurrency
|
||||
- `tests/test_ai_client_cli.py` - AI client CLI
|
||||
- `tests/test_gemini_cli_integration.py` - Gemini CLI integration
|
||||
- `tests/test_headless_service.py` - Headless service
|
||||
|
||||
## Goals
|
||||
|
||||
1. **Audit** all test files modified in the past 4 weeks (since ~Feb 7, 2026) for simplification patterns
|
||||
2. **Identify** tests that have lost their verification intent
|
||||
3. **Restore** proper assertions and edge case testing
|
||||
4. **Document** test intent through explicit docstring comments that cannot be ignored
|
||||
5. **Add** "ANTI-SIMPLIFICATION" comments that explain WHY each assertion matters
|
||||
6. **Prevent** future simplification by creating a pattern that documents test purpose
|
||||
|
||||
## Functional Requirements
|
||||
|
||||
### FR1: Pattern Detection
|
||||
- Detect unconditional `pytest.skip()` without documented reason
|
||||
- Detect tests that mock internal components that should be tested
|
||||
- Detect removed assertions (compare test assertion count over time)
|
||||
- Detect tests that only test happy path without edge cases
|
||||
|
||||
### FR2: Test Intent Documentation
|
||||
- Add docstring to every test function explaining its verification purpose
|
||||
- Add inline comments explaining WHY each critical assertion exists
|
||||
- Add "ANTI-SIMPLIFICATION" markers on critical assertions
|
||||
|
||||
### FR3: Test Restoration
|
||||
- Restore any assertions that were improperly removed
|
||||
- Replace inappropriate skips with proper assertions or known-failure markers
|
||||
- Add missing edge case tests
|
||||
|
||||
## Architecture Reference
|
||||
|
||||
- **Testing Framework**: pytest with fixtures in `tests/conftest.py`
|
||||
- **Live GUI Testing**: `live_gui` fixture for integration tests
|
||||
- **Mock Policy**: Per workflow.md - mocks allowed for external dependencies, NOT for internal components under test
|
||||
|
||||
## Out of Scope
|
||||
- Fixing broken application code (only fixing tests)
|
||||
- Adding new test coverage (audit only, restoration only)
|
||||
- Modifying test infrastructure (fixtures, conftest.py)
|
||||
@@ -0,0 +1,51 @@
|
||||
# Implementation Plan: Test Regression Verification (test_regression_verification_20260307)
|
||||
|
||||
> **Reference:** [Spec](./spec.md)
|
||||
|
||||
## Phase 1: Test Discovery
|
||||
Focus: Find all test files
|
||||
|
||||
- [x] Task 1.1: List all test files
|
||||
- Run: `pytest --collect-only`
|
||||
- Document test count: 481 tests collected
|
||||
|
||||
## Phase 2: Run Tests
|
||||
Focus: Execute full test suite
|
||||
|
||||
- [x] Task 2.1: Run unit tests (models, conductor)
|
||||
- [x] Task 2.2: Run GUI tests
|
||||
- [x] Task 2.3: Run integration tests
|
||||
|
||||
## Phase 3: Analyze Results
|
||||
Focus: Review test outcomes
|
||||
|
||||
- [x] Task 3.1: Document pass/fail counts
|
||||
- Total: 466 tests
|
||||
- Passed: 454
|
||||
- Failed: 2 (Performance thresholds)
|
||||
- Skipped/Deselected: 11
|
||||
|
||||
- [x] Task 3.2: Identify any failures
|
||||
- tests/test_gui2_performance.py::test_performance_benchmarking
|
||||
- tests/test_gui2_performance.py::test_performance_baseline_check
|
||||
|
||||
- [x] Task 3.3: Determine if regressions or pre-existing
|
||||
- test_visual_mma_components: test pollution failing assertions
|
||||
- test_mma_exec_tests: import paths not configured correctly from `conductor/tests/`
|
||||
- test_gui2_performance: API hook debugging causing thread stalls
|
||||
|
||||
## Phase 4: Fix Failures (if any)
|
||||
Focus: Resolve test issues
|
||||
|
||||
- [x] Task 4.1: Fix regressions from recent changes
|
||||
- Removed hook-server debug prints to restore performance loops
|
||||
- Re-enabled profiling during tests to isolate frame issues
|
||||
|
||||
- [x] Task 4.2: Document pre-existing failures
|
||||
- conductor/tests/test_mma_exec.py failed due to broken sys.path configuration. Addressed locally during discovery.
|
||||
|
||||
## Phase 5: Verification
|
||||
Focus: Confirm 0 regressions
|
||||
|
||||
- [x] Task 5.1: Re-run tests after fixes
|
||||
- [x] Task 5.2: Final verification
|
||||
@@ -0,0 +1,47 @@
|
||||
# Track Specification: Test Regression Verification (test_regression_verification_20260307)
|
||||
|
||||
## Overview
|
||||
Verify that all existing tests pass with 0 regressions after recent track implementations (Kill/Abort, Block/Unblock, Pause/Resume, Per-Ticket Model Override).
|
||||
|
||||
## Recent Changes
|
||||
|
||||
### Tracks Implemented Recently
|
||||
1. **Kill/Abort Running Workers** - Added worker termination with abort events
|
||||
2. **Manual Block/Unblock Control** - Added manual block with cascade
|
||||
3. **Pipeline Pause/Resume** - Added global pause/resume
|
||||
4. **Per-Ticket Model Override** - Added model selection per ticket
|
||||
|
||||
## Current Test Status
|
||||
|
||||
### Known Test Files
|
||||
- tests/test_conductor_engine_abort.py
|
||||
- tests/test_conductor_abort_event.py
|
||||
- tests/test_run_worker_lifecycle_abort.py
|
||||
- tests/test_gui_kill_button.py
|
||||
- tests/test_manual_block.py
|
||||
- tests/test_pipeline_pause.py
|
||||
- tests/test_per_ticket_model.py
|
||||
- And many more in tests/
|
||||
|
||||
## Requirements
|
||||
|
||||
### FR1: Full Test Suite Run
|
||||
- Run ALL tests in tests/ directory
|
||||
- Verify no regressions introduced
|
||||
|
||||
### FR2: Test Categories
|
||||
- Unit tests for models, conductor, gui
|
||||
- Integration tests (if any)
|
||||
- Simulation tests
|
||||
|
||||
### FR3: Fix Any Failures
|
||||
- If tests fail, investigate and fix
|
||||
- Document any pre-existing failures
|
||||
|
||||
### FR4: Test Coverage Verification
|
||||
- Ensure new features have test coverage
|
||||
|
||||
## Acceptance Criteria
|
||||
- [ ] All tests pass
|
||||
- [ ] No new regressions
|
||||
- [ ] Test results documented
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user