Private
Public Access
0
0
Commit Graph

4995 Commits

Author SHA1 Message Date
ed 39fcf12a6b archive: post-module taxonomy de cruft 2026-07-05 15:56:10 -04:00
ed f7136c5fff archive: phase2_4_5 call site completion 2026-07-05 15:55:59 -04:00
ed 3493a95144 archive: cruft elimination 2026-07-05 15:55:41 -04:00
ed 5d060a477d archive: fable review 2026-07-05 15:55:30 -04:00
ed aacfb1ff56 archive: context preview fixes 2026-07-05 15:54:39 -04:00
ed f619e05021 archive public api migration 2026-07-05 15:54:28 -04:00
ed fe10892d48 archive: superpowers review tracks 2026-07-05 15:54:18 -04:00
ed 8c98a3bc42 archive: code path audit polish. 2026-07-05 15:53:43 -04:00
ed 1eac425287 archive: tier 2 leak prevention 2026-07-05 15:53:28 -04:00
ed eb5cc68b51 archive: agent directives consolidation 2026-07-05 15:53:17 -04:00
ed 01a12d6eaf archive: type alias unfuck 2026-07-05 15:53:03 -04:00
ed 3512708edc conductor(tracks): mark agent_directives_consolidation_20260705 as Completed (row 23d) 2026-07-05 15:21:36 -04:00
ed 8ab8202257 conductor(track): agent_directives_consolidation_20260705 state.toml finalized (current_phase=4, all tasks completed) 2026-07-05 15:21:26 -04:00
ed 4c3f989257 refactor(conductor/product-guidelines.md): thin-pointer §Data Structure Conventions to type_aliases.md
Per agent_directives_consolidation_20260705 §3.4.

The 14-line §Data Structure Conventions section (the 'names for shapes'
pattern intro + the 16-alias list + canonical reference) is replaced
with a 1-line pointer to conductor/code_styleguides/type_aliases.md,
the canonical home for the 10 TypeAlias definitions + 11 per-aggregate
dataclasses + 5-pattern decision tree.

Net: 14 lines reduced to 1 line of pointer. The type-registry
auto-generation note (docs/type_registry/) is preserved as unique
project information.

Phase 3.2, 3.3, 3.4 all complete in this single commit batch.
2026-07-05 15:20:16 -04:00
ed 8996a3c92d refactor(conductor/product-guidelines.md): thin-pointer §Data-Oriented Error Handling to error_handling.md
Per agent_directives_consolidation_20260705 §3.4.

The 30-line §Data-Oriented Error Handling section (key principles +
incremental rollout plan + audit-script enforcement) is replaced with
a 1-line pointer to conductor/code_styleguides/error_handling.md, the
canonical home for the Result[T] + NIL_T convention.

Net: 30 lines reduced to 1 line. Duplicate content removed; the
canonical styleguide remains the source of truth.
2026-07-05 15:19:50 -04:00
ed 8ac3385a56 refactor(conductor/product-guidelines.md): thin-pointer §AI-Optimized Compact Style Indentation + Newlines to python.md
Per agent_directives_consolidation_20260705 §3.4.

The 2 duplicate bullets (Indentation, Newlines) are replaced with a
1-line pointer to conductor/code_styleguides/python.md §1, the
canonical home for Python style. The 4 project-specific bullets
(Vertical Compaction, Region Blocks, Type Hinting, SDM) are
preserved — they are unique to this project.

Net: 6 lines reduced to 1 line of pointer + 4 preserved bullets.
2026-07-05 15:19:24 -04:00
ed 3a47dede4b refactor(conductor/edit_workflow.md): thin-pointer §9 to conductor/code_styleguides/python.md
Per agent_directives_consolidation_20260705 §3.3.

The 9-line §9 'No Diagnostic Noise in Production Code' section is
replaced with a 1-line pointer to the canonical home in
conductor/code_styleguides/python.md §AI-Agent Specific Conventions.

Net: 9 lines reduced to 1 line. Duplicate content removed; the
canonical styleguide remains the source of truth.
2026-07-05 15:18:01 -04:00
ed fa0ba73035 refactor(conductor/workflow.md): promote §Process Anti-Patterns to canonical home
Per agent_directives_consolidation_20260705 §3.2.

The 14-line abridged §Process Anti-Patterns section (1-line summaries per
pattern) is promoted to the full canonical home: each of the 8 anti-patterns
now has the full Symptom + Rule content matching what was previously in
AGENTS.md. The 9th item (Workspace-Path Drift Pattern) was already
present here and is preserved.

AGENTS.md §Process Anti-Patterns is now a thin index pointing here
(per the previous commit in Phase 1.3). The canonical home for the full
process anti-pattern content is now conductor/workflow.md.

Net: 14 lines expanded to 80 lines (canonical expansion). 9 items
with full Symptom + Rule content. The 8 anti-patterns are now
locally accessible from the operational workflow file where they're
most actionable.
2026-07-05 15:17:07 -04:00
ed e9ae8cc459 refactor(conductor/workflow.md): thin-pointer §Known Pitfalls to AGENTS.md
Per agent_directives_consolidation_20260705 §3.2.

The 25-line §Known Pitfalls section (the git restore/git checkout/git
reset hard ban with full rationale + correct non-destructive inspection
pattern) is replaced with a thin pointer to AGENTS.md §Critical Anti-Patterns,
the canonical project-wide home for HARD BANs.

Net: 25 lines reduced to 7 lines (72% reduction). The full content
remains in AGENTS.md where the 4 canonical HARD BANs are documented.
2026-07-05 15:16:06 -04:00
ed 3470629ef6 refactor(AGENTS.md): thin-index §Process Anti-Patterns to conductor/workflow.md
Per agent_directives_consolidation_20260705 §3.1.

The 8 anti-patterns (Deduction Loop, Report-Instead-of-Fix, Scope-Creep
Track-Doc, Inherited-Cruft, No Diagnostic Noise, Surrender, Verbose-Commit-
Message, Isolated Pass Verification Fallacy) are now 1-line summaries
with a pointer to conductor/workflow.md §Process Anti-Patterns, which
becomes the canonical home for these rules.

Net: 70 lines reduced to 13 lines (81% reduction). The full Symptom + Rule
content remains in conductor/workflow.md where it will be promoted to
canonical in Phase 2.2 of this track.
2026-07-05 15:15:13 -04:00
ed 8a560cc627 refactor(AGENTS.md): thin-index §Session-Learned Anti-Patterns to conductor/edit_workflow.md
Per agent_directives_consolidation_20260705 §3.1.

The 5 items (ALWAYS use proper edit tool, decorator-orphan pitfall,
ast.parse is not enough, git status trap, small edits beat big scripts)
are now 1-line pointers to conductor/edit_workflow.md, which is the
canonical home for edit-tool lessons-learned (per its §1, §6, §7).

Net: 30 lines reduced to 7 lines (76% reduction in section size).
Duplicate content removed; conductor/edit_workflow.md remains the
canonical source for these rules.
2026-07-05 15:14:13 -04:00
ed 2d2d88fb81 refactor(AGENTS.md): thin-index §Critical Anti-Patterns to canonical styleguides
Per agent_directives_consolidation_20260705 §3.1.

The 9 duplicated items (read full files, modify tech stack, skip TDD, skip
markers, batch commits, no comments, set_file_slice, git restore caveat)
are now 1-line summaries + pointers to the canonical homes:
- conductor/code_styleguides/python.md (LLM Default Anti-Patterns §17)
- conductor/code_styleguides/data_oriented_design.md §8.5 (Python
  Type Promotion Mandate)
- conductor/edit_workflow.md (the edit tool contract)
- conductor/workflow.md §Known Pitfalls + Skip-Marker Policy

The 4 canonical HARD BANs (git restore / git checkout / git reset;
git stash*; day estimates; opaque types) remain inline as they are the
project-wide rules with no single canonical home. Each HARD BAN now
points to its technical mandate for the full rationale.

Net effect: AGENTS.md §Critical Anti-Patterns reduced from 14-line
section with 13 mixed items to 19-line section with 4 HARD BANs + a thin
index. The duplicated content is now in the canonical styleguides where it
belongs; the 4 HARD BANs are deduplicated to their one proper home here.
2026-07-05 15:13:21 -04:00
ed 4e882e15fa conductor(tracks): register agent_directives_consolidation_20260705 in tracks.md (row 23d) 2026-07-05 15:12:02 -04:00
ed 48ddd15ca2 conductor(track): init agent_directives_consolidation_20260705 (spec + state) 2026-07-05 15:11:37 -04:00
ed 38430fd312 restore: re-add .opencode/ directory (OpenCode agent + command starters)
Restores the 20 tracked files deleted in commit f63769ac.
The user clarified that the .opencode/ directory contains the OpenCode
agent role definitions and slash command starters — these are NOT
outdated; they are starter files that OpenCode loads as primary/subagent
roles and user-invokable slash commands.

The .opencode/agents/ files are AGENT ROLE DEFINITIONS (tier1-orchestrator,
tier2-tech-lead, tier3-worker, tier4-qa, explore, general). OpenCode loads
these as primary/subagent roles.

The .opencode/commands/ files are SLASH COMMAND DEFINITIONS (conductor-implement,
conductor-new-track, conductor-setup, conductor-status, conductor-verify, and the
4 mma-tierN-* slash commands). OpenCode surfaces these as user-invokable commands.

These are NOT equivalent to .agents/skills/mma-*/SKILL.md (skill definitions
loaded on-demand via the Skill tool). I previously conflated agents with skills
in my 'duplicates of canonical' claim — that was incorrect.

Restoration method (per AGENTS.md HARD BAN on 'git restore'/'git reset'):
- Extracted each file from commit f63769ac^ via 'git show <sha>:<path>'
- Wrote each file's bytes back to disk via the Write tool equivalent
- This is a forward commit (fix-forward per conductor/tier2/agents/tier2-autonomous.md
  'timeline-is-immutable' principle); git history preserved.

f63769ac remains in history for forensics; this commit supersedes it.
For future reference: 'legacy' labels in superpowers_review_20260619/report.md §16.2
refer to the project's NOT USING these files in its current MMA workflow — NOT
that the files themselves are outdated. They remain starter templates for OpenCode.
2026-07-05 14:38:17 -04:00
ed 887589d1bc docs(specs): add directive preset system design + implementation plan 2026-07-05 14:36:33 -04:00
ed f63769ac1a cleanup: remove legacy .opencode/ directory (18 agent/command .md files + package.json + package-lock.json)
Per user directive 'review all the traditional aggregate directive markdown
prompts in the codebase tailored for agents and see if they have redundant
directives... lets do a clean pass on them' (2026-07-05).

REDUNDANT DIRECTIVES REMOVED:
- All 18 files in .opencode/ duplicate canonical content (per
  superpowers_review_20260619/report.md §16.2 'Legacy .opencode/ and
  .gemini/ directories' documented the directory as legacy).
- 10 agent files (.opencode/agents/*.md) duplicate .agents/skills/mma-*/
  SKILL.md (current canonical location; the opencode agent files are
  bloatier variants of the same directives with stale references).
- 8 command files (.opencode/commands/*.md) are legacy Gemini CLI slash
  commands; OpenCode does not use them.

CANONICAL LOCATIONS (UNTOUCHED):
- .agents/skills/mma-orchestrator/SKILL.md
- .agents/skills/mma-tier1-orchestrator/SKILL.md
- .agents/skills/mma-tier2-tech-lead/SKILL.md
- .agents/skills/mma-tier3-worker/SKILL.md
- .agents/skills/mma-tier4-qa/SKILL.md
- conductor/tier2/agents/tier2-autonomous.md (Tier 2 sandbox canonical)
- conductor/tier2/agents/tier2-autonomous.warm.md (Tier 2 sandbox warm)
- .opencode/node_modules/ was already gitignored (npm install artifact)

PRESERVED REDUNDANCIES (audit found, kept intentionally):
- AGENTS.md + conductor/workflow.md + .agents/skills/mma-tier2-tech-lead/
  SKILL.md + conductor/tier2/agents/tier2-autonomous.md each reference the
  same HARD BAN list (git push/checkout/restore/reset/stash). Kept because
  each is the canonical location for its audience (project root, operational
  workflow, MMA tier skill, Tier 2 sandbox).
- conductor/tier2/agents/tier2-autonomous.md (174 lines) is a SUPERSET of
  .opencode/agents/tier2-tech-lead.md (254 lines) with sandbox-specific
  operational contracts. Both are valid for their target audience.

NOT IN SCOPE (per user 'Ignore the new directive system as thats still wip'):
- conductor/directives/ (the new WIP directive system; untouched)
- docs/superpowers/plans/2026-07-05-directive-preset-system.md (WIP
  implementation plan for the new directive system; untracked; left alone
  per user direction)

VERIFICATION:
- All 20 tracked files in .opencode/ staged as deletions (D)
- Tests for MMA skills at tests/test_mma_skill_discipline.py still pass
- conductor/workflow.md Session Start Checklist unchanged
- .agents/skills/mma-*/SKILL.md files unchanged
2026-07-05 14:34:56 -04:00
ed ad8ba4d001 feat(tier2): update setup_tier2_clone_directives.ps1 default preset to tier2_autonomous.md 2026-07-05 14:34:27 -04:00
ed ef0ba85e7b cruft cleanup part 3 2026-07-05 14:33:46 -04:00
ed 053f28b633 refactor(tier2): dedup tier2-autonomous.warm.md — strip inline sections covered by directives 2026-07-05 14:24:23 -04:00
ed 7c02fd3625 docs(directives): mark current_baseline.md deprecated (retained as control group) 2026-07-05 14:23:30 -04:00
ed 6c94405e21 feat(directives): add 12 engagement presets (audit, fix_tests, implement_feature, refactor, new_script_tool, meta_tooling, directives_curation, documentation, media_analysis, ideation, tier2_autonomous) 2026-07-05 14:22:51 -04:00
ed 0c4a7621d4 feat(directives): add 15 engagement-specific directives + tags.toml entries 2026-07-05 14:17:51 -04:00
ed 9434e4c6e9 conductor(track): superpowers_review_apply_high_20260705 state.toml finalized (current_phase=3) 2026-07-05 14:17:21 -04:00
ed ee3eee6955 conductor(tracks): register superpowers_review_apply_high_20260705 as Completed 2026-07-05 14:17:00 -04:00
ed b2ca7a0e1b feat(directives): add curated baseline.md preset (57 BASELINE + 4 non-directive context) 2026-07-05 14:16:27 -04:00
ed 5037f48fcc conductor(workflow): add cross-reference to tests/test_mma_skill_discipline.py in §1
Per superpowers_review_apply_high_20260705 plan.md §3.3 + spec.md §3.2.

The §1 'Active Model Switching' section now includes a pointer to the
MMA skill discipline tests so future agents know the tests exist
and can extend them when extending the MMA skills themselves.
2026-07-05 14:15:58 -04:00
ed 670a919e4e test(mma-skills): add pressure-scenario + rule-coverage tests for 5 MMA skills (25 cases)
Closes recommendation #2 from superpowers_review_20260619/decisions.md (HIGH-priority).

5 test classes (one per MMA skill): TestMmaOrchestrator, TestMmaTier1Orchestrator,
TestMmaTier2TechLead, TestMmaTier3Worker, TestMmaTier4Qa.

Each test class has 5 tests (3 pressure scenarios + 2 rule-coverage assertions)
per the superpowers writing-skills skill's Discipline-Enforcing Skills
testing methodology (see C:\Users\Ed\.cache\opencode\packages\superpowers@...
\skills\writing-skills\SKILL.md §'Testing All Skill Types').

Tests are pure static-analysis of skill documents:
- Reads .agents/skills/<skill>/SKILL.md via pathlib + regex
- No live_gui dependency, no MMA execution, no sub-agent dispatches
- Run time: 3.26s for all 25 tests
- Failure mode: if a load-bearing rule is buried in prose or absent, test fails
  with a clear message naming the missing rule + why it matters

Rule coverage:
- mma-orchestrator: Surgical Spec Protocol, Pre-Delegation Checkpoint,
  Persistent Tier 2 Memory, failure_count escalation, Architecture Fallback
- mma-tier1-orchestrator: Audit-before-specifying, Spec-gaps-not-features,
  Worker-Ready Tasks, Root Cause Analysis, Reference docs
- mma-tier2-tech-lead: Atomic Per-Task Commits, TDD Enforcement,
  Persistent Context, Anti-Entropy State Audit, Surgical Delegation
- mma-tier3-worker: TDD Mandatory Enforcement, No Architectural Decisions,
  No Unrelated File Modifications, Stateless Operation, Skeleton Views
- mma-tier4-qa: Stateless Operation, No Fix Implementation, Brief Output,
  Root Cause Analysis, Diagnostic Tools

Refs:
- superpowers_review_20260619/decisions.md #2 (HIGH-priority)
- conductor/tracks/superpowers_review_apply_high_20260705/spec.md §3.2
- superpowers writing-skills skill §Testing All Skill Types
2026-07-05 14:15:16 -04:00
ed 7d90518627 test(aggregate): add integration tests for non-directive context in aggregate output 2026-07-05 14:15:13 -04:00
ed 82468611ba feat(aggregate): add Inherits resolution + Non-directive context to preset parser 2026-07-05 14:14:22 -04:00
ed 26dd92581c conductor(workflow): add Session Start Checklist items 1-13 (spec-first mandatory is item 13)
Per HIGH-priority recommendation #1 from superpowers_review_20260619/decisions.md.

The Session Start Checklist section previously had the header but no items
(per superpowers_review §2.4 the section was referenced everywhere as a
12-item list but no items appeared in workflow.md). This commit backfills
the canonical 12-item list (per superpowers_review §2.2 and AGENTS.md)
AND adds item 13 making the spec-first discipline explicit for ad-hoc
edits (per the brainstorming skill's HARD-GATE).

Refs:
- superpowers_review_20260619/report.md §2 (PARTIAL+INTEGRATE-PARTIAL)
- superpowers_review_20260619/decisions.md #1 (HIGH-priority)
- conductor/tracks/superpowers_review_apply_high_20260705/spec.md §3.1
2026-07-05 14:14:04 -04:00
ed 98b6d808dc conductor(tracks): register superpowers_review_apply_high_20260705 in tracks.md (row 23c) 2026-07-05 14:11:14 -04:00
ed 0522252f3d conductor(track): init superpowers_review_apply_high_20260705 (spec + plan + metadata + state) 2026-07-05 14:10:50 -04:00
ed 06898ca5a6 cleaning cruft part 2 2026-07-05 14:08:03 -04:00
ed 508baa69b6 conductor(archive): move legacy superpowers specs/plans from docs/superpowers/ to conductor/archive/superpowers/
Resolves HIGH-priority recommendation #3 from superpowers_review_20260619 §16.1 (dual-convention).
41 files moved (21 specs + 20 plans + 2 subdirs + root):
- docs/superpowers/specs/*.md  ->  conductor/archive/superpowers/specs/*.md (21 files)
- docs/superpowers/plans/*.md  ->  conductor/archive/superpowers/plans/*.md (20 files)

Original taxonomy preserved (specs/ and plans/ subdirectories intact).
The superpowers-plugin source itself remains at C:/Users/Ed/.cache/opencode/.../superpowers/skills/.

Future spec/plan artifacts must use the conductor convention: conductor/tracks/<id>/spec.md + plan.md.
2026-07-05 13:57:53 -04:00
ed 137868a193 conductor(track): superpowers review Phase 10 finalize complete (all tasks done; state.toml final) 2026-07-05 13:47:36 -04:00
ed d795327901 conductor(track): superpowers review metadata.json finalized (status=shipped + final_statistics) 2026-07-05 13:47:00 -04:00
ed 27f2c25f1c codebase: cleaning cruft part 1 2026-07-05 13:46:35 -04:00
ed deae250019 conductor(tracks): register superpowers_review_20260619 as Completed (Phase 10 finalize) 2026-07-05 13:46:04 -04:00
ed deecd9314c conductor(track): superpowers review state.toml finalized (current_phase=10) 2026-07-05 13:45:39 -04:00