conductor(plan): Mark Task 3.1 complete
This commit is contained in:
@@ -190,14 +190,14 @@ Next: rename in the top 5 test files individually (Phase 3)." <hash>
|
||||
- Modify: `tests/test_conductor_tech_lead.py` (8 refs)
|
||||
- Modify: `tests/test_orchestrator_pm_history.py` (4 refs)
|
||||
|
||||
### Task 3.1: Rename in `tests/test_conductor_engine_v2.py` (22 refs)
|
||||
### Task 3.1: Rename in `tests/test_conductor_engine_v2.py` (22 refs) [3e2b4f7]
|
||||
|
||||
- [ ] **Step 1: Verify the test file currently fails (red for this file)**
|
||||
- [x] **Step 1: Verify the test file currently fails (red for this file)**
|
||||
|
||||
Run: `uv run pytest tests/test_conductor_engine_v2.py 2>&1 | tail -3`
|
||||
Expected: all tests in this file fail with `send_result` AttributeError.
|
||||
|
||||
- [ ] **Step 2: Rename the 22 references**
|
||||
- [x] **Step 2: Rename the 22 references**
|
||||
|
||||
Run: `git grep -n "send_result" -- tests/test_conductor_engine_v2.py`
|
||||
Expected: 22 lines. For each:
|
||||
@@ -212,12 +212,12 @@ Use the MCP edit tool. The 22 refs in this file are mostly `monkeypatch.setattr(
|
||||
Verify: `git grep "send_result" -- tests/test_conductor_engine_v2.py`
|
||||
Expected: 0 matches.
|
||||
|
||||
- [ ] **Step 3: Run the test file — confirm green**
|
||||
- [x] **Step 3: Run the test file — confirm green**
|
||||
|
||||
Run: `uv run pytest tests/test_conductor_engine_v2.py 2>&1 | tail -3`
|
||||
Expected: all tests in this file pass.
|
||||
|
||||
- [ ] **Step 4: Commit**
|
||||
- [x] **Step 4: Commit**
|
||||
|
||||
```bash
|
||||
git add tests/test_conductor_engine_v2.py
|
||||
@@ -227,7 +227,7 @@ git commit -m "test(ai_client): rename send_result to send in test_conductor_eng
|
||||
Test file state: GREEN. All 22+ tests in this file now pass."
|
||||
```
|
||||
|
||||
- [ ] **Step 5: Attach the git note**
|
||||
- [x] **Step 5: Attach the git note**
|
||||
|
||||
```bash
|
||||
git notes add -m "Task 3.1: rename in test_conductor_engine_v2.py
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
"""Update plan.md for Task 3.1."""
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
PLAN = Path("conductor/tracks/send_result_to_send_20260616/plan.md")
|
||||
SHA = "3e2b4f7"
|
||||
|
||||
EDITS: list[tuple[str, str]] = [
|
||||
(
|
||||
"### Task 3.1: Rename in `tests/test_conductor_engine_v2.py` (22 refs)\n\n- [ ] **Step 1: Verify the test file currently fails (red for this file)**",
|
||||
f"### Task 3.1: Rename in `tests/test_conductor_engine_v2.py` (22 refs) [{SHA}]\n\n- [x] **Step 1: Verify the test file currently fails (red for this file)**",
|
||||
),
|
||||
("- [ ] **Step 2: Rename the 22 references**", "- [x] **Step 2: Rename the 22 references**"),
|
||||
("- [ ] **Step 3: Run the test file — confirm green**", "- [x] **Step 3: Run the test file — confirm green**"),
|
||||
("- [ ] **Step 4: Commit**", "- [x] **Step 4: Commit**"),
|
||||
("- [ ] **Step 5: Attach the git note**", "- [x] **Step 5: Attach the git note**"),
|
||||
]
|
||||
|
||||
|
||||
def main() -> int:
|
||||
with PLAN.open("r", encoding="utf-8", newline="") as f:
|
||||
content = f.read()
|
||||
has_crlf = "\r\n" in content
|
||||
nl = "\r\n" if has_crlf else "\n"
|
||||
normalized = [(o.replace("\n", nl), n.replace("\n", nl)) for o, n in EDITS]
|
||||
new_content = content
|
||||
applied = 0
|
||||
for old, new in normalized:
|
||||
if old in new_content:
|
||||
new_content = new_content.replace(old, new, 1)
|
||||
applied += 1
|
||||
else:
|
||||
print(f"NOT FOUND: {old[:80]!r}", file=sys.stderr)
|
||||
if applied != len(EDITS):
|
||||
print(f"Only applied {applied}/{len(EDITS)} edits.", file=sys.stderr)
|
||||
return 1
|
||||
with PLAN.open("w", encoding="utf-8", newline="") as f:
|
||||
f.write(new_content)
|
||||
print(f"Applied {applied}/{len(EDITS)} edits. Line endings: {'CRLF' if has_crlf else 'LF'}")
|
||||
return 0
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
raise SystemExit(main())
|
||||
Reference in New Issue
Block a user