Private
Public Access
conductor(plan): Mark Task 2.2 complete (5 callback sites migrated to Result)
Task 2.2: Migrated 5 INTERNAL_BROAD_CATCH sites in src/app_controller.py:
- _handle_custom_callback (L537)
- _handle_click (L579)
- cb_load_prior_log inner json.dumps (L2046)
- cb_load_prior_log inner datetime (L2068)
- cb_load_prior_log outer (L2081)
Note: spec listed 5 sites in Batch 1 (537, 579, 2046, 2068, 2081) - all migrated.
Refs: 6333e0e6
This commit is contained in:
@@ -110,6 +110,8 @@ Focus: the main migration work. 32 sites, organized into 4 sub-batches by contex
|
||||
- **COMMIT:** `test(app_controller): scaffold tests/test_app_controller_result.py with 5 Result-pattern tests`
|
||||
- **GIT NOTE:** The 5 tests use generic placeholders that become specific per migration in subsequent tasks. The scaffolding defines the pattern.
|
||||
|
||||
- [x] **Task 2.2: Migrate batch 1 — callback handlers (5 sites; spec says 4 + 1 nested in cb_load_prior_log)** [6333e0e6]
|
||||
|
||||
### Task 2.2: Migrate batch 1 — callback handlers (4 sites)
|
||||
- **WHERE:** `src/app_controller.py:537 (_handle_custom_callback)`, `:579 (_handle_click)`, `:2046 (cb_load_prior_log)`, `:2068 (cb_load_prior_log)`, `:2081 (cb_load_prior_log)`
|
||||
- **WHAT:** Convert `except Exception as e: pass` (or `print(...)`) to `except <SpecificException> as e: return Result(data=None, errors=[...])`. The callback may need to return a `Result`; if the caller doesn't use the return value, wrap the body in a `try/except` that returns a result and is logged.
|
||||
|
||||
@@ -34,7 +34,7 @@ t1_6 = { status = "pending", commit_sha = "", description = "Phase 1 checkpoint
|
||||
|
||||
# Phase 2: Migrate 32 INTERNAL_BROAD_CATCH sites
|
||||
t2_1 = { status = "completed", commit_sha = "142d0474", description = "Create tests/test_app_controller_result.py with 5 scaffolding tests (2 pass, 3 fail as migration targets)" }
|
||||
t2_2 = { status = "pending", commit_sha = "", description = "Migrate batch 1: 5 callback-handler sites (L537, L579, L2046, L2068, L2081)" }
|
||||
t2_2 = { status = "completed", commit_sha = "6333e0e6", description = "Migrate batch 1: 5 callback-handler sites (L537 _handle_custom_callback, L579 _handle_click, L2046/L2068/L2081 cb_load_prior_log inner+outer)" }
|
||||
t2_3 = { status = "pending", commit_sha = "", description = "Migrate batch 2: 6 project-op sites (L2129, L2140, L2154, L2195, L2890, L2944)" }
|
||||
t2_4 = { status = "pending", commit_sha = "", description = "Migrate batch 3: 8 conductor/track sites (L3057, L3084, L3094, L4237, L4349, L4446, L4475, L4504)" }
|
||||
t2_5 = { status = "pending", commit_sha = "", description = "Migrate batch 4: 11 worker/task sites (L3434, L3471, L3542, L3635, L3648, L4070, L4100, L1669, L1420, L1480, L1947)" }
|
||||
|
||||
Reference in New Issue
Block a user