ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

docs(todo): mark Tasks 4+5 as SHIPPED; note known batch hang issue

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-06-08 13:37:13 -04:00
parent b6972c31de
commit d09f70ea44
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO_test_full_live_workflow.md
+9 -9
View File
@@ -28,20 +28,20 @@
- **Why:** cwd-relative path is fragile; fixture-relative path is stable.
- **Acceptance:** Test does `temp_project_path = live_gui_temp_project_path` (or accesses it as a fixture attribute). No more `os.path.abspath("tests/artifacts/...")`.
### 4. [MED] Replace 10×1s blind poll with condition-based wait
- **What:** Use the new `/api/project_switch_status` endpoint with a single `wait_for_condition` call (or `client.wait_for_project_active(name, timeout=30)` helper).
- **Where:** `tests/test_live_workflow.py:58-65` + new `ApiHookClient.wait_for_project_active` method.
### 4. [MED] Replace 10×1s blind poll with condition-based wait ✅ SHIPPED (commits a6605d98 + b6972c31)
- **What:** Use the new `/api/project_switch_status` endpoint with `client.wait_for_project_switch(expected_path, timeout)`.
- **Where:** `tests/test_live_workflow.py:57-72` (replaced lines 57-65) + new `ApiHookClient.wait_for_project_switch` method.
- **Why:** Blind polling of derived state is fragile; condition-based wait is deterministic and surfaces the failure reason immediately.
- **Pattern:** See `src/api_hook_client.py:wait_for_server` (existing pattern in the same client).
- **Acceptance:** Test fails fast (within 5-10s) with a clear `error` message from the API instead of timing out at 10s with "Project failed to activate".
- **Acceptance:** Test fails fast (within 30s) with a clear `error` message from the API instead of timing out at 10s with "Project failed to activate". 6 unit tests for the new helper (mocked _make_request) all pass.
- **Known issue:** Test STILL fails in tier-3-live_gui batch (passes in 10.24s in isolation). The wait helper reports `in_progress: True` for the full 30s timeout, meaning `_do_project_switch` background thread is not completing. Likely io_pool saturation from prior sims' AI discussion turns. Needs further investigation of `_do_project_switch` hangs in batch context.
### 5. [LOW] Add defensive state assertions
- **What:** Before polling for activation, verify:
- The file was created: `assert os.path.exists(temp_project_path)`
- The click was enqueued: check `client.get_events()` for the `click` task
### 5. [LOW] Add defensive state assertions ✅ SHIPPED (commit b6972c31)
- **What:** Before waiting for activation, verify the file was created (5s poll, then assert).
- **Where:** `tests/test_live_workflow.py:55-65`.
- **Why:** Catches the case where the click was dropped or the handler crashed before writing the file.
- **Acceptance:** If the file doesn't exist after the click, the test fails immediately with "temp_project.toml not created" instead of timing out.
- **Acceptance:** If the file doesn't exist within 5s, the test fails immediately with "temp_project.toml not created within 5s of click". (The `client.get_events()` check is not implemented; the file existence check is the primary signal.)
- **Verified:** Defensive check passes in both isolation and batch (file IS created). The batch failure is downstream of this check (in `_do_project_switch` background thread).
### 6. [LOW] Add `pytest.mark.live` to pyproject.toml markers
- **What:** Append `"live: marks tests as live visualization tests (not in CI by default)"` to `[tool.pytest.ini_options].markers`.