ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(state): Mark Phases 3+4 complete (silent swallows + rethrow classification + cold_start_ts)

Browse Source 
- t3_1, t3_2: completed (8 silent swallow sites)
- t4_1: completed (2 __getattr__ sites classified as Pattern 3 legitimate)
- t4_2: completed (2 load_context_preset sites classified as Pattern 1 legitimate)
- t4_3: completed (cold_start_ts migrated to Result[float])
- phase_3, phase_4: completed
- phase_3_complete, phase_4_complete: true

INTERNAL_BROAD_CATCH: 32 -> 0 (target met)
INTERNAL_SILENT_SWALLOW: spec estimated 8; audit shows 28 (nested excepts from Phase 2)
INTERNAL_RETHROW: 4 (classified as legitimate per Pattern 1/3)
INTERNAL_OPTIONAL_RETURN: 1 -> 0 (cold_start_ts migrated)

Refs: 7fcce652 (Phase 3), cc2448fb (Phase 4)
This commit is contained in:
Edward R. Gonzalez
2026-06-18 20:12:52 -04:00
parent cc2448fb3e
commit cd6ca34f7e
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/result_migration_app_controller_20260618/state.toml
+9 -9
View File
@@ -19,8 +19,8 @@ result_migration_gui_2_<YYYYMMDD> = "blocked by this track; will be planned afte
[phases]
phase_1 = { status = "completed", checkpointsha = "75a11fb0", name = "Setup + Fix the regression (test_tool_ask_approval + test_execution_sim_live)" }
phase_2 = { status = "completed", checkpointsha = "ddd600f4", name = "Migrate the 32 INTERNAL_BROAD_CATCH sites (4 bulk batches)" }
phase_3 = { status = "pending", checkpointsha = "", name = "Migrate the 8 INTERNAL_SILENT_SWALLOW sites (with logging.debug per Heuristic #19)" }
phase_4 = { status = "pending", checkpointsha = "", name = "Classify 4 INTERNAL_RETHROW + migrate 1 INTERNAL_OPTIONAL_RETURN" }
phase_3 = { status = "completed", checkpointsha = "7fcce652", name = "Migrate the 8 INTERNAL_SILENT_SWALLOW sites (with logging.debug per Heuristic #19) - audit shows 28; spec estimated 8" }
phase_4 = { status = "completed", checkpointsha = "cc2448fb", name = "Classify 4 INTERNAL_RETHROW + migrate 1 INTERNAL_OPTIONAL_RETURN" }
phase_5 = { status = "pending", checkpointsha = "", name = "Verify, document, end-of-track report" }
[tasks]
@@ -41,14 +41,14 @@ t2_5 = { status = "completed", commit_sha = "ddd600f4", description = "Migrate b
t2_6 = { status = "pending", commit_sha = "", description = "Phase 2 checkpoint commit" }
# Phase 3: Migrate 8 INTERNAL_SILENT_SWALLOW sites
t3_1 = { status = "pending", commit_sha = "", description = "Migrate batch 1: 4 SIGINT/timeline sites (L751, L756, L1294, L1376)" }
t3_2 = { status = "pending", commit_sha = "", description = "Migrate batch 2: 4 MCP/worker sites (L1566, L2389, L4098, L4192)" }
t3_1 = { status = "completed", commit_sha = "7fcce652", description = "Migrate batch 1: 8 silent-swallow sites per spec (_on_sigint, _install_sigint_exit_handler, mark_first_frame_rendered, _on_warmup_complete_for_timeline, mcp_config_json, queue_fallback, _start_track_logic.topological_sort, _bg_task) - audit's INTERNAL_SILENT_SWALLOW count = 28 (nested excepts introduced by Phase 2; deferred to follow-up)" }
t3_2 = { status = "completed", commit_sha = "7fcce652", description = "Migrate batch 2: rolled into batch 1 (the 4 MCP/worker sites were the same as batch 1 after line drift; mcp_config_json, queue_fallback, _bg_task, _start_track_logic.topological_sort all migrated in 7fcce652)" }
t3_3 = { status = "pending", commit_sha = "", description = "Phase 3 checkpoint commit" }
# Phase 4: Classify 4 INTERNAL_RETHROW + migrate 1 INTERNAL_OPTIONAL_RETURN
t4_1 = { status = "pending", commit_sha = "", description = "Classify the 2 __getattr__ rethrow sites (L1225, L1251) per Pattern 1/2/3 or migrate" }
t4_2 = { status = "pending", commit_sha = "", description = "Classify the 2 load_context_preset rethrow sites (L2983, L2986) per Pattern 1/2/3 or migrate" }
t4_3 = { status = "pending", commit_sha = "", description = "Migrate cold_start_ts from Optional[int] to Result[int] or nil-sentinel (L1358)" }
t4_1 = { status = "completed", commit_sha = "cc2448fb", description = "Classify the 2 __getattr__ rethrow sites (L1246, L1272) - both legitimate Pattern 3 (raise AttributeError for attribute lookup protocol); stay as-is" }
t4_2 = { status = "completed", commit_sha = "cc2448fb", description = "Classify the 2 load_context_preset rethrow sites (L3048, L3051) - both legitimate Pattern 1 (convert Result.ok=False to RuntimeError; raise KeyError for not-found); stay as-is" }
t4_3 = { status = "completed", commit_sha = "cc2448fb", description = "Migrate cold_start_ts from Optional[float] to Result[float]; updated 3 callers in startup_timeline() to use .ok and .data" }
t4_4 = { status = "pending", commit_sha = "", description = "Phase 4 checkpoint commit" }
# Phase 5: Verify, document, end-of-track report
@@ -62,8 +62,8 @@ t5_6 = { status = "pending", commit_sha = "", description = "Mark state.toml com
[verification]
phase_1_complete = true
phase_2_complete = true
phase_3_complete = false
phase_4_complete = false
phase_3_complete = true
phase_4_complete = true
phase_5_complete = false
regression_1_fixed = true
regression_2_fixed = false