conductor(plan): mark Phase 7 complete (4 silent-swallow sites + audit heuristic tightened)
Phase 7 (Strict Enforcement Cleanup) complete: - L242 + L256 (RAG + symbols in _api_generate) migrated via commit9bba317d- L5064 + L5093 (_push_mma_state_update + _load_active_tickets.beads) via commitbab5d212- Audit heuristic tightened (BOUNDARY_FASTAPI requires HTTPException/Result) via commit2752b5a8with 5 regression-guard tests Audit gate satisfied: - INTERNAL_SILENT_SWALLOW: 0 (was 30 post-Phase-3 laundering; 0 after Phase 6) - INTERNAL_BROAD_CATCH: 0 - BOUNDARY_FASTAPI: 13 sites stable (all in _api_* handlers with proper HTTPException raise or Result return) Tier 1 (254 tests): ALL 5 PASS Tier 2 (35 tests): ALL 5 PASS Targeted heuristic tests: 61 passed, 2 xfailed (existing) Test app_controller_result.py: 33 tests pass (27 Phase 6 + 6 Phase 7) TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before this commit. Per error_handling.md:530 'logging is NOT a drain', the 4 strict-violation sites have been migrated to proper Result[T] propagation with real drain points.
This commit is contained in:
@@ -11,6 +11,8 @@ umbrella = "result_migration_20260616"
|
||||
sub_track_index = 3
|
||||
phase_6_added = "2026-06-18 — supersedes Phase 3's logging.debug 'migration' with proper Result[T] propagation; audit gate via --strict"
|
||||
phase_6_completed = "2026-06-19 — 30 silent swallow sites migrated to Result[T] with proper drain points (Pattern 3 os._exit, stderr + instance state, Pattern 4 telemetry, Pattern 5 bounded retry); audit count: 30 -> 0; 25 new helper methods + 13 new state attributes added"
|
||||
phase_7_added = "2026-06-19 — Strict Enforcement Cleanup: 4 over-classified strict-violation sites (L242, L256 in _api_generate; L5064 _push_mma_state_update; L5093 _load_active_tickets.beads) migrated to proper Result[T] propagation; audit heuristic tightened so BOUNDARY_FASTAPI only applies when except body raises HTTPException or returns Result"
|
||||
phase_7_completed = "2026-06-19 — Phase 7 complete: 4 sites migrated (Task 7.6+7.8 commit 2752b5a8); audit count remains INTERNAL_SILENT_SWALLOW=0, INTERNAL_BROAD_CATCH=0; BOUNDARY_FASTAPI count stable at 13 sites; 5 regression-guard tests in tests/test_audit_heuristics.py lock the heuristic behavior"
|
||||
|
||||
[blocked_by]
|
||||
result_migration_small_files_20260617 = "shipped 2026-06-17"
|
||||
@@ -115,27 +117,27 @@ regression_2_fixed = true
|
||||
batched_suite_no_new_regressions = true
|
||||
audit_silent_swallow_zero = true
|
||||
|
||||
phase_7 = { status = "pending", checkpointsha = "", name = "Strict Enforcement Cleanup: 4 silent-swallow sites + audit heuristic tightening" }
|
||||
phase_7 = { status = "completed", checkpointsha = "2752b5a8", name = "Strict Enforcement Cleanup: 4 silent-swallow sites + audit heuristic tightening" }
|
||||
|
||||
# Phase 7: Strict Enforcement Cleanup
|
||||
# Audit gate: uv run python scripts/audit_exception_handling.py --src src/app_controller.py --strict exits 0
|
||||
# AND 0 strict-violation sites (L242, L256, L5064, L5093) reported
|
||||
|
||||
t7_1 = { status = "pending", commit_sha = "", description = "Confirm heuristic over-application at scripts/audit_exception_handling.py:319-321 + 393-397" }
|
||||
t7_2 = { status = "pending", commit_sha = "", description = "Migrate src/app_controller.py:242 (RAG) to _rag_search_result + _last_request_errors" }
|
||||
t7_3 = { status = "pending", commit_sha = "", description = "Migrate src/app_controller.py:256 (symbols) to _symbol_resolution_result + _last_request_errors" }
|
||||
t7_4 = { status = "pending", commit_sha = "", description = "Migrate _push_mma_state_update: split into _push_mma_state_update_result + legacy wrapper" }
|
||||
t7_5 = { status = "pending", commit_sha = "", description = "Migrate _load_active_tickets.beads inner: _load_beads_from_path_result helper" }
|
||||
t7_6 = { status = "pending", commit_sha = "", description = "Tighten audit heuristic: BOUNDARY_FASTAPI only when except body raises HTTPException or returns Result" }
|
||||
t7_7 = { status = "pending", commit_sha = "", description = "Add 4 unit tests in tests/test_app_controller_result.py for migrated sites" }
|
||||
t7_8 = { status = "pending", commit_sha = "", description = "Add 3 unit tests in new tests/test_audit_heuristics.py for heuristic regression-guard" }
|
||||
t7_9 = { status = "pending", commit_sha = "", description = "Run audit --strict; verify 0 violations + FR7 tests pass" }
|
||||
t7_10 = { status = "pending", commit_sha = "", description = "Run 11-tier batched suite; verify no new regressions" }
|
||||
t7_11 = { status = "pending", commit_sha = "", description = "Update state.toml Phase 7 tasks complete; update metadata.json; conductor(plan) commit" }
|
||||
t7_12 = { status = "pending", commit_sha = "", description = "Phase 7 checkpoint commit with git note (audit before/after metrics)" }
|
||||
t7_1 = { status = "completed", commit_sha = "", description = "Confirm heuristic over-application at scripts/audit_exception_handling.py:319-321 + 393-397" }
|
||||
t7_2 = { status = "completed", commit_sha = "9bba317d", description = "Migrate src/app_controller.py:242 (RAG) to _rag_search_result + _last_request_errors" }
|
||||
t7_3 = { status = "completed", commit_sha = "9bba317d", description = "Migrate src/app_controller.py:256 (symbols) to _symbol_resolution_result + _last_request_errors" }
|
||||
t7_4 = { status = "completed", commit_sha = "bab5d212", description = "Migrate _push_mma_state_update: split into _push_mma_state_update_result + legacy wrapper" }
|
||||
t7_5 = { status = "completed", commit_sha = "bab5d212", description = "Migrate _load_active_tickets.beads inner: _load_beads_from_path_result helper" }
|
||||
t7_6 = { status = "completed", commit_sha = "2752b5a8", description = "Tighten audit heuristic: BOUNDARY_FASTAPI only when except body raises HTTPException or returns Result" }
|
||||
t7_7 = { status = "completed", commit_sha = "9bba317d", description = "Add 4 unit tests in tests/test_app_controller_result.py for migrated sites" }
|
||||
t7_8 = { status = "completed", commit_sha = "2752b5a8", description = "Add 3 unit tests in new tests/test_audit_heuristics.py for heuristic regression-guard" }
|
||||
t7_9 = { status = "completed", commit_sha = "", description = "Run audit --strict; verify 0 violations + FR7 tests pass" }
|
||||
t7_10 = { status = "completed", commit_sha = "", description = "Run 11-tier batched suite; verify no new regressions" }
|
||||
t7_11 = { status = "completed", commit_sha = "", description = "Update state.toml Phase 7 tasks complete; update metadata.json; conductor(plan) commit" }
|
||||
t7_12 = { status = "completed", commit_sha = "", description = "Phase 7 checkpoint commit with git note (audit before/after metrics)" }
|
||||
t7_13 = { status = "pending", commit_sha = "", description = "Conductor - User Manual Verification (per workflow.md)" }
|
||||
|
||||
[verification.phase_7]
|
||||
phase_7_complete = false
|
||||
audit_strict_exits_0 = false
|
||||
fr7_regression_guard_tests_pass = false
|
||||
phase_7_complete = true
|
||||
audit_strict_exits_0 = true
|
||||
fr7_regression_guard_tests_pass = true
|
||||
|
||||
Reference in New Issue
Block a user