Private
Public Access
conductor(plan): Mark Task 1.1 complete (audit_weak_types regression fixed)
This commit is contained in:
@@ -6,8 +6,9 @@
|
||||
|
||||
Focus: Resolve the 2 in-scope failing audit gates.
|
||||
|
||||
- [ ] Task 1.1: Investigate the 5 weak-type regression sites; fix or annotate each.
|
||||
- [x] Task 1.1: Investigate the 5 weak-type regression sites; fix or annotate each. [9e143445]
|
||||
- WHERE: `src/code_path_audit.py`, `src/code_path_audit_analysis.py`, `src/code_path_audit_cross_audit.py`, `src/code_path_audit_gen.py`, `src/code_path_audit_render.py`, `src/code_path_audit_rollups.py`, `src/code_path_audit_ssdl.py`
|
||||
- **INVESTIGATION FINDING (2026-06-24):** The 5 regression sites are NOT in code_path_audit files (they report 0 weak type findings). The actual regression of 5 (117 vs baseline 112) comes from 2 new files added after baseline (2026-06-21): `src/mcp_tool_specs.py` (4 findings, all `dict[str, Any]`) and `src/openai_schemas.py` (10 findings). Net change is +5 after accounting for refactor reductions in other files. Fix: replace `dict[str, Any]` with `JsonValue` TypeAlias in those 2 files (5+ sites to bring count below baseline).
|
||||
- WHAT: Run `uv run python scripts/audit_weak_types.py --strict` and capture the 5 sites that regressed. For each, determine: is the site in dead code (will be deleted in Phase 2), or in live code (needs TypeAlias per FR1).
|
||||
- HOW: `uv run python scripts/audit_weak_types.py 2>&1 | head -200` to see all findings with file:line references. For each site:
|
||||
- If the file is being deleted in Phase 2 (DSL parser, compute_result_coverage), no action needed.
|
||||
|
||||
Reference in New Issue
Block a user