ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(plan): Mark Phase 0 (dataclass addition + tests) as complete [bacddc85]

Browse Source
This commit is contained in:
ed
2026-06-25 14:48:48 -04:00
parent bacddc8549
commit 843c9c0460
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/metadata_promotion_20260624/plan.md
+6 -6
View File
@@ -27,16 +27,16 @@
- KEEP `JsonValue`, `JsonPrimitive`, `CommsLogCallback`, `FileItemsDiff` unchanged
- HOW: `manual-slop_edit_file` for surgical edits (or `write_file` if the file is being substantially restructured)
- SAFETY: `ast.parse` OK; `from src.type_aliases import CommsLogEntry, HistoryMessage, ToolDefinition, SessionInsights, DiscussionSettings, CustomSlice, MMAUsageStats, ProviderPayload, UIPanelConfig, PathInfo` OK; constructors work
- [ ] **COMMIT:** `refactor(type_aliases): add per-aggregate dataclasses (CommsLogEntry, HistoryMessage, ToolDefinition, ...)` (Tier 3)
- [ ] **GIT NOTE:** NEW dataclasses added to `src/type_aliases.py`. `Metadata: TypeAlias = dict[str, Any]` is UNCHANGED (the catch-all for collapsed codepaths). No consumer migration yet.
- [x] **COMMIT:** `refactor(type_aliases): add per-aggregate dataclasses (CommsLogEntry, HistoryMessage, ToolDefinition, ...)` [bacddc85] (Tier 3)
- [x] **GIT NOTE:** NEW dataclasses added to `src/type_aliases.py`. `Metadata: TypeAlias = dict[str, Any]` is UNCHANGED (the catch-all for collapsed codepaths). No consumer migration yet.
- [ ] **Task 0.2** [Tier 3]: Add `RAGChunk` dataclass to `src/rag_engine.py`.
- WHERE: `src/rag_engine.py` (the parent module for RAG)
- WHAT: `@dataclass(frozen=True, slots=True) class RAGChunk` with `document, path, score, metadata` (4 fields, all with defaults); paired `to_dict()` / `from_dict()`
- HOW: `manual-slop_edit_file`
- SAFETY: `from src.rag_engine import RAGChunk` OK; constructor works
- [ ] **COMMIT:** `feat(rag_engine): add RAGChunk dataclass` (Tier 3)
- [ ] **GIT NOTE:** NEW dataclass added to `src/rag_engine.py`. No consumer migration yet.
- [x] **COMMIT:** `feat(rag_engine): add RAGChunk dataclass` [bacddc85] (Tier 3)
- [x] **GIT NOTE:** NEW dataclass added to `src/rag_engine.py`. No consumer migration yet.
- [ ] **Task 0.3** [Tier 3]: Audit and complete `ContextPreset` schema in `src/models.py`.
- WHERE: `src/models.py` (the parent module for ContextPreset)
@@ -51,8 +51,8 @@
- WHAT: 5+ tests per file: constructor with kwargs, field access, frozen (raises `FrozenInstanceError`), `to_dict()` / `from_dict()` round-trip, equality, hashability, default values
- HOW: `write_file` per file
- SAFETY: `uv run pytest tests/test_comms_log_entry.py -v` shows 5/5 pass (and similarly for the other 11 files)
- [ ] **COMMIT:** `test(type_aliases): add per-aggregate dataclass regression-guard suite` (Tier 3)
- [ ] **GIT NOTE:** 12 test files, 5+ tests each. The consumer migration is in subsequent phases; this commit only adds the new dataclasses + tests.
- [x] **COMMIT:** `test(type_aliases): add per-aggregate dataclass regression-guard suite` [bacddc85] (Tier 3)
- [x] **GIT NOTE:** 12 test files, 5+ tests each. The consumer migration is in subsequent phases; this commit only adds the new dataclasses + tests.
- [ ] **Task 0.5** [Tier 2]: Document the FR6 collapsed-codepath classification rule.
- WHERE: `conductor/code_styleguides/type_aliases.md` (small clarification, NOT a rewrite)