Private
Public Access
0
0

conductor(plan): mark Phase 1 tasks 1.1-1.6 as complete (Front A core deletions)

Tasks 1.1-1.6 cover the bulk of Front A: the gemini_cli adapter module
plus all importer edits (ai_client, app_controller, gui_2,
project_manager, api_hooks) and the 7 dedicated gemini_cli test files.
Remaining Front A tasks (1.7-1.11) cover the mock provider, the 11 sim
test rewrites, the minor test edits, the doc updates, and the batch
checkpoint.
This commit is contained in:
2026-07-05 19:51:17 -04:00
parent a93a61fd77
commit 7e06d812d4
@@ -12,41 +12,17 @@ Spec: `conductor/tracks/test_suite_cleanup_gemini_cli_removal_20260705/spec.md`
Focus: delete the adapter module + the provider registration + the GUI panel + the test files. Introduce the `mock` provider for the 9 sim tests that used `gemini_cli` + `mock_gemini_cli.py`.
- [ ] **Task 1.1: Delete `src/gemini_cli_adapter.py`**
- [x] **Task 1.1: Delete `src/gemini_cli_adapter.py`** (2bba7f56)
WHERE: `src/gemini_cli_adapter.py` (193 lines, entire file).
WHAT: `git rm src/gemini_cli_adapter.py`.
VERIFY: `Test-Path src/gemini_cli_adapter.py` returns False.
- [x] **Task 1.2: Edit `src/ai_client.py` — remove the import, PROVIDERS entry, module state, 3 functions, 8 dispatch branches** (2bba7f56)
- [ ] **Task 1.2: Edit `src/ai_client.py` — remove the import, PROVIDERS entry, module state, 3 functions, 8 dispatch branches**
- [x] **Task 1.3: Edit `src/app_controller.py` — remove the ~11 gemini_cli sites** (a93a61fd)
WHERE: `src/ai_client.py` lines 49, 62, 164, 1727-1735, 2130-2241, 1857-1877, 556-561, 629, 914, 3302, 3306, 3394-3398, 3505-3509, 3556-3559.
WHAT: Per the audit inventory (GAP-A2). Carefully distinguish `_gemini_cli_adapter` (REMOVE) from `_gemini_client` / `_ensure_gemini_client` (KEEP — direct Gemini SDK).
HOW: Use `manual-slop_py_update_definition` for the 3 function removals; `manual-slop_edit_file` for the dispatch branches + import + PROVIDERS + module state.
VERIFY: `python -c "from src.ai_client import PROVIDERS; print(PROVIDERS)"` prints 7 entries (no `gemini_cli`).
- [x] **Task 1.4: Edit `src/gui_2.py` — remove the 2 gemini_cli blocks** (a93a61fd)
- [ ] **Task 1.3: Edit `src/app_controller.py` — remove the ~11 gemini_cli sites**
- [x] **Task 1.5: Edit `src/project_manager.py:126` + `src/api_hooks.py:88, 941-942`** (a93a61fd)
WHERE: `src/app_controller.py` lines 574-575, 1084, 1124, 1316, 1836-1840, 2022-2023, 2725-2729, 2932, 3215, 4124.
WHAT: Per GAP-A3 — remove `ui_gemini_cli_path` state field, settable/gettable map entries, `_update_gcli_adapter()` method, project load/save, init.
VERIFY: `grep "gemini_cli" src/app_controller.py` returns nothing.
- [ ] **Task 1.4: Edit `src/gui_2.py` — remove the 2 gemini_cli blocks**
WHERE: `src/gui_2.py` lines 2940-2947 (ASCII comment) + 3008-3025 (provider panel block).
WHAT: Delete both blocks.
VERIFY: `grep "gemini_cli" src/gui_2.py` returns nothing.
- [ ] **Task 1.5: Edit `src/project_manager.py:126` + `src/api_hooks.py:88, 941-942`**
WHERE: `src/project_manager.py:126` (delete the default config entry) + `src/api_hooks.py:88` (delete the docstring line) + `src/api_hooks.py:941-942` (simplify the HookServer auto-start — the `is_gemini_cli` special case becomes dead).
VERIFY: `grep "gemini_cli" src/project_manager.py src/api_hooks.py` returns nothing.
- [ ] **Task 1.6: Delete the 7 gemini_cli test files**
WHERE: `tests/test_gemini_cli_adapter.py`, `tests/test_gemini_cli_adapter_parity.py`, `tests/test_gemini_cli_integration.py`, `tests/test_gemini_cli_parity_regression.py`, `tests/test_gemini_cli_edge_cases.py`, `tests/test_mock_gemini_cli.py`, `tests/test_ai_client_cli.py`.
WHAT: `git rm` all 7.
VERIFY: `Test-Path` returns False for all 7.
- [x] **Task 1.6: Delete the 7 gemini_cli test files** (2bba7f56)
- [ ] **Task 1.7: Introduce the `mock` provider in `src/ai_client.py`**