ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(plan): mark Phase 1 complete (site inventory + classification)

Browse Source 
TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 1.

Phase 1 covered:
- t1.1 [a068934]: Run audit --json, captured 77KB PHASE1_AUDIT.json
- t1.2 [a068934]: Wrote PHASE1_SITE_INVENTORY.md (42 rows; phase distribution
  P3=8, P4=3, P5=13, P7=1, P8=4, P9=1, P10=8, P11=2, P12=2 = 42)
- t1.3 [554fbbd]: Created tests/test_gui_2_result.py with 2 invariant tests
  (test_phase_1_inventory_has_42_rows + test_phase_1_audit_has_42_migration_target_sites)
- Phase 1 checkpoint: state.toml Phase 1 -> completed; 2 invariant tests pass.

Phase 1 establishes the migration-target scope. Phase 2 begins: drain plane
wiring (3 new render functions for the data plane consumer side).
This commit is contained in:
Edward R. Gonzalez
2026-06-19 21:23:48 -04:00
parent 554fbbd541
commit 7c93a68f67
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/result_migration_gui_2_20260619/plan.md
+10 -10
View File
@@ -136,15 +136,15 @@ git commit -m "conductor(state): mark Phase 0 complete"
**Focus:** Run the audit, walk every finding, classify each of the 42 migration-target sites.
### Task 1.1: Run the audit + capture JSON output
### Task 1.1: Run the audit + capture JSON output [a068934]
- [ ] **Step 1: Run audit and save JSON**
- [x] **Step 1: Run audit and save JSON**
```bash
uv run python scripts/audit_exception_handling.py --src src/gui_2.py --json > tests/artifacts/PHASE1_AUDIT.json
```
- [ ] **Step 2: Verify JSON was generated**
- [x] **Step 2: Verify JSON was generated**
```bash
ls -la tests/artifacts/PHASE1_AUDIT.json
@@ -152,12 +152,12 @@ ls -la tests/artifacts/PHASE1_AUDIT.json
Expected: file exists, size > 1KB
### Task 1.2: Walk the audit + write the inventory
### Task 1.2: Walk the audit + write the inventory [a068934]
**Files:**
- Create: `tests/artifacts/PHASE1_SITE_INVENTORY.md`
- [ ] **Step 1: Extract the 42 migration-target sites**
- [x] **Step 1: Extract the 42 migration-target sites**
```bash
uv run python -c "
@@ -222,13 +222,13 @@ git add tests/artifacts/PHASE1_AUDIT.json tests/artifacts/PHASE1_MIGRATION_TARGE
git commit -m "conductor(plan): Phase 1 site inventory — 42 migration-target sites classified"
```
### Task 1.3: Phase 1 invariant test + checkpoint
### Task 1.3: Phase 1 invariant test + checkpoint [554fbbd]
**Files:**
- Create: `tests/test_gui_2_result.py` (initial creation; will be extended each phase)
- Modify: `conductor/tracks/result_migration_gui_2_20260619/state.toml`
- [ ] **Step 1: Create the test file with Phase 1 invariant test**
- [x] **Step 1: Create the test file with Phase 1 invariant test**
```python
"""Tests for gui_2.py Result[T] migration (sub-track 4 of result_migration_20260616).
@@ -275,7 +275,7 @@ def test_phase_1_invariant_baseline_captured():
assert gui["unclear_count"] >= 2, f"Expected ≥2 unclear, found {gui['unclear_count']}"
```
- [ ] **Step 2: Run the test — it should PASS (the inventory was committed in Task 1.2)**
- [x] **Step 2: Run the test — it should PASS (the inventory was committed in Task 1.2)**
```bash
uv run python -m pytest tests/test_gui_2_result.py::test_phase_1_invariant_inventory_complete tests/test_gui_2_result.py::test_phase_1_invariant_baseline_captured -v
@@ -283,13 +283,13 @@ uv run python -m pytest tests/test_gui_2_result.py::test_phase_1_invariant_inven
Expected: 2 PASSED
- [ ] **Step 3: Update state.toml Phase 1**
- [x] **Step 3: Update state.toml Phase 1**
```toml
phase_1 = { status = "completed", checkpointsha = "<commit_sha>", name = "Site inventory + classification (42 sites)" }
```
- [ ] **Step 4: Commit**
- [x] **Step 4: Commit**
```bash
git add tests/test_gui_2_result.py conductor/tracks/result_migration_gui_2_20260619/state.toml
conductor/tracks/result_migration_gui_2_20260619/state.toml
+6 -6
View File
@@ -19,7 +19,7 @@ result_migration_baseline_cleanup = "blocked by this track; date TBD when this t
[phases]
phase_0 = { status = "completed", checkpointsha = "62188d6", name = "Setup + styleguide re-read (3 tasks)" }
phase_1 = { status = "pending", checkpointsha = "", name = "Site inventory + classification (3 tasks; 42 sites in PHASE1_SITE_INVENTORY.md)" }
phase_1 = { status = "completed", checkpointsha = "554fbbd", name = "Site inventory + classification (3 tasks; 42 sites in PHASE1_SITE_INVENTORY.md)" }
phase_2 = { status = "pending", checkpointsha = "", name = "Drain plane wiring (4 tasks; 3 new render functions + 2 invariant tests)" }
phase_3 = { status = "pending", checkpointsha = "", name = "INTERNAL_BROAD_CATCH Batch A — render-loop sites (<=10 sites)" }
phase_4 = { status = "pending", checkpointsha = "", name = "INTERNAL_BROAD_CATCH Batch B — modal/dialog sites (<=10 sites)" }
@@ -40,9 +40,9 @@ t0_2 = { status = "completed", commit_sha = "62188d6", description = "Tier 2 rea
t0_3 = { status = "in_progress", commit_sha = "", description = "Phase 0 checkpoint commit; update state.toml Phase 0 status" }
# Phase 1: Site inventory + classification (3 tasks)
t1_1 = { status = "pending", commit_sha = "", description = "Run audit --src src/gui_2.py --json > tests/artifacts/PHASE1_AUDIT.json" }
t1_2 = { status = "pending", commit_sha = "", description = "Walk the audit + write tests/artifacts/PHASE1_SITE_INVENTORY.md (42 rows)" }
t1_3 = { status = "pending", commit_sha = "", description = "Create tests/test_gui_2_result.py with 2 Phase 1 invariant tests; Phase 1 checkpoint" }
t1_1 = { status = "completed", commit_sha = "a068934", description = "Run audit --src src/gui_2.py --json > tests/artifacts/PHASE1_AUDIT.json" }
t1_2 = { status = "completed", commit_sha = "a068934", description = "Walk the audit + write tests/artifacts/PHASE1_SITE_INVENTORY.md (42 rows)" }
t1_3 = { status = "in_progress", commit_sha = "", description = "Create tests/test_gui_2_result.py with 2 Phase 1 invariant tests; Phase 1 checkpoint" }
# Phase 2: Drain plane wiring (4 tasks)
t2_1 = { status = "pending", commit_sha = "", description = "Add render_controller_error_modal(app) — reads 8 controller attributes; renders popups" }
@@ -166,7 +166,7 @@ t13_5 = { status = "pending", commit_sha = "", description = "Final checkpoint +
[verification]
phase_0_complete = true
phase_1_complete = false
phase_1_complete = true
phase_2_complete = false
phase_3_complete = false
phase_4_complete = false
@@ -181,7 +181,7 @@ phase_12_complete = false
phase_13_complete = false
audit_strict_exits_0 = false
batched_suite_11_of_11_pass = false
site_inventory_has_42_rows = false
site_inventory_has_42_rows = true
drain_plane_render_functions_exist = false
silent_swallow_count_zero = false
rethrow_count_zero = false