conductor(plan): Mark task 1.2.1-1.2.3 (render_json filter fix) complete
This commit is contained in:
@@ -48,12 +48,12 @@
|
||||
|
||||
### 1.2 Fix `render_json` compliant-finding filter
|
||||
|
||||
- [ ] **Task 1.2.1: Write failing test for the per-file findings list**
|
||||
- [x] **Task 1.2.1: Write failing test for the per-file findings list** [737bbee1]
|
||||
- WHERE: `tests/test_audit_exception_handling_bug_fixes.py`
|
||||
- WHAT: A test fixture with an `INTERNAL_COMPLIANT` site (e.g., the list.index+ValueError pattern). Run the audit with `--json` (non-verbose). Assert the `INTERNAL_COMPLIANT` finding is in the per-file list.
|
||||
- HOW: Same `subprocess` pattern; parse the JSON; check the findings list
|
||||
|
||||
- [ ] **Task 1.2.2: Fix the filter**
|
||||
- [x] **Task 1.2.2: Fix the filter** [737bbee1]
|
||||
- WHERE: `scripts/audit_exception_handling.py:884, 889, 958`
|
||||
- WHAT: The filter `if f.category in VIOLATION_CATEGORIES or f.category in ("UNCLEAR", "INTERNAL_RETHROW")` excludes `INTERNAL_COMPLIANT`. The fix depends on intent:
|
||||
- If the goal is "show only non-compliant findings" (current behavior), the filter is correct; the fix is to add a `--verbose` flag that includes compliant findings
|
||||
|
||||
Reference in New Issue
Block a user