Private
Public Access
0
0

conductor(tracks): mark v1 fragility_fixes complete, queue v2 (state sync + undo_redo + prior_session)

This commit is contained in:
2026-06-05 22:09:30 -04:00
parent 873edf42cf
commit 70c18f92c3
+10 -1
View File
@@ -391,8 +391,17 @@ User review surfaced five outstanding UI issues, each previously attempted witho
*Link: [./tracks/regression_fixes_20260605/](./tracks/regression_fixes_20260605/), Plan: [./../../docs/superpowers/plans/2026-06-05-regression-fixes.md](./../../docs/superpowers/plans/2026-06-05-regression-fixes.md)*
*Goal: Resolve 21 failing tests surfaced after the multi-themes ship. 11 of 21 fixed across 10 atomic commits: theme regression (`test_gui_progress` C_LBL/C_VAL API change, `38abf231`), pre-existing non-live_gui (`test_gui_phase4` markdown_helper mocks, `df43f158`; `test_view_presets` persona_manager mock, `970f198c`), GUI production bug (`DIR_COLORS` callable, `1469ecac`), live_gui `LogPruner` busy loop (`ac08ee87`), RAG NoneType guard (`c96bdb06`). **Root cause of remaining 10 live_gui failures identified (commit `d7487af4`)**: `imgui.save_ini_settings_to_memory()` at `src/gui_2.py:601` crashes C-level (`0xc0000005`) when called in the first few render frames because ImGui's internal state (Fonts, DisplaySize, Settings) isn't ready. Crash is uncatchable from Python. Fixed with `_ini_capture_ready` flag (defer-not-catch pattern): first call returns `b""` and sets the flag, subsequent calls invoke the C function. Bisect anchors: `7df65dff` (pre-existing failures start), `7ea52cbb` (theme-caused failures start). Deferred follow-up track needed for ~5 remaining live_gui tests (MMA engine state transitions, RAG status timing, one test needing substantial render path mocks).*
- [~] **Track: Live-GUI Fragility Fixes (post regression_fixes ship)** `[checkpoint: 5692cbef]`
- [x] **Track: Live-GUI Fragility Fixes (post regression_fixes ship)** `[checkpoint: 1488e715]` [superseded by live_gui_test_hardening_v2]
*Link: Plan: [./../../docs/superpowers/plans/2026-06-05-live-gui-fragility-fixes.md](./../../docs/superpowers/plans/2026-06-05-live-gui-fragility-fixes.md), Spec: [./../../docs/superpowers/specs/2026-06-05-live-gui-fragility-fixes-design.md](./../../docs/superpowers/specs/2026-06-05-live-gui-fragility-fixes-design.md)*
*Goal: Resolve the 3 remaining live_gui failures (269/272 → 271/272 plus 1 new regression unit test). 1-line src fix in `_capture_workspace_profile` (change `ini=b""` to `ini=""` to satisfy `WorkspaceProfile.ini_content: str` contract that `tomli_w` enforces); the `b""` sentinel was a regression from `d7487af4` that caused `save_workspace_profile` to raise `TypeError`, profile never saved, `load_workspace_profile` became a no-op. 1 new unit test (`tests/test_workspace_profile_serialization.py`) encoding the str/bytes contract. `test_prior_session_no_pop_imbalance` is **deferred to a separate follow-up track** — the test was more under-mocked than the spec assumed; fixing imscope.window tuple-return only revealed the next un-mocked dependency (imgui.begin returning bool where 2-tuple expected at line 4496). `render_main_interface` is a kitchen-sink function requiring 50+ mocks; a follow-up track will either add the missing mocks or refactor the test to exercise a narrow prior-session render path. Change 4 (doc hardening of defer-not-catch sections) deferred to track end; not done due to scope focus.*
- [~] **Track: Live-GUI Test Hardening v2 (post v1 ship)** `[in progress]`
*Link: [./tracks/live_gui_test_hardening_v2_20260605/](./tracks/live_gui_test_hardening_v2_20260605/), Spec: TBD, Plan: TBD*
*Goal: Resolve the 4 remaining live_gui failures (was 3 in v1; 1 new regression). v1 fixed the str/bytes sentinel bug but exposed a deeper App/Controller state-sync bug. Plan: 4 sub-tasks - (1) App/Controller state sync fix + regression test, (2) test wait-for-ready pattern migration for set/save/load, (3) prior_session test mock setup or refactor, (4) undo_redo_lifecycle investigation + fix. Per-writing-plans skill.*
*Failing tests:*
- `test_auto_switch_sim` (still fails from v1) - **Deeper bug: App/Controller state sync**. The test does `set_value('ui_separate_tier1', True)` which goes to `controller.ui_separate_tier1`, but the save reads from `app.ui_separate_tier1`. Two different objects; the saved profile has the wrong value. Same root cause for `show_windows['Diagnostics']`.
- `test_workspace_profiles_restoration` (still fails from v1) - same App/Controller sync bug.
- `test_prior_session_no_pop_imbalance` (deferred from v1) - `render_main_interface` is a kitchen-sink function requiring 50+ mocks; needs refactor or extensive mock additions.
- `test_undo_redo_lifecycle` (NEW regression) - undo restores `temperature` correctly but `ai_input` is empty string instead of "Initial Input". Snapshot mechanism probably doesn't include `ai_input` field.
# TODO(Ed): Support "Virtual" Pasted entries for the context.