conductor(plan): Mark Task 3.4 complete

This commit is contained in:
ed
2026-06-17 00:34:00 -04:00
parent 423f9a95b0
commit 53b35de5c6
2 changed files with 52 additions and 6 deletions
@@ -333,14 +333,14 @@ to test_fr2_send_*). This may affect any external scripts that
reference these test IDs by name — review for impact." <hash>
```
### Task 3.4: Rename in `tests/test_conductor_tech_lead.py` (8 refs)
### Task 3.4: Rename in `tests/test_conductor_tech_lead.py` (8 refs) [423f9a9]
- [ ] **Step 1: Verify the test file currently fails**
- [x] **Step 1: Verify the test file currently fails**
Run: `uv run pytest tests/test_conductor_tech_lead.py 2>&1 | tail -3`
Expected: failures.
- [ ] **Step 2: Rename the 8 references**
- [x] **Step 2: Rename the 8 references**
Run: `git grep -n "send_result" -- tests/test_conductor_tech_lead.py`
Expected: 8 lines. Standard `@patch` + `mock_send_result` pattern.
@@ -348,12 +348,12 @@ Expected: 8 lines. Standard `@patch` + `mock_send_result` pattern.
Verify: `git grep "send_result" -- tests/test_conductor_tech_lead.py`
Expected: 0 matches.
- [ ] **Step 3: Run the test file — confirm green**
- [x] **Step 3: Run the test file — confirm green**
Run: `uv run pytest tests/test_conductor_tech_lead.py 2>&1 | tail -3`
Expected: all tests pass.
- [ ] **Step 4: Commit**
- [x] **Step 4: Commit**
```bash
git add tests/test_conductor_tech_lead.py
@@ -362,7 +362,7 @@ git commit -m "test(ai_client): rename send_result to send in test_conductor_tec
8 references renamed. Test file state: GREEN."
```
- [ ] **Step 5: Attach the git note**
- [x] **Step 5: Attach the git note**
```bash
git notes add -m "Task 3.4: rename in test_conductor_tech_lead.py
+46
View File
@@ -0,0 +1,46 @@
"""Update plan.md for Task 3.4."""
from __future__ import annotations
import sys
from pathlib import Path
PLAN = Path("conductor/tracks/send_result_to_send_20260616/plan.md")
SHA = "423f9a9"
EDITS: list[tuple[str, str]] = [
(
"### Task 3.4: Rename in `tests/test_conductor_tech_lead.py` (8 refs)\n\n- [ ] **Step 1: Verify the test file currently fails**",
f"### Task 3.4: Rename in `tests/test_conductor_tech_lead.py` (8 refs) [{SHA}]\n\n- [x] **Step 1: Verify the test file currently fails**",
),
("- [ ] **Step 2: Rename the 8 references**", "- [x] **Step 2: Rename the 8 references**"),
("- [ ] **Step 3: Run the test file — confirm green**", "- [x] **Step 3: Run the test file — confirm green**"),
("- [ ] **Step 4: Commit**", "- [x] **Step 4: Commit**"),
("- [ ] **Step 5: Attach the git note**", "- [x] **Step 5: Attach the git note**"),
]
def main() -> int:
with PLAN.open("r", encoding="utf-8", newline="") as f:
content = f.read()
has_crlf = "\r\n" in content
nl = "\r\n" if has_crlf else "\n"
normalized = [(o.replace("\n", nl), n.replace("\n", nl)) for o, n in EDITS]
new_content = content
applied = 0
for old, new in normalized:
if old in new_content:
new_content = new_content.replace(old, new, 1)
applied += 1
else:
print(f"NOT FOUND: {old[:80]!r}", file=sys.stderr)
if applied != len(EDITS):
print(f"Only applied {applied}/{len(EDITS)} edits.", file=sys.stderr)
return 1
with PLAN.open("w", encoding="utf-8", newline="") as f:
f.write(new_content)
print(f"Applied {applied}/{len(EDITS)} edits. Line endings: {'CRLF' if has_crlf else 'LF'}")
return 0
if __name__ == "__main__":
raise SystemExit(main())