conductor: register rag_test_failures_20260615 in tracks.md + update public_api row

2026-06-15 21:56:20 -04:00
parent 3fc492e302
commit 29c64a0125
1 changed files with 22 additions and 1 deletions
@@ -21,7 +21,8 @@ Tracks that are unblocked and ready to start. Ordered by **dependency** (blocked
 | 4 | A | [Data Structure Strengthening (Type Aliases + NamedTuples)](#track-data-structure-strengthening-type-aliases--namedtuples) | spec ✓, plan pending | **test_infrastructure_hardening_20260609 (merged)** |
 | 5 | A | [MCP Architecture Refactor (Sub-MCP Extraction)](#track-mcp-architecture-refactor-sub-mcp-extraction) | spec ✓, plan pending | test_infrastructure_hardening_20260609 (merged), data_oriented_error_handling, data_structure_strengthening |
 | 6 | D | [Public API Result Migration](#track-public-api-result-migration-followup) | placeholder; not yet specced | data_oriented_error_handling (deprecated `send()`) |
-| 6a | A | [Public API Migration + UI Polish Test Cleanup](#track-public-api-migration--ui-polish-test-cleanup) | spec ✓, plan ✓, ready to start | (none — independent; **NEW 2026-06-15**; combined stability track; fixes 6 of 10 pre-existing failures + removes deprecated `send()`) |
+| 6a | A | [Public API Migration + UI Polish Test Cleanup](#track-public-api-migration--ui-polish-test-cleanup) | spec ✓, plan ✓, shipped 2026-06-15 (13 pre-existing failures fixed; 3 RAG failures deferred to `rag_test_failures_20260615`) | (none — independent; **NEW 2026-06-15**; combined stability track) |
+| 6b | A | [RAG Test Failures Fix](#track-rag-test-failures-fix-new-2026-06-15) | spec ✓, plan ✓, ready to start | (none — independent; **NEW 2026-06-15**; small bug-fix track; 3 RAG tests fail with same NoneType.get error; first fully green baseline since 2026-06-12) |
 | 7 | — | [UI Polish (Five Issues)](#track-ui-polish-five-issues) | spec ✓, plan ✓, ready to start (Phases 1/4/5 shipped; Phases 2/3 code shipped but tests broken — fixed by track 6a) | (none — independent) |
 | 7a | B | [SQLite-Granularity Inline Docs for gui_2.py](#track-sqlite-granularity-inline-docs-for-gui_2py) | spec ✓, plan ✓, complete | (none — independent) |
 | 7b | B | [Continued SQLite-Granularity Inline Docs for gui_2.py](#track-continued-sqlite-granularity-inline-docs-for-gui_2py) | spec ✓, plan ✓, complete | (none — independent) |
@@ -635,6 +636,26 @@ Lightweight chronology; full spec/plan/state per track is in the linked folder.

 *Out of scope (documented in spec §7): 4 RAG test fixes (separate RAG subsystem track), the `_send_<vendor>()` → `_send_<vendor>_result()` rename (not needed; tests work with current names), 23 lower-impact weak-type files (next major track: `data_structure_strengthening_20260606`), `live_gui_mock_injection_20260615` infrastructure (separate infrastructure track).*

+#### Track: RAG Test Failures Fix (small bug-fix track) `[track-created: 2026-06-15]`
+*Link: [./tracks/rag_test_failures_20260615/](./tracks/rag_test_failures_20260615/), Spec: [./tracks/rag_test_failures_20260615/spec.md](./tracks/rag_test_failures_20260615/spec.md), Plan: [./tracks/rag_test_failures_20260615/plan.md](./tracks/rag_test_failures_20260615/plan.md), Metadata: [./tracks/rag_test_failures_20260615/metadata.json](./tracks/rag_test_failures_20260615/metadata.json)*
+
+*Status: 2026-06-15 — Active, ready for Tier 2 implementation. Small bug-fix track; first fully green baseline since `data_oriented_error_handling_20260606` shipped 2026-06-12.*
+
+*Goal: Fix the 3 remaining pre-existing test failures (down from 4 as the parent track documented; `test_rag_integration.py` was inadvertently fixed by `public_api_migration_and_ui_polish_20260615` Phase 2 follow-up commit `26e1b652`). All 3 share the same root cause: `'NoneType' object has no attribute 'get'` error from the RAG sync worker at `src/app_controller.py:_do_rag_sync`. The error is captured by the `except` clause at line 1480 and set as `rag_status`.*
+
+*3 tests fixed by this track:*
+- *`tests/test_rag_phase4_final_verify.py::test_phase4_final_verify` (fails at line 65)*
+- *`tests/test_rag_phase4_stress.py::test_rag_large_codebase_verification_sim` (fails at line 48)*
+- *`tests/test_rag_visual_sim.py::test_rag_full_lifecycle_sim` (fails at line 32)*
+
+*5 phases: Phase 1 (investigation + reproducing test), Phase 2 (fix), Phase 3 (full + batched test verification), Phase 4 (docs update conditional on `docs/guide_rag.md` existence), Phase 5 (metadata + tracks.md). ~10 tasks, 5-7 atomic commits, 0.5-1 day Tier 2 work.*
+
+*Critical audit findings (2026-06-15): The `RAGConfig()` default is correct (vector_store is not None; provider is 'mock' by default). The `RAGEngine` with mock vector store constructs successfully (verified by direct instantiation). The error originates in the RAG sync worker at `src/app_controller.py:1480`. Most likely candidates for the `.get(None)` call: `src/rag_engine.py:149` (embeddings = res.get('embeddings') in `_validate_collection_dim_result`) or a subtle config field that becomes None. Diagnostic strategy: add `traceback.format_exc()` to the except clause, capture the full traceback, identify the exact call site, fix surgically, remove the diagnostic.*
+
+*`blocks: data_structure_strengthening_20260606` (cleaner codebase makes type-alias replacement easier) and the user's stated `send_result` → `send` mass rename.*
+
+*Out of scope (deferred to separate tracks): the `send_result` → `send` mass rename (user's stated manual refactor), 23 lower-impact weak-type files (`data_structure_strengthening_20260606`), `live_gui_mock_injection_20260615` infrastructure (separate track), RAG test quality cleanup (poll loops, etc.; separate track).*
+
 ---

 ## Phase 9: Chore Tracks