ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(plan): Mark Phase 1 (G1 critical regression fix) complete

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-06-15 12:58:34 -04:00
parent 7b323e3e5f
commit 27d7a04fd3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/doeh_test_thinking_cleanup_20260615/plan.md
+3 -3
View File
@@ -20,13 +20,13 @@ Per the project rule (see `AGENTS.md` "Critical Anti-Patterns"), per-task atomic
**Focus:** Restore the `context_to_send` variable definition that the `ai_loop_regressions_20260614` FR2 fix accidentally removed. This is a production bug that breaks `/api/v1/generate` for all callers.
- [ ] **Task 1.1**: Verify the NameError is reproducible
- [x] **Task 1.1**: Verify the NameError is reproducible [7b323e3]
- **Command:** `uv run pytest tests/test_headless_service.py::TestHeadlessAPI::test_generate_endpoint -v 2>&1 | tee tests/artifacts/doeh_cleanup_phase1_red.log`
- **EXPECTED:** 500 error with `NameError: name 'context_to_send' is not defined` at `src/app_controller.py:278`
- **NOTE:** This is the existing canary test — no new test needed.
- **COMMIT:** No new commit; this is a verification step.
- [ ] **Task 1.2**: Fix `_api_generate` by adding back the missing `context_to_send` definition
- [x] **Task 1.2**: Fix `_api_generate` by adding back the missing `context_to_send` definition [7b323e3]
- **WHERE:** `src/app_controller.py:265-295` (the `_api_generate` function)
- **WHAT:** Add 2-3 lines BEFORE the `result = ai_client.send_result(...)` call at line 278. The added block is:
```python
@@ -40,7 +40,7 @@ Per the project rule (see `AGENTS.md` "Critical Anti-Patterns"), per-task atomic
- **VERIFY:** `uv run pytest tests/test_headless_service.py::TestHeadlessAPI::test_generate_endpoint -v` returns 200.
- **COMMIT:** `fix(app_controller): restore context_to_send definition in _api_generate (CRITICAL regression from ai_loop_regressions_20260614)`
- [ ] **Task 1.3**: Verify no regression in the other _api_generate and _handle_request_event paths
- [x] **Task 1.3**: Verify no regression in the other _api_generate and _handle_request_event paths [7b323e3]
- **Command:** `uv run pytest tests/test_headless_service.py tests/test_api_read_endpoints.py tests/test_api_control_endpoints.py -v 2>&1 | tee tests/artifacts/doeh_cleanup_phase1_sweep.log`
- **EXPECTED:** All other headless service tests pass (test_health_endpoint, test_status_endpoint_*, test_pending_actions_endpoint, test_confirm_action_endpoint, test_list_sessions_endpoint, test_get_context_endpoint).
- **COMMIT:** No new commit; this is a verification step.