ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

docs(track): result_migration_review_pass decisions for src/mcp_client.py UNCLEAR (4 compliant + 0 migration-target)

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-06-17 15:07:01 -04:00
parent f94d77eab8
commit 1c07e978bc
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md
+13 -1
View File
@@ -66,7 +66,19 @@ Other audit findings (unchanged by this review pass):
### 2.2 `src/mcp_client.py` — UNCLEAR sites (4, baseline)
*(filled in Task 2.2)*
| Line | Context | Snippet | Decision | Pattern / Rationale |
|---|---|---|---|---|
| 126 | `configure` (allowlist setup) | `except (OSError, ValueError): rp = Path(p).resolve()` (non-strict fallback) | **compliant** | Graceful path resolution: `Path.resolve(strict=True)` may fail if file missing; fallback to non-strict is a safe degradation |
| 152 | `_is_allowed` (allowlist check) | `except (OSError, ValueError): rp = path.resolve()` (non-strict fallback) | **compliant** | Graceful path resolution (same as L126) |
| 177 | `_is_allowed` (cwd subpath check) | `except ValueError: pass` after `rp.relative_to(cwd)` | **compliant** | `Path.relative_to` raises `ValueError` when path is not relative to base; this is the canonical "not-a-subpath" check, not an error |
| 987 | `py_check_syntax` (tool function) | `except SyntaxError: ...` then `except Exception: return f"ERROR..."` | **compliant** | Tool-boundary pattern: function returns a string (Result-like); both narrow and broad excepts convert exceptions to user-readable strings. No silent swallow |
**Subtotals:** 4 compliant + 0 migration-target.
**New heuristic candidates:**
5. `Path.resolve(strict=True)` with `(OSError, ValueError)` fallback to non-strict → `INTERNAL_COMPLIANT` (graceful path resolution)
6. `Path.relative_to` with `ValueError` (not-a-subpath) → `INTERNAL_COMPLIANT` (canonical subpath check)
7. MCP tool function with `except Exception: return f"ERROR..."` (string return) → `BOUNDARY_TOOL` (tool boundary; converts to string Result)
---