Private
Public Access
conductor(plan): Mark Phase 3 tasks 3.1-3.7 complete [3b966288]
This commit is contained in:
@@ -101,20 +101,14 @@ Focus: `src/commands.py:369-376` references `tests/artifacts/live_gui_workspace/
|
||||
- WHAT: `layout_paths = ["manualslop_layout.ini"]` (drop the `os.path.join("tests", ...)` line)
|
||||
- HOW: `manual-slop_edit_file` with `old_string` containing both `layout_paths = [` and the `os.path.join(...)` line; replace with `layout_paths = ["manualslop_layout.ini"]`
|
||||
- SAFETY: shrinks the function; no behavior change for end users (cwd-relative was the only functional path)
|
||||
- [ ] Task 3.4: Update `commands.reset_layout` docstring
|
||||
- [x] Task 3.4 [3b966288]: Update `commands.reset_layout` docstring (line 351-362; simplified from 5 to 3 lines)
|
||||
- WHERE: `src/commands.py:351-362`
|
||||
- WHAT: simplify the docstring; drop the phrase "deletes manualslop_layout.ini so hello_imgui regenerates a fresh" if no longer accurate
|
||||
- HOW: minimal edit via `manual-slop_edit_file`
|
||||
- SAFETY: docstring only, no behavior change
|
||||
- [ ] Task 3.5: Verify phase 3.1 tests now pass
|
||||
- HOW: `uv run pytest tests/test_reset_layout.py -v --tb=short`
|
||||
- Expected: 1 test passes; the `inspect.getsource` assertion holds
|
||||
- [ ] Task 3.6: Run adjacent test_batch (`tests/test_commands*.py`)
|
||||
- HOW: `uv run python scripts/run_tests_batched.py --filter test_commands*`
|
||||
- Expected: no regression
|
||||
- [ ] Task 3.7: Commit phase 3 with git note
|
||||
- WHAT: `chore(commands): remove dead test-fixture path from reset_layout`
|
||||
- HOW: standard atomic commit; git note = "Reset_layout referenced `tests/artifacts/live_gui_workspace/manualslop_layout.ini`, dead code in production. Removed per user directive 2026-06-29: production code must default to the immediate directory."
|
||||
- [x] Task 3.5 [3b966288]: Verify phase 3.1 tests now pass — 2/2 PASSED (test_reset_layout_excludes_test_fixture_path, test_reset_layout_runs_on_clean_app)
|
||||
- [x] Task 3.6 [3b966288]: Run adjacent test_batch (test_reset_layout + test_commands_no_top_level_command_palette) — 6/6 PASSED
|
||||
- [x] Task 3.7 [3b966288]: Commit phase 3 with git note (3b966288 chore(commands): remove dead test-fixture path from reset_layout)
|
||||
|
||||
## Phase 4: Verification
|
||||
|
||||
|
||||
Reference in New Issue
Block a user