From 06476c569ad27f081b9bcbd7cf533940bdd08a31 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Mon, 29 Jun 2026 16:48:54 -0400 Subject: [PATCH] conductor(plan): Mark Phase 3 tasks 3.1-3.7 complete [3b966288] --- .../default_layout_install_20260629/plan.md | 14 ++++---------- .../default_layout_install_20260629/state.toml | 16 ++++++++-------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/conductor/tracks/default_layout_install_20260629/plan.md b/conductor/tracks/default_layout_install_20260629/plan.md index c9d093ca..7702da55 100644 --- a/conductor/tracks/default_layout_install_20260629/plan.md +++ b/conductor/tracks/default_layout_install_20260629/plan.md @@ -101,20 +101,14 @@ Focus: `src/commands.py:369-376` references `tests/artifacts/live_gui_workspace/ - WHAT: `layout_paths = ["manualslop_layout.ini"]` (drop the `os.path.join("tests", ...)` line) - HOW: `manual-slop_edit_file` with `old_string` containing both `layout_paths = [` and the `os.path.join(...)` line; replace with `layout_paths = ["manualslop_layout.ini"]` - SAFETY: shrinks the function; no behavior change for end users (cwd-relative was the only functional path) -- [ ] Task 3.4: Update `commands.reset_layout` docstring +- [x] Task 3.4 [3b966288]: Update `commands.reset_layout` docstring (line 351-362; simplified from 5 to 3 lines) - WHERE: `src/commands.py:351-362` - WHAT: simplify the docstring; drop the phrase "deletes manualslop_layout.ini so hello_imgui regenerates a fresh" if no longer accurate - HOW: minimal edit via `manual-slop_edit_file` - SAFETY: docstring only, no behavior change -- [ ] Task 3.5: Verify phase 3.1 tests now pass - - HOW: `uv run pytest tests/test_reset_layout.py -v --tb=short` - - Expected: 1 test passes; the `inspect.getsource` assertion holds -- [ ] Task 3.6: Run adjacent test_batch (`tests/test_commands*.py`) - - HOW: `uv run python scripts/run_tests_batched.py --filter test_commands*` - - Expected: no regression -- [ ] Task 3.7: Commit phase 3 with git note - - WHAT: `chore(commands): remove dead test-fixture path from reset_layout` - - HOW: standard atomic commit; git note = "Reset_layout referenced `tests/artifacts/live_gui_workspace/manualslop_layout.ini`, dead code in production. Removed per user directive 2026-06-29: production code must default to the immediate directory." +- [x] Task 3.5 [3b966288]: Verify phase 3.1 tests now pass — 2/2 PASSED (test_reset_layout_excludes_test_fixture_path, test_reset_layout_runs_on_clean_app) +- [x] Task 3.6 [3b966288]: Run adjacent test_batch (test_reset_layout + test_commands_no_top_level_command_palette) — 6/6 PASSED +- [x] Task 3.7 [3b966288]: Commit phase 3 with git note (3b966288 chore(commands): remove dead test-fixture path from reset_layout) ## Phase 4: Verification diff --git a/conductor/tracks/default_layout_install_20260629/state.toml b/conductor/tracks/default_layout_install_20260629/state.toml index 3696cc8e..6bc2c5fb 100644 --- a/conductor/tracks/default_layout_install_20260629/state.toml +++ b/conductor/tracks/default_layout_install_20260629/state.toml @@ -17,7 +17,7 @@ last_updated = "2026-06-29" [phases] phase_1 = { status = "completed", checkpoint_sha = "7577d7d", name = "Move default layout to layouts/ + create src/layouts.py stack (mirror themes/)" } phase_2 = { status = "completed", checkpoint_sha = "3d87f8e7", name = "Install-on-empty-INI in App._post_init" } -phase_3 = { status = "pending", checkpoint_sha = "", name = "Remove hardcoded test-fixture path from production code" } +phase_3 = { status = "completed", checkpoint_sha = "3b966288", name = "Remove hardcoded test-fixture path from production code" } phase_4 = { status = "pending", checkpoint_sha = "", name = "Verification + checkpoint" } [tasks] @@ -45,13 +45,13 @@ t2_8 = { status = "completed", commit_sha = "3d87f8e7", description = "Commit ph t2_9 = { status = "deferred", commit_sha = "", description = "User Manual Verification — DEFERRED to post-merge interactive session (requires desktop screenshot observation, cannot be performed in headless Tier 2 sandbox)" } # Phase 3 (7 tasks) -t3_1 = { status = "pending", commit_sha = "", description = "Write tests/test_reset_layout.py failing test for path cleanup" } -t3_2 = { status = "pending", commit_sha = "", description = "Confirm RED (test reads source via inspect and asserts dead path is gone)" } -t3_3 = { status = "pending", commit_sha = "", description = "Remove hardcoded tests/artifacts/... line from src/commands.py:reset_layout" } -t3_4 = { status = "pending", commit_sha = "", description = "Update commands.reset_layout docstring (line 351-362)" } -t3_5 = { status = "pending", commit_sha = "", description = "Confirm GREEN" } -t3_6 = { status = "pending", commit_sha = "", description = "Run tests/test_commands*.py batch; no regression" } -t3_7 = { status = "pending", commit_sha = "", description = "Commit phase 3 with git note" } +t3_1 = { status = "completed", commit_sha = "3b966288", description = "Write tests/test_reset_layout.py failing test for path cleanup" } +t3_2 = { status = "completed", commit_sha = "3b966288", description = "Confirm RED (test reads source via inspect and asserts dead path is gone)" } +t3_3 = { status = "completed", commit_sha = "3b966288", description = "Remove hardcoded tests/artifacts/... line from src/commands.py:reset_layout" } +t3_4 = { status = "completed", commit_sha = "3b966288", description = "Update commands.reset_layout docstring (line 351-362)" } +t3_5 = { status = "completed", commit_sha = "3b966288", description = "Confirm GREEN — 2/2 PASSED" } +t3_6 = { status = "completed", commit_sha = "3b966288", description = "Run tests/test_commands*.py batch — 6/6 PASSED" } +t3_7 = { status = "completed", commit_sha = "3b966288", description = "Commit phase 3 with git note" } # Phase 4 (6 tasks) t4_1 = { status = "pending", commit_sha = "", description = "Run batched verification per workflow.md §Phase Completion Verification" }