eliminate manual console creation & needs-console detection; use user-error mechanism for process creation failure

project.4coder

@@ -45,16 +45,15 @@ load_paths =
 
 commands =
 {
-  //- rjf: fkey command slots (change locally but do not commit)
-  
   //- rjf: [raddbg]
-  // .f1 = { .win = "raddbg_stable --ipc kill_all && build raddbg telemetry",                                                       .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
+  .f1 = { .win = "raddbg_stable --ipc kill_all && build raddbg telemetry",                                                       .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
   
   //- rjf: [eval_scratch]
-  .f1 = { .win = "raddbg_stable --ipc kill_all && build no_meta eval_scratch && raddbg_stable --ipc bring_to_front && raddbg_stable --ipc run", .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
+  // .f1 = { .win = "raddbg_stable --ipc kill_all && build no_meta eval_scratch && raddbg_stable --ipc bring_to_front && raddbg_stable --ipc run", .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
   
   //- rjf: running target
-  .f3 = { .win = "raddbg_stable --ipc run", .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
+  // .f3 = { .win = "raddbg_stable --ipc run", .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
+  .f3 = { .win = "C:/devel/raddebugger/build/raddbg.exe --capture --user:C:/devel/raddebugger/build/local_dev.raddbg_user --project:C:/devel/raddebugger/build/local_dev.raddbg_project", .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },
   
   //- rjf: local target builds
   .build_raddbg                = { .win = "build raddbg",                .linux = "", .out = "*compilation*", .footer_panel = true, .save_dirty_files = true, .cursor_at_end = false, },

src/demon/win32/demon_core_win32.c

@@ -1229,75 +1229,6 @@ dmn_ctrl_launch(DMN_CtrlCtx *ctx, OS_ProcessLaunchParams *params)
       cmd = str8_list_join(scratch.arena, &args, &join_params);
     }
     
-    //- rjf: determine if process needs a console
-    B32 needs_console = 1;
-    {
-      String8 exe_path = params->cmd_line.first->string;
-      OS_Handle file = os_file_open(OS_AccessFlag_Read|OS_AccessFlag_ShareRead, exe_path);
-      
-      // rjf: find PE offset
-      U32 pe_offset = 0;
-      {
-        U64 dos_magic_off = 0;
-        U16 dos_magic = 0;
-        os_file_read_struct(file, dos_magic_off, &dos_magic);
-        if(dos_magic == PE_DOS_MAGIC)
-        {
-          U64 pe_offset_off = OffsetOf(PE_DosHeader, coff_file_offset);
-          os_file_read_struct(file, pe_offset_off, &pe_offset);
-        }
-      }
-      
-      // rjf: get COFF header
-      B32 got_coff_header = 0;
-      U64 coff_header_off = 0;
-      COFF_FileHeader coff_header = {0};
-      if(pe_offset > 0)
-      {
-        U64 pe_magic_off = pe_offset;
-        U32 pe_magic = 0;
-        os_file_read_struct(file, pe_magic_off, &pe_magic);
-        if(pe_magic == PE_MAGIC)
-        {
-          coff_header_off = pe_magic_off + sizeof(pe_magic);
-          if(os_file_read_struct(file, coff_header_off, &coff_header))
-          {
-            got_coff_header = 1;
-          }
-        }
-      }
-      
-      // rjf: get subsystem from PE header following COFF header
-      PE_WindowsSubsystem subsystem = 0;
-      {
-        U64 opt_header_off = coff_header_off + sizeof(coff_header);
-        switch(coff_header.machine)
-        {
-          default:{}break;
-          case COFF_Machine_X64:
-          {
-            PE_OptionalHeader32Plus hdr = {0};
-            os_file_read_struct(file, opt_header_off, &hdr);
-            subsystem = hdr.subsystem;
-          }break;
-          case COFF_Machine_X86:
-          {
-            PE_OptionalHeader32 hdr = {0};
-            os_file_read_struct(file, opt_header_off, &hdr);
-            subsystem = hdr.subsystem;
-          }break;
-        }
-      }
-      
-      // rjf: determine if we need a console depending on the subsystem
-      if(subsystem == PE_WindowsSubsystem_WINDOWS_GUI)
-      {
-        needs_console = 0;
-      }
-      
-      os_file_close(file);
-    }
-    
     //- rjf: produce environment strings
     String8 env = {0};
     {
@@ -1360,10 +1291,6 @@ dmn_ctrl_launch(DMN_CtrlCtx *ctx, OS_ProcessLaunchParams *params)
       inherit_handles = 1;
     }
     PROCESS_INFORMATION process_info = {0};
-    if(needs_console)
-    {
-      AllocConsole();
-    }
     if(CreateProcessW(0, (WCHAR*)cmd16.str, 0, 0, 1, creation_flags, (WCHAR*)env16.str, (WCHAR*)dir16.str, &startup_info, &process_info))
     {
       // check if we are 32-bit app, and just close it immediately
@@ -1385,18 +1312,7 @@ dmn_ctrl_launch(DMN_CtrlCtx *ctx, OS_ProcessLaunchParams *params)
     }
     else
     {
-      MessageBox(0, "Error starting process.", "Process error", MB_OK|MB_ICONSTOP);
-    }
-    if(needs_console)
-    {
-      FreeConsole();
-    }
-    
-    //- rjf: eliminate all handles which have stuck around from the AllocConsole
-    {
-      SetStdHandle(STD_INPUT_HANDLE, 0);
-      SetStdHandle(STD_OUTPUT_HANDLE, 0);
-      SetStdHandle(STD_ERROR_HANDLE, 0);
+      log_user_errorf("There was an error starting %S.", params->cmd_line.first->string);
     }
   }
   scratch_end(scratch);

src/mule/mule_main.cpp

@@ -2383,6 +2383,11 @@ recursion_stepping_tests(void){
 static void
 debug_string_tests(void)
 {
+  for(int i = 0; i < 100; i += 1)
+  {
+    printf("here is a number: %i\n", i);
+    fflush(stdout);
+  }
 #if _WIN32
   for(int i = 0; i < 100; i += 1)
   {