ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-06-15 16:42:23 -07:00
Code Issues Packages Projects Releases Wiki Activity

do not synthesize simpler expression strings on unsuccessful evaluation

Browse Source
This commit is contained in:
Ryan Fleury
2025-05-05 15:56:28 -07:00
parent 5f3c2d6932
commit b2e24fe760
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/raddbg/raddbg_views.c
+6 -2
View File
@@ -1180,6 +1180,10 @@ rd_watch_row_info_from_row(Arena *arena, EV_Row *row)
{
extra_flags &= ~RD_WatchCellFlag_Expr;
}
if(row->eval.msgs.max_kind != E_MsgKind_Null)
{
extra_flags = RD_WatchCellFlag_Expr|RD_WatchCellFlag_NoEval;
}
rd_watch_cell_list_push_new(arena, &info.cells, RD_WatchCellKind_Eval, row->eval, .flags = extra_flags|RD_WatchCellFlag_Button|RD_WatchCellFlag_Indented, .pct = 1.f);
}
@@ -1712,8 +1716,8 @@ rd_info_from_watch_row_cell(Arena *arena, EV_Row *row, EV_StringFlags string_fla
expr_string = cell->eval.string;
// rjf: try to form a simpler expression string out of the expression tree itself, *if* this
// is not an editable expression
if(!(block_type->flags & E_TypeFlag_EditableChildren))
// is not an editable expression, and if this evaluation was successful
if(!(block_type->flags & E_TypeFlag_EditableChildren) && cell->eval.msgs.max_kind == E_MsgKind_Null)
{
// rjf: first, locate a notable expression - we special-case things like member accesses
// or array indices, so we should grab those if possible