more inline visualization; do not require qualifier if view rule names collide with locals

This commit is contained in:
Ryan Fleury
2025-02-11 16:36:20 -08:00
parent 98ec6ee3bb
commit 6c37db2105
5 changed files with 6 additions and 15 deletions
+1
View File
@@ -727,6 +727,7 @@ d_symbol_name_from_dbgi_key_voff(Arena *arena, DI_Key *dbgi_key, U64 voff, U64 d
if(decorated && inline_site->type_idx != 0)
{
String8List list = {0};
str8_list_pushf(scratch.arena, &list, "[inlined] ");
e_type_lhs_string_from_key(scratch.arena, type, &list, 0, 0);
str8_list_push(scratch.arena, &list, name);
e_type_rhs_string_from_key(scratch.arena, type, &list, 0);
+1 -4
View File
@@ -2090,10 +2090,7 @@ e_parse_expr_from_text_tokens__prec(Arena *arena, String8 text, E_TokenArray *to
// rjf: parse all argument expressions
E_Expr *callee_expr = atom;
E_Expr *call_expr = e_push_expr(arena, E_ExprKind_Call, token_string.str);
if(callee_expr->kind == E_ExprKind_LeafIdent)
{
call_expr->string = callee_expr->string;
}
call_expr->string = callee_expr->string;
e_expr_push_child(call_expr, callee_expr);
E_TokenArray args_parse_tokens = e_token_array_make_first_opl(it, it_opl);
E_Parse args_parse = e_parse_expr_from_text_tokens__prec(arena, text, &args_parse_tokens, e_max_precedence, max_U64);
-8
View File
@@ -1286,14 +1286,6 @@ rd_info_from_watch_row_cell(Arena *arena, EV_Row *row, EV_StringFlags string_fla
result.eval = e_eval_from_expr(scratch.arena, root_expr);
result.string = rd_value_string_from_eval(arena, string_flags, 10, font, font_size, max_size_px, result.eval);
result.can_edit = (ev_type_key_is_editable(result.eval.type_key) && result.eval.mode == E_Mode_Offset);
//- rjf: determine if inlined
E_Type *type = e_type_from_key__cached(result.eval.type_key);
if(type->depth > 0)
{
result.is_inlined = 1;
}
scratch_end(scratch);
}break;
-1
View File
@@ -97,7 +97,6 @@ struct RD_WatchRowCellInfo
B32 is_button;
B32 can_edit;
B32 is_errored;
B32 is_inlined;
String8 error_tooltip;
String8 inheritance_tooltip;
RD_ViewUIRule *view_ui_rule;
+4 -2
View File
@@ -826,8 +826,10 @@ r_end_frame(void)
tex = next)
{
next = tex->next;
tex->view->lpVtbl->Release(tex->view);
tex->texture->lpVtbl->Release(tex->texture);
tex->view->lpVtbl->Release(tex->view);
tex->texture->lpVtbl->Release(tex->texture);
tex->view = 0;
tex->texture = 0;
tex->generation += 1;
SLLStackPush(r_d3d11_state->first_free_tex2d, tex);
}