ed
df7bda6e0d
ROOT CAUSE: When child windows used ImVec2(0, 0) for auto-fill, the
child's reported height was unstable inside tab items (especially when
the parent tab was inside a tab_bar inside a window). Result: the
scrollable child rendered with a fixed smaller height, showing only the
first half of the content, with empty space below.
FIX: Use imgui.get_content_region_avail() to compute explicit dimensions
and pass them to begin_child. Now the child fills the full available area
inside the tab content.
- render_comms_history_panel: avail.x, avail.y
- render_prior_session_view: same, plus added entry count indicator next
to the Exit Prior Session button ({N} entries) for at-a-glance info
Tests:
- test_comms_scroll_no_clipping.py: verifies comms_scroll child uses
explicit (non-zero) size
- test_prior_session_no_clipping.py: same for prior_scroll child
- test_log_management_first_open.py: minor cleanup
- 42/42 broad regression pass
44 lines
2.2 KiB
Python
44 lines
2.2 KiB
Python
from unittest.mock import patch, MagicMock
|
|
from src.gui_2 import render_prior_session_view
|
|
|
|
def test_prior_session_view_opens_scroll_child_with_explicit_size(app_instance):
|
|
app_instance.prior_disc_entries = [{"role": "User", "content": f"entry {i}", "collapsed": False, "ts": f"t{i}"} for i in range(30)]
|
|
app_instance.perf_profiling_enabled = False
|
|
with patch("src.gui_2.imgui") as mock_imgui, patch("src.gui_2.imscope") as mock_imscope, patch("src.gui_2.theme") as mock_theme:
|
|
_avail = MagicMock(); _avail.x = 800.0; _avail.y = 600.0
|
|
mock_imgui.get_content_region_avail = MagicMock(return_value=_avail)
|
|
mock_imscope.style_color = MagicMock()
|
|
mock_imscope.style_color.return_value.__enter__ = MagicMock()
|
|
mock_imscope.style_color.return_value.__exit__ = MagicMock()
|
|
mock_imscope.child = MagicMock()
|
|
mock_imscope.child.return_value.__enter__ = MagicMock()
|
|
mock_imscope.child.return_value.__exit__ = MagicMock()
|
|
mock_imscope.id = MagicMock()
|
|
mock_imscope.id.return_value.__enter__ = MagicMock()
|
|
mock_imscope.id.return_value.__exit__ = MagicMock()
|
|
mock_imgui.button = MagicMock(return_value=False)
|
|
mock_imgui.same_line = MagicMock()
|
|
mock_imgui.text_colored = MagicMock()
|
|
mock_imgui.text = MagicMock()
|
|
mock_imgui.separator = MagicMock()
|
|
_mock_clipper = MagicMock()
|
|
_mock_clipper.step.side_effect = [True, False]
|
|
_mock_clipper.display_start = 0
|
|
_mock_clipper.display_end = 30
|
|
mock_imgui.ListClipper = MagicMock(return_value=_mock_clipper)
|
|
mock_imgui.ListClipper.return_value.begin = MagicMock()
|
|
mock_theme.ai_text_style = MagicMock()
|
|
mock_theme.ai_text_style.return_value.__enter__ = MagicMock()
|
|
mock_theme.ai_text_style.return_value.__exit__ = MagicMock()
|
|
app_instance.controller = MagicMock()
|
|
try:
|
|
render_prior_session_view(app_instance)
|
|
except Exception as e:
|
|
import pytest
|
|
pytest.fail(f"render_prior_session_view raised: {e}")
|
|
assert mock_imscope.child.called, "prior_scroll child should be opened"
|
|
call_args = mock_imscope.child.call_args
|
|
kwargs = call_args[1] if len(call_args) > 1 else {}
|
|
size_x, size_y = kwargs.get("size_x", 0), kwargs.get("size_y", 0)
|
|
assert size_x == 800.0 and size_y == 600.0, f"prior_scroll should use explicit content region size, got ({size_x}, {size_y})"
|