ed c12d5b6d82 refactor(models,paths,presets,summary_cache): remove Optional returns (Phase 6 batch 1) ...

Phase 6: Eliminate Optional[T] returns (FR5) - BATCH 1 of 7
Before: 8 Optional[T] return types across 4 files
After:  0 (replaced with default-zero return values)
Delta:  -8 sites

Per conductor/code_styleguides/error_handling.md "Optional[X] ban":
- "Use Result[T] for any function that can fail at runtime."
- "Use nil-sentinel dataclasses for 'no result'."

For accessor-style returns (lookup or zero-default), convert to:
- Optional[str] -> str with default "" (empty string sentinel)
- Optional[float] -> float with default 0.0
- Optional[int] -> int with default 0
- Optional[Path] -> Path with default Path("") or project_root

Specific changes:
- src/models.py:765-789: Persona.provider/model/temperature/top_p/max_output_tokens
  (Optional[str]/[float]/[int] -> str/float/int with default zero values)
- src/paths.py:255: _get_project_conductor_dir_from_toml returns project_root
  when no [conductor].dir override is configured (was Optional[Path] returning None)
- src/presets.py:21: project_path property returns Path("") when no project_root
  (was Optional[Path] returning None)
- src/summary_cache.py:57: get_summary returns "" when hash mismatch (was
  Optional[str] returning None)

Test updates:
- tests/test_persona_models.py:64-69: test_persona_defaults now expects
  "" / 0.0 instead of None
- tests/test_summary_cache.py:25, 32, 58: get_summary assertions now
  expect "" instead of None

Verification:
- audit_weak_types --strict: OK (107 <= 112 baseline)
- 13 tests pass (test_summary_cache, test_paths, test_presets,
  test_persona_models)
- py_check_syntax: OK on all changed files

REMAINING: ~22 Optional[T] returns in:
- src/command_palette.py (1)
- src/diff_viewer.py (2)
- src/external_editor.py (3)
- src/file_cache.py (7)
- src/fuzzy_anchor.py (1)
- src/models.py (1)
- src/multi_agent_conductor.py (1)
- src/patch_modal.py (1)
- src/project_manager.py (1)
- src/session_logger.py (1)
- src/app_controller.py (3)

2026-06-26 05:01:15 -04:00

..

__init__.py

feat(src): Move core implementation files to src/ directory

2026-03-04 09:55:44 -05:00

aggregate.py

feat(metadata): NIL_METADATA sentinel + migrate _build_files_section_from_items

2026-06-24 15:22:31 -04:00

ai_client.py

refactor(rag_engine,ai_client): rag_engine.search returns List[RAGChunk] directly

2026-06-26 04:54:02 -04:00

api_hook_client.py

refactor(project_manager,aggregate,api_hook_client): replace weak type sites with aliases

2026-06-21 12:39:17 -04:00

api_hooks_helpers.py

add note aobut hook helpers...

2026-06-05 23:03:45 -04:00

api_hooks.py

feat(api_hooks): add WebSocketMessage + JsonValue type (t5_1-t5_8)

2026-06-22 01:00:06 -04:00

app_controller.py

refactor(gui_2,app_controller): remove hasattr defensive checks + fix _do_generate type

2026-06-26 04:49:55 -04:00

beads_client.py

more organization

2026-06-06 10:24:22 -04:00

bg_shader.py

improved startup first frame boot

2026-06-07 01:08:31 -04:00

command_palette.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

commands.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

conductor_tech_lead.py

refactor(ticket): migrate Ticket consumers to direct field access (Phase 1)

2026-06-25 18:20:45 -04:00

context_presets.py

refactor(src): Phase 10.2 batch 4 - aggregate + api_hooks + context_presets + external_editor

2026-06-17 22:38:17 -04:00

cost_tracker.py

feat(grok,llama): add to PROVIDERS; add 11 pricing entries (3 Grok + 8 Llama)

2026-06-11 02:02:56 -04:00

dag_engine.py

fix(imports): break models<->dag_engine circular dependency

2026-06-06 13:30:18 -04:00

diff_viewer.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

events.py

Revert "merge: tier2/phase2_4_5_call_site_completion_20260621 (parent + follow-up + Phase 6e analysis)"

2026-06-21 22:39:14 -04:00

external_editor.py

refactor(src): eliminate 11 T | None legacy wrappers in favor of _result API

2026-06-25 11:18:03 -04:00

file_cache.py

refactor(src): file_cache.py Phase 11.3.5 - extract _get_mtime_safe

2026-06-18 00:14:17 -04:00

fuzzy_anchor.py

more organization

2026-06-06 10:24:22 -04:00

gemini_cli_adapter.py

more organization

2026-06-06 10:24:22 -04:00

gui_2.py

refactor(gui_2,app_controller): remove hasattr defensive checks + fix _do_generate type

2026-06-26 04:49:55 -04:00

history.py

more organization

2026-06-06 10:24:22 -04:00

hot_reloader.py

refactor(src): Phase 10.2 batch 6 - hot_reloader + warmup + startup_profiler

2026-06-17 22:42:10 -04:00

imgui_scopes.py

more organization

2026-06-06 10:24:22 -04:00

io_pool.py

fix(io_pool): correct stale docstring (4 threads -> 8 threads)

2026-06-10 20:50:55 -04:00

log_pruner.py

more organization

2026-06-06 10:24:22 -04:00

log_registry.py

feat(log): add Session + SessionMetadata dataclasses (t4_1-t4_8)

2026-06-22 01:00:00 -04:00

markdown_helper.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

markdown_table.py

more organization

2026-06-06 10:24:22 -04:00

mcp_client.py

refactor(mcp_client,gui_2): migrate ToolDefinition consumers (Phase 8)

2026-06-25 20:25:50 -04:00

mcp_tool_specs.py

fix(audit): replace dict[str, Any] with JsonValue TypeAlias (5+ weak sites)

2026-06-24 09:41:50 -04:00

mma_prompts.py

began to go through the files and organize imports and gui_2.py's new context defs

2026-06-05 21:44:41 -04:00

models.py

refactor(models,paths,presets,summary_cache): remove Optional returns (Phase 6 batch 1)

2026-06-26 05:01:15 -04:00

module_loader.py

fix(ai_client): use parent package lookup to fix google.genai circular import

2026-06-06 19:03:38 -04:00

multi_agent_conductor.py

refactor(src): eliminate 11 T | None legacy wrappers in favor of _result API

2026-06-25 11:18:03 -04:00

openai_compatible.py

feat(openai): add src/openai_schemas.py + refactor openai_compatible.py (t2_1-t2_7)

2026-06-22 00:59:42 -04:00

openai_schemas.py

refactor(ai_client,openai_schemas): migrate API response + _repair_minimax (Phase 5 part 2)

2026-06-25 20:19:27 -04:00

orchestrator_pm.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

outline_tool.py

refactor(src): Phase 10.2 batch 2 - outline_tool Result[T] migration

2026-06-17 22:31:35 -04:00

patch_modal.py

began to go through the files and organize imports and gui_2.py's new context defs

2026-06-05 21:44:41 -04:00

paths.py

refactor(models,paths,presets,summary_cache): remove Optional returns (Phase 6 batch 1)

2026-06-26 05:01:15 -04:00

performance_monitor.py

more organization

2026-06-06 11:08:07 -04:00

personas.py

more organization

2026-06-06 11:08:07 -04:00

presets.py

refactor(models,paths,presets,summary_cache): remove Optional returns (Phase 6 batch 1)

2026-06-26 05:01:15 -04:00

project_manager.py

refactor(src): eliminate 11 T | None legacy wrappers in favor of _result API

2026-06-25 11:18:03 -04:00

provider_state.py

fix(provider_state): change Lock to RLock to prevent re-entrant deadlock

2026-06-24 23:30:15 -04:00

qwen_adapter.py

refactor(ai_client): classifier functions return ErrorInfo instead of ProviderError

2026-06-12 18:32:05 -04:00

rag_engine.py

refactor(rag_engine,ai_client): rag_engine.search returns List[RAGChunk] directly

2026-06-26 04:54:02 -04:00

result_types.py

feat(result_types): add Result, ErrorInfo, ErrorKind, NilPath, NilRAGState, OK

2026-06-12 16:38:09 -04:00

session_logger.py

refactor(src): eliminate 11 T | None legacy wrappers in favor of _result API

2026-06-25 11:18:03 -04:00

shaders.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00

shell_runner.py

refactor(src): eliminate 11 T | None legacy wrappers in favor of _result API

2026-06-25 11:18:03 -04:00

startup_profiler.py

refactor(src): startup_profiler.py Phase 11.3.2 - extract _log_phase_output

2026-06-18 00:10:16 -04:00

summarize.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

summary_cache.py

refactor(models,paths,presets,summary_cache): remove Optional returns (Phase 6 batch 1)

2026-06-26 05:01:15 -04:00

synthesis_formatter.py

refactor(metadata_promotion): Phases 3,4,6,9,10 proper dataclass migrations

2026-06-25 19:20:03 -04:00

theme_2.py

refactor(src): Phase 10.2 batch 5 - log_registry + models + multi_agent_conductor + theme_2

2026-06-17 22:39:18 -04:00

theme_models.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

theme_nerv_fx.py

fix(theme): correct add_rect argument types in AlertPulsing.render

2026-06-17 10:26:32 -04:00

theme_nerv.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00

thinking_parser.py

fix(thinking_parser): add <think> (half-width) marker support (doeh cleanup Phase 4.1)

2026-06-15 14:25:54 -04:00

tool_bias.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00

tool_presets.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00

type_aliases.py

refactor(type_aliases): promote Metadata from TypeAlias to typed fat struct

2026-06-26 04:27:56 -04:00

vendor_capabilities.py

feat(capability_matrix): add anthropic, gemini, deepseek registry entries

2026-06-11 21:35:32 -04:00

vendor_state.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00

warmup.py

refactor(src): Phase 12.6.2-12.6.13 - migrate 16 small files to Result[T]

2026-06-18 10:21:24 -04:00

workspace_manager.py

some organization pass, still need to review a bunch

2026-06-06 00:21:36 -04:00