manual_slop/conductor/tracks/test_patch_fixes_20260513/plan.md

Track: Fix Test Patches for ai_client_stub Integration

Context

After the refactor to use ai_client_stub as the module alias for app_controller, several tests fail because they use patch('src.ai_client.X') which doesn't properly reach the stub's module-level functions. This is a pre-existing architectural issue that needs fixing.

Root Cause Analysis

When tests use patch('src.ai_client.get_current_tier', return_value='Tier 3'):

1. patch creates/overrides src.ai_client in the src package namespace
2. But app_controller does from src import ai_client_stub as ai_client at module load time
3. The ai_client local reference in app_controller points directly to ai_client_stub module
4. Patch modifies src.ai_client (a different object), not src.ai_client_stub
5. Result: Functions in ai_client_stub aren't patched

Solution Applied

Changed all patches from patch('src.ai_client.X') to patch('src.ai_client_stub.X') where the stub was the actual target.

Also updated module imports in tests to use ai_client_stub instead of ai_client where appropriate.

Tasks Completed

1. Fix test_on_tool_log_offloading - change patch path to src.ai_client_stub.get_current_tier
2. Fix test_redundant_calls_in_process_pending_gui_tasks - change patches to src.ai_client_stub
3. Fix test_gcli_path_updates_adapter - use ai_client_stub module reference
4. Fix test_telemetry_data_updates_correctly - change patch to src.ai_client_stub.get_token_stats
5. Fix test_gui_updates_on_event - same as above
6. Run batch test to verify affected tests pass

Test Results

51 tests passing in the core batch:

• test_symbol_lookup.py (7)
• test_ai_client_concurrency.py (1)
• test_app_controller_offloading.py (2)
• test_mma_agent_focus_phase1.py (8)
• test_conductor_engine_v2.py (10)
• test_conductor_tech_lead.py (7)
• test_mma_dashboard_refresh.py (2)
• test_mma_ticket_actions.py (2)
• test_gui_phase3.py (3)
• test_process_pending_gui_tasks.py (4)
• test_gui_updates.py (3)

Known Pre-Existing Failures (NOT related to this fix)

1. test_ai_client_proxy_run.py::test_initial_state_variables - AIProxyClient missing _pending_lock attribute
2. test_discussion_takes_gui.py - incomplete mock setup for imgui.input_text_multiline

Files Modified

• tests/test_app_controller_offloading.py
• tests/test_process_pending_gui_tasks.py
• tests/test_gui_updates.py

Checkpoint

Commit: 169fe520 - fix(ai_client_stub): add module-level import for GeminiCliAdapter Additional commits for test fixes to follow.