Private
Public Access
0
0
Files
manual_slop/tests
ed 6bb7f92275 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: refactor(mcp_client): migrate 8 Batch B sites to Result[T]
Phase 4 Batch B (8 INTERNAL_BROAD_CATCH sites in mcp_client.py):

Added _result variants inside the Result Variants region:
  - get_git_diff_result (subprocess.run + CalledProcessError)
  - ts_c_get_skeleton_result (ASTParser.get_skeleton)
  - ts_c_get_code_outline_result (ASTParser.get_code_outline)
  - ts_c_get_definition_result (ASTParser.get_definition)
  - ts_c_get_signature_result (ASTParser.get_signature)
  - ts_c_update_definition_result (ASTParser.update_definition)
  - ts_cpp_get_skeleton_result (ASTParser.get_skeleton with lang=cpp)
  - ts_cpp_get_code_outline_result (ASTParser.get_code_outline with lang=cpp)

Plus 5 internal _ast_* helpers (extract ASTParser boilerplate).

Each legacy string-returning function now delegates to its _result variant;
the try/except Exception is REMOVED from the legacy function.

Updated test_baseline_result.py:
  - Phase 3 tests loosened (BC<=32, total MIG<=80)
  - Phase 4 tests added (BC=24, total MIG=72, modules import cleanly)

Audit: mcp_client BC 32 -> 24. Total MIG 80 -> 72.
2026-06-20 08:41:32 -04:00
..