manual_slop/conductor/tracks/fix_remaining_tests_20260513/spec.md

Track: Fix Pre-Existing Test Failures

Context

Two test failures that are not related to the ai_client_stub integration fix but need to be resolved for full test suite passing.

Failed Tests

1. test_ai_client_proxy_run.py::test_initial_state_variables

File: tests/test_ai_client_proxy_run.py Error: AssertionError: Missing _pending_lock

Root Cause: The test expects AIProxyClient to have a _pending_lock attribute (a threading lock), but the class doesn't have it.

Fix: Add _pending_lock: threading.Lock to AIProxyClient.__init__ in src/ai_client_proxy.py

2. test_discussion_takes_gui.py (both tests)

File: tests/test_discussion_takes_gui.py Error: ValueError: not enough values to unpack (expected 2, got 0) at src/gui_2.py:3668

Root Cause: The test mocks imgui.input_text and imgui.input_int but NOT imgui.input_text_multiline. When _render_synthesis_panel calls imgui.input_text_multiline(...), the mock returns None (not unpacked), causing the unpacking failure.

Fix: Add mock for imgui.input_text_multiline in the test setup.

Tasks

1. Fix AIProxyClient - add _pending_lock threading.Lock to init
2. Fix test_discussion_takes_gui.py - add mock for input_text_multiline
3. Run tests to verify both fixes
4. Run full test suite to confirm all pass