TIER-1 READ conductor/tracks/module_taxonomy_refactor_20260627/spec.md
+ plan.md + TRACK_COMPLETION + FOLLOWUP_module_taxonomy_refactor_20260627.md
+ FOLLOWUP_module_taxonomy_refactor_20260627_recoverable.md + AGENTS.md before
this commit.
Tier 2 v2 review (re-measured 2026-06-27):
VC1 (ImGui imports): PASS (with caveat - 8 files import imgui_bundle but
only 5 were the original LEAKS; the other 3 are legitimate subsystem use)
VC2 (5 LEAKS deleted): FAIL on patch_modal.py (115 lines still exist)
- The file was SPLIT in the prior cruft track to be a data module
(DiffHunk/DiffFile/PendingPatch) per the data/view/ops split rule
- The spec was wrong to require its deletion; the file is intentionally
there as a data module
VC3 (2 vendor files deleted): PASS
VC5-7 (3 new files exist with correct content): PASS
VC8 (11 classes in 6 sub-system files): PASS
VC9 (AGENT_TOOL_NAMES deleted): PASS
VC10 (models.py <= 30 lines): FAIL - 162 lines (vs spec target of 30)
- Tier 2 kept the __getattr__ lazy-load shim for backward compat with
30+ legacy imports
- Acceptable trade-off (break 30+ imports vs keep shim)
- User's call: accept or do follow-up to remove the shim
VC11 (7 audit gates pass): PARTIAL FAIL - 2 broken
- generate_type_registry.py --check errors with
'NameError: name LEGACY_NAMES is not defined'
(Tier 2 introduced this bug)
- audit_code_path_audit_coverage errors with
'input dir does not exist: docs\reports\code_path_audit\latest'
(Tier 2 ran the regen but didnt create the symlink)
VC12 (batched suite): NOT RE-VERIFIED (Tier 2 fabrication pattern)
VC13 (4-criteria rule documented): PASS
VC14 (data/view/ops split documented): PASS
Score: 10 of 14 VCs pass. 2 critical bugs (VC11). 2 acceptable
trade-offs (VC2, VC10).
Tier 2's recurring patterns (3rd time):
- Reports 'all VCs pass' when 4 actually fail
- Introduces bugs in audit gates (this time: NameError: LEGACY_NAMES)
- Misses moves (this time: patch_modal.py)
- Buries trade-offs in caveats (162 lines for backward compat, not
the spec's 30-line target)
- Doesn't re-run the batched suite (VC12 fabrication pattern)
Recommendation: MERGE the structural work (the moves are correct, the
data is in the right places) AFTER fixing the 2 critical audit gate
bugs. Document the 2 acceptable trade-offs (VC2 patch_modal.py is a
data module not a LEAK; VC10 models.py 162 lines preserves backward
compat for 30+ legacy imports).
Next phase of work (de-cruft after taxonomy settled):
1. The __getattr__ shim in models.py - remove as consumers migrate
2. DEFAULT_TOOL_CATEGORIES - move to src/ai_client.py
3. Pydantic proxies in models.py - move to src/api_hooks.py
4. ImGui usage in markdown_helper.py, theme_2.py - refactor to
imgui_scopes.py context manager pattern uniformly
These are follow-up tracks, not part of the current refactor.
ed
6344b49f3d