ed
effa24a7ae
The 2 tests in test_symbol_parsing.py mock src.ai_client.send but
production now uses send_result (migrated by doeh_test_thinking_cleanup_20260615
commit 24ba2499). Mocks receive 0 calls; tests fail with
"send was called 0 times".
Changes:
- Replace patch(src.ai_client.send) with patch(src.ai_client.send_result)
- Rename mock_send to mock_send_result
- Set return_value=Result(data="mocked response")
- Add "from src.result_types import Result" import
All 2 tests in test_symbol_parsing.py pass (were 2 pre-existing failures).
85 lines
2.8 KiB
Python
85 lines
2.8 KiB
Python
import pytest
|
|
from unittest.mock import MagicMock, patch
|
|
from pathlib import Path
|
|
from src.app_controller import AppController
|
|
from src.events import UserRequestEvent
|
|
from src import events
|
|
from src.result_types import Result
|
|
|
|
@pytest.fixture
|
|
def controller():
|
|
with (
|
|
patch('src.app_controller.AppController.load_config', return_value={
|
|
"ai": {"provider": "gemini", "model": "model-1"},
|
|
"projects": {"paths": [], "active": ""},
|
|
"gui": {"show_windows": {}}
|
|
}),
|
|
patch('src.project_manager.load_project', return_value={}),
|
|
patch('src.project_manager.migrate_from_legacy_config', return_value={}),
|
|
patch('src.project_manager.save_project'),
|
|
patch('src.session_logger.open_session'),
|
|
patch('src.session_logger.reset_session'),
|
|
patch('src.app_controller.AppController._init_ai_and_hooks'),
|
|
patch('src.app_controller.AppController._fetch_models')
|
|
):
|
|
c = AppController()
|
|
# Mock necessary state
|
|
c.ui_files_base_dir = "."
|
|
c.event_queue = MagicMock()
|
|
return c
|
|
|
|
def test_handle_request_event_appends_definitions(controller):
|
|
# Setup
|
|
file_items = [{"path": "src/models.py", "entry": "src/models.py"}]
|
|
event = UserRequestEvent(
|
|
prompt="Explain @Track object",
|
|
stable_md="stable_md",
|
|
file_items=file_items,
|
|
disc_text="disc_text",
|
|
base_dir="."
|
|
)
|
|
|
|
# Mock symbol helpers
|
|
with (
|
|
patch('src.app_controller.parse_symbols', return_value=["Track"]) as mock_parse,
|
|
patch('src.app_controller.get_symbol_definition', return_value=("src/models.py", "class Track: pass", 42)) as mock_get_def,
|
|
patch('src.ai_client.send_result', return_value=Result(data="mocked response")) as mock_send_result
|
|
):
|
|
# Execute
|
|
controller._handle_request_event(event)
|
|
|
|
# Verify
|
|
mock_parse.assert_called_once_with("Explain @Track object")
|
|
mock_get_def.assert_called_once()
|
|
|
|
# Check if enriched prompt was sent to AI
|
|
expected_suffix = "\n\n[Definition: Track from src/models.py (line 42)]\n```python\nclass Track: pass\n```"
|
|
mock_send_result.assert_called_once()
|
|
args, kwargs = mock_send_result.call_args
|
|
sent_prompt = args[1]
|
|
assert sent_prompt == "Explain @Track object" + expected_suffix
|
|
|
|
def test_handle_request_event_no_symbols(controller):
|
|
# Setup
|
|
file_items = [{"path": "src/models.py", "entry": "src/models.py"}]
|
|
event = UserRequestEvent(
|
|
prompt="Just a normal prompt",
|
|
stable_md="stable_md",
|
|
file_items=file_items,
|
|
disc_text="disc_text",
|
|
base_dir="."
|
|
)
|
|
|
|
with (
|
|
patch('src.app_controller.parse_symbols', return_value=[]) as mock_parse,
|
|
patch('src.ai_client.send_result', return_value=Result(data="mocked response")) as mock_send_result
|
|
):
|
|
# Execute
|
|
controller._handle_request_event(event)
|
|
|
|
# Verify
|
|
mock_send_result.assert_called_once()
|
|
args, kwargs = mock_send_result.call_args
|
|
sent_prompt = args[1]
|
|
assert sent_prompt == "Just a normal prompt"
|