ed
801321c125
ROOT CAUSE: The ListClipper in render_prior_session_view was being
tripped up by the variable heights of discussion entries (huge system
prompts vs small tool results). When the first entry was very tall
(system prompt), the clipper would compute the visible range assuming
uniform item heights, leading to underflow/overflow on subsequent
items. The user saw only the first ~8 entries with massive empty
space below ('early clipping').
FIX: Replace the ListClipper with a direct for loop over
app.prior_disc_entries. With 233 entries, performance is acceptable
and each entry renders correctly. The user can still scroll the
parent imscope.child window if content overflows.
Tests:
- Updated test_prior_session_no_clipping.py to set entries on
app_instance.controller.prior_disc_entries (the App's __getattr__
proxies attribute reads to the controller, so the set must go to
the controller directly).
- 28/28 broad regression pass
46 lines
2.3 KiB
Python
46 lines
2.3 KiB
Python
from unittest.mock import patch, MagicMock
|
|
from src.gui_2 import render_prior_session_view
|
|
|
|
def test_prior_session_view_opens_scroll_child_with_explicit_size(app_instance):
|
|
app_instance.controller.prior_disc_entries = [{"role": "User", "content": f"entry {i}", "collapsed": False, "ts": f"t{i}"} for i in range(30)]
|
|
app_instance.perf_profiling_enabled = False
|
|
with patch("src.gui_2.imgui") as mock_imgui, patch("src.gui_2.imscope") as mock_imscope, patch("src.gui_2.theme") as mock_theme:
|
|
_avail = type("P", (), {"x": 800.0, "y": 600.0})()
|
|
mock_imgui.get_content_region_avail = MagicMock(return_value=_avail)
|
|
def _imvec2(x, y=0): m = MagicMock(); m.x = float(x); m.y = float(y); return m
|
|
mock_imgui.ImVec2 = _imvec2
|
|
mock_imscope.style_color = MagicMock()
|
|
mock_imscope.style_color.return_value.__enter__ = MagicMock()
|
|
mock_imscope.style_color.return_value.__exit__ = MagicMock()
|
|
mock_imscope.child = MagicMock()
|
|
mock_imscope.child.return_value.__enter__ = MagicMock()
|
|
mock_imscope.child.return_value.__exit__ = MagicMock()
|
|
mock_imscope.id = MagicMock()
|
|
mock_imscope.id.return_value.__enter__ = MagicMock()
|
|
mock_imscope.id.return_value.__exit__ = MagicMock()
|
|
mock_imgui.button = MagicMock(return_value=False)
|
|
mock_imgui.same_line = MagicMock()
|
|
mock_imgui.text_colored = MagicMock()
|
|
mock_imgui.text = MagicMock()
|
|
mock_imgui.separator = MagicMock()
|
|
mock_theme.ai_text_style = MagicMock()
|
|
mock_theme.ai_text_style.return_value.__enter__ = MagicMock()
|
|
mock_theme.ai_text_style.return_value.__exit__ = MagicMock()
|
|
try:
|
|
render_prior_session_view(app_instance)
|
|
except Exception as e:
|
|
import pytest
|
|
pytest.fail(f"render_prior_session_view raised: {e}")
|
|
assert mock_imscope.child.called, "prior_scroll child should be opened"
|
|
call_args = mock_imscope.child.call_args
|
|
args_list = call_args[0] if call_args[0] else []
|
|
size_arg = args_list[1] if len(args_list) > 1 else 0
|
|
if hasattr(size_arg, 'x'):
|
|
size_x, size_y = size_arg.x, size_arg.y
|
|
else:
|
|
size_x = size_arg
|
|
size_y = 0
|
|
assert size_x == 800.0 and size_y == 600.0, f"prior_scroll should use explicit content region size, got ({size_x}, {size_y})"
|
|
id_calls = [c for c in mock_imscope.id.call_args_list]
|
|
assert len(id_calls) == 30, f"expected 30 imscope.id calls (one per entry), got {len(id_calls)}"
|