Private
Public Access
0
0
Files
manual_slop/tests
ed 40a60e63d6 refactor(ai_client): migrate 3 run_tier4_* sites to Result[T] (Phase 10 sites 7+8+9)
All 3 run_tier4_* functions had the same pattern:
  try: ... AI call ...
  except Exception as e: return '[XXX FAILED] {e}' (or None)

Per TIER1_REVIEW: empty-default return = MIGRATE to Result[T].

New helpers:
- _run_tier4_analysis_result(stderr: str) -> Result[str]
  Returns Result(data=analysis) on success, Result(data='', errors=[ErrorInfo])
  on SDK failure. Empty stderr short-circuits to Result(data='').
- _run_tier4_patch_callback_result(stderr: str, base_dir: str) -> Result[Optional[str]]
  Returns Result(data=patch) on valid diff, Result(data=None) when no
  valid diff, Result(data=None, errors=[ErrorInfo]) on SDK failure.
- _run_tier4_patch_generation_result(error: str, file_context: str) -> Result[str]
  Returns Result(data=patch) on success, Result(data='', errors=[ErrorInfo])
  on SDK failure. Empty error short-circuits to Result(data='').

Legacy wrappers delegate to _result helpers and return result.data,
preserving original signatures (str for sites 7,9; Optional[str] for site 8).

Existing tier4 tests pass (13/13 in test_tier4_patch_generation +
test_tier4_interceptor).

Audit: ai_client BC 3 -> 0. All 9 Phase 10 BC sites migrated.
2026-06-20 13:17:41 -04:00
..
2026-03-05 17:13:59 -05:00
2026-05-10 15:14:54 -04:00
2026-05-20 07:51:58 -04:00
2026-03-05 16:37:30 -05:00
2026-03-05 17:13:59 -05:00
2026-03-05 16:37:30 -05:00
2026-03-07 20:32:59 -05:00
2026-03-05 15:10:53 -05:00
2026-03-12 19:08:51 -04:00
2026-05-20 07:51:58 -04:00
2026-05-20 07:51:58 -04:00
ok
2026-03-07 21:40:40 -05:00