ed
0506c5da63
TIER-2 READ AGENTS.md, conductor/workflow.md, conductor/edit_workflow.md,
conductor/tier2/githooks/forbidden-files.txt,
conductor/tracks/tier2_leak_prevention_20260620/spec.md,
conductor/code_styleguides/data_oriented_design.md,
conductor/code_styleguides/error_handling.md,
conductor/code_styleguides/type_aliases.md before Phase 1.
Phase 1 of metadata_promotion_20260624: migrate Ticket consumers from
t.get('key', default) / t['key'] to direct field access (t.id, t.status, etc.).
Changes:
- self.active_tickets: list[Metadata] -> list[models.Ticket]
- _deserialize_active_track_result populates self.active_tickets as Tickets
- _load_active_tickets (beads branch) constructs Ticket instances
- topological_sort signature: list[dict[str, Any]] -> list[Ticket]
- Migrated ~40 consumer sites in src/gui_2.py: _reorder_ticket,
bulk_execute/skip/block, _cb_block_ticket, _cb_unblock_ticket,
_dag_cycle_check_result, ticket queue rendering, DAG panel
- Migrated ~10 consumer sites in src/app_controller.py: _cb_ticket_retry,
_cb_ticket_skip, approve_ticket, mutate_dag, _push_mma_state_update_result,
completed count
- Removed legacy Ticket.get() compat method (Task 1.5)
- Added tests/test_metadata_promotion_phase1.py with 15 regression-guard tests
- Updated existing tests to construct Ticket instances instead of dicts
Verified: 1885 of 1910 unit tests pass (25 pre-existing failures unrelated
to Ticket migration; many are live_gui/sim tests that need a running GUI).
18 lines
745 B
Python
18 lines
745 B
Python
from src.gui_2 import App
|
|
from src.models import Ticket
|
|
|
|
def test_cb_ticket_retry(app_instance: App) -> None:
|
|
ticket_id = "test_ticket_1"
|
|
app_instance.active_tickets = [Ticket(id=ticket_id, description="test", status="failed")]
|
|
# Synchronous implementation does not use asyncio.run_coroutine_threadsafe
|
|
app_instance.controller._cb_ticket_retry(ticket_id)
|
|
# Verify status update
|
|
assert app_instance.active_tickets[0].status == 'todo'
|
|
|
|
def test_cb_ticket_skip(app_instance: App) -> None:
|
|
ticket_id = "test_ticket_2"
|
|
app_instance.active_tickets = [Ticket(id=ticket_id, description="test", status="todo")]
|
|
app_instance.controller._cb_ticket_skip(ticket_id)
|
|
# Verify status update
|
|
assert app_instance.active_tickets[0].status == 'skipped'
|