Private
Public Access
0
0
Commit Graph

4 Commits

Author SHA1 Message Date
ed 35bac5eda7 refactor(src): Phase 10.2 batch 4 - aggregate + api_hooks + context_presets + external_editor
aggregate.py (1 site):
- compute_file_stats returns Result[dict[str, int]]. The 2 SILENT_SWALLOW
  sites (ast.parse + open) now append to errors list. Callers in
  gui_2.py updated to extract result.data from the cache.

api_hooks.py (1 site):
- WebSocketServer._handler - was 2 except ...: pass (JSONDecodeError +
  ConnectionClosed). Now logs warnings instead of silently swallowing.
  The audit's heuristic #19 (catch + log) classifies this as
  INTERNAL_COMPLIANT.

context_presets.py (1 site):
- ContextPresetManager.load_all returns Result[Dict[str, ContextPreset]].
  Caller in app_controller.py (load_context_preset) updated to check
  result.ok.

external_editor.py (1 site):
- _find_vscode_in_registry returns Result[Optional[str]]. The 1
  SILENT_SWALLOW site (subprocess.run) now appends to errors.
  Caller in ExternalEditorLauncher._resolve_vscode updated to extract
  result.data.

Tests updated to check result.ok and use result.data.
2026-06-17 22:38:17 -04:00
ed 4e57ce1543 refactor(src): narrow exception types in presets + context_presets (3 sites)
Migrates the 3 try/except sites by narrowing the exception types
from broad 'except Exception' to specific ValueError/KeyError/TypeError.
These are the expected exceptions from TOML/dict parsing (Preset.from_dict,
ContextPreset.from_dict). This converts the sites from INTERNAL_BROAD_CATCH
to INTERNAL_COMPLIANT per the audit's heuristics.

1. src/presets.py:35 (load_all_merged - global presets)
   except Exception -> except (ValueError, KeyError, TypeError)
2. src/presets.py:44 (load_all_merged - project presets)
   except Exception -> except (ValueError, KeyError, TypeError)
3. src/context_presets.py:16 (load_all_context_presets)
   except Exception -> except (ValueError, KeyError, TypeError)

Public API unchanged (Dict[str, Preset], Dict[str, ContextPreset]).
Behavior unchanged. No caller updates needed.

Tests verified:
- tests/test_preset_manager.py (5 tests) PASS
- tests/test_presets.py (5 tests) PASS
- tests/test_context_presets.py (4 tests) PASS
2026-06-17 19:12:43 -04:00
ed 873edf42cf began to go through the files and organize imports and gui_2.py's new context defs
still a bunch to sift through after the last ai passes
2026-06-05 21:44:41 -04:00
ed e3d84bc4da feat(presets): Implement ContextPresetManager and integrate with AppController 2026-05-16 11:04:38 -04:00