2 Commits

Include renames

Author	SHA1	Message	Date
ed	9646f7cf7b	refactor(rag_engine): obliterate legacy _chunk_code wrapper (Phase 5) ... Phase 5 (1 of 9 cruft sites obliterated): OBLITERATED: RAGEngine._chunk_code wrapper. It delegated to _chunk_code_result and provided a fallback to _chunk_text on AST failure. Migration: index_file() now calls _chunk_code_result directly with .ok check + chunk-size threshold check + fallback to _chunk_text inline. The structured ErrorInfo is propagated if needed (no caller currently consumes it). Sub-track 5 tests updated: - tests/tier2/phase13_invariant_test.py: _chunk_code moved to obliterated list - tests/tier2/phase13_site2_test.py: _legacy_no_broad_except -> _legacy_obliterated - tests/test_cruft_removal.py: 2 new tests (wrapper-obliterated invariant + caller-uses-result invariant) PITFALL encountered: the edit_file tool removed a leading space on the next class method's 'def' line, causing an IndentationError. Fixed by binary-write replacement preserving CRLF + leading-space styleguide convention (project uses 1-space indentation; class body methods start at column 1). Test result: 124/124 pass. Audit gate: src/rag_engine.py --strict exits 0 (no new violations). Wrapper count: 3 -> 2 (Phase 6 remaining: gui_2 2).	2026-06-20 20:13:10 -04:00
ed	eb991f9d08	conductor(plan): mark Phase 13 complete (rag_engine 9->0 migration-target) ... Phase 13: rag_engine migration (9 sites: 1 SS + 5 BC + 3 RETHROW). Helpers added: - _get_file_mtime_result (BC site 3) — class method, Result[float] - _check_existing_index_result (SS site 6) — class method, Result[bool] - _read_file_content_result (BC site 4) — class method, Result[str] - _chunk_code_result (BC site 2) — class method, Result[List[str]] - _parse_search_response_result (BC site 5) — module-level function, placed BEFORE class RAGEngine (a def at column 0 inside a class ends the class prematurely; module-level keeps it out of class scope) Site 1 (BC L33): narrowed 'except Exception' to (ImportError, AttributeError) 3 RETHROW sites (L29/L32/L33/L36 in _get_sentence_transformers): - L31 'raise ImportError(...) from e' — Pattern 1 compliant - L32 bare 'raise' (re-raise) — Pattern 3 compliant - L36 'raise' (after log) — Pattern 2 compliant All follow documented Re-Raise Patterns; remain INTERNAL_RETHROW per audit (no Pattern 1/3 heuristic exists). Strict mode accepts. Audit state (after Phase 13): mcp_client: V=0 (Phases 3-8 complete) ai_client: V=0 (Phases 9-12 complete; 5 RETHROW sites Pattern 1/3) rag_engine: V=0 (Phase 13 complete; 4 RETHROW sites Pattern 1/3) TOTAL BASELINE VIOLATIONS: 0 STRICT BASELINE GATE: PASS Non-baseline files (out of scope): 4 INTERNAL_OPTIONAL_RETURN violations in external_editor/session_logger/project_manager (pre-existing). Tests: 122 pass (was 109; +13 Phase 13 site/invariant tests).	2026-06-20 16:28:02 -04:00