2 Commits

Include renames

Author	SHA1	Message	Date
ed	c5a119d63f	refactor(ai_client): obliterate 5 legacy model-list wrappers (Phase 4) ... Phase 4 (5 of 9 cruft sites obliterated): OBLITERATED wrappers: 1. _reread_file_items (4 callers in _send_gemini + _send_gemini_cli + 2 others) 2. _list_anthropic_models (1 caller in list_models) 3. _list_gemini_models (1 caller in list_models) 4. _extract_gemini_thoughts (1 caller in _send_gemini) 5. _list_minimax_models (2 callers in _set_minimax_provider_result + set_provider) Migration: each caller now uses the _result sibling directly with .ok check + .data extraction. The Result[T] error context (structured ErrorInfo) is now propagated instead of dropped. _send_gemini gets .data with explicit .ok check. Updated tests to assert OBLITERATED state (5 sub-track 5 tests inverted from '_legacy_preserved' to '_legacy_obliterated'): - tests/test_baseline_result.py: test_phase9_redo_modules_import_cleanly - tests/tier2/phase10_invariant_test.py: _list_gemini_models removed from list - tests/tier2/phase10_site1_test.py: _legacy_unchanged -> _legacy_obliterated - tests/tier2/phase11_invariant_test.py: _extract/_list_minimax moved to obliterated - tests/tier2/phase11_sites78_test.py: _legacy_preserved -> _legacy_obliterated - tests/tier2/phase12_invariant_test.py: _list_anthropic moved to obliterated - tests/tier2/phase12_site4_test.py: _legacy_preserved -> _legacy_obliterated - tests/test_gemini_thinking_format.py: helper uses _result directly - tests/test_cruft_removal.py: 5 new obliterated-wrappers invariant tests Test result: 122/122 pass (31 baseline + 16 heuristic + 9 cruft + 5 thinking + 61 tier2). Audit gate: src/ai_client.py --strict exits 0 (no new violations introduced). Wrapper count: 9 -> 3 (Phase 5-6 remaining: rag_engine 1, gui_2 2).	2026-06-20 20:01:25 -04:00
ed	1fa2b19257	conductor(plan): mark Phase 11 complete (ai_client SS 11->0; CRITICAL anti-sliming) ... Phase 11: ai_client silent-swallow cleanup (11 sites migrated). Helpers added to src/ai_client.py: - _try_warm_sdk_result(name) -> Result[Any] (sites 1+2) - _set_tool_preset_result(preset_name) -> Result[None] (site 5) - _set_bias_profile_result(profile_name) -> Result[None] (site 6) - _extract_gemini_thoughts_result(resp) -> Result[str] (site 7) - _list_minimax_models_result(api_key) -> Result[list[str]] (site 8) - _count_gemini_tokens_for_stats_result(md_content) -> Result[int] (sites 9+10) Helpers reused from earlier phases: - _delete_gemini_cache_result from Phase 10 (sites 3+4) - _set_tool_preset_result from site 5 (site 11) Per-site decision (TIER1_REVIEW Phase 11 anti-sliming protocol): - Sites with 'except: pass': MIGRATE to Result (no sentinel-None) - Sites with 'except (NarrowType): sys.stderr.write': MIGRATE to Result - _try_warm_sdk_result: Result variant (NOT sentinel-None which the audit flagged as UNCLEAR; Result pattern matches Heuristic A) Dilemma resolved: initial sentinel approach (_try_warm_sdk -> Any | None) flagged as UNCLEAR (Heuristic B requires class method + self.attr assign). Per Phase 9 redo precedent: migrate to Result instead of adding heuristic. Audit state (after Phase 11): mcp_client: 0 migration-target (Phase 3-8 complete) ai_client: 18 -> 7 migration-target BC: 0 (Phase 10 done) SS: 11 -> 0 ✓ RETHROW: 6 (Phase 12) UNCLEAR: 0 COMPLIANT: 27 -> 33 (+6 from helpers) rag_engine: 9 migration-target (Phase 13) Tests: 97 pass (was 79 in Phase 10; +18 Phase 11 site/invariant tests).	2026-06-20 14:13:09 -04:00