Private
Public Access
0
0
Commit Graph

9 Commits

Author SHA1 Message Date
ed 5ac0618a33 refactor(scripts): move 7 code_path_audit files from src/ to scripts/code_path_audit/
The 7 code_path_audit*.py files (2604 lines total) are pure static
analysis tools. They do AST traversal of src/, no intrusive profiling,
no runtime markers. They were inlaid with src/ but only import:
- src.result_types (the Result[T] convention type)
- each other (the 6 siblings)

After the move:
- src/ is now pure application code; line-count audit metrics are clean
- scripts/code_path_audit/ is a new namespace-isolated subdir per
  AGENTS.md 'scripts are namespace-isolated by directory' rule

TIER-3 READ AGENTS.md + conductor/workflow.md + conductor/edit_workflow.md
+ conductor/code_styleguides/code_path_audit.md + the 7 files before
this commit.

Changes:
- 7 files moved: src/code_path_audit*.py -> scripts/code_path_audit/
- 7 files updated: internal imports rom src.code_path_audit_X ->
  rom code_path_audit_X (siblings in same subdir)
- 7 files updated: add sys.path.insert(0, str(Path(__file__).resolve().parents[2] / 'src'))
  to find src.result_types when run standalone
- 5 test files updated: rom src.code_path_audit -> rom code_path_audit
  + sys.path setup to find the new subdir
- 6 throwaway scripts in scripts/tier2/artifacts/ updated: import path
  + sys.path setup (parents[3] / 'src' + parents[3] / 'scripts' / 'code_path_audit')
- 2 styleguide/spec references updated: conductor/code_styleguides/code_path_audit.md
  + conductor/tracks/code_path_audit_20260607/spec_v2.md
- 1 meta-audit docstring updated: scripts/audit_code_path_audit_coverage.py
- 1 type registry entry deleted: docs/type_registry/src_code_path_audit.md
  (the type is no longer in src/)
- 1 type registry index updated: docs/type_registry/index.md (22 files, was 23)

Verification:
- 7/7 audit gates pass --strict (weak_types 102<=112, type_registry 22 files,
  main_thread_imports OK, no_models_config_io OK, code_path_audit_coverage 0
  violations, exception_handling 0 violations, optional_in_3_files 0 violations)
- 6/6 test files pass: test_code_path_audit, test_code_path_audit_integration,
  test_code_path_audit_phase78, test_code_path_audit_phase89,
  test_code_path_audit_ssdl_behavioral, test_metadata_nil_sentinel
- src/ line count: 29997 lines (down from 32621 = -2624 lines)
- scripts/code_path_audit/ line count: 2620 lines
2026-06-25 09:29:24 -04:00
ed 077149011b fix(audit): real line numbers + entry.get() field-access detection + Optional/dict/Union patterns
Three real bugs fixed:
1. FunctionRef always used line=0. Now passes node.lineno from AST.
2. P3_pass results were discarded with bare pass. Now stored in
   ProducerConsumerGraph.field_accesses.
3. Field-access detector only saw entry['key']; missed entry.get('key')
   which is the dominant pattern in this codebase. Now handles both.

Plus _extract_type_name() helper handles Optional[T], dict[str, T],
list[T], Result[T], Union[T, ...], and T | None (PEP 604) so P1/P2
catch more annotation patterns.

Real numbers (Metadata aggregate):
- producers: 77 -> 117
- consumers: 35 -> 66
- field-access sites: 130 -> 173
- line numbers: all real (line 1281, 1746, etc.)

AUDIT_REPORT.md grew 2009 -> 3140 lines with real evidence.
Total audit output: 5176 lines / 50 files (was 2415 / 49).

All 131 tests still passing.
2026-06-22 12:20:32 -04:00
ed cca59668c8 feat(audit): implement Phase 5 CFE + Phase 6 Decomposition Cost (11 tasks)
Phase 5 CFE: detect_frequency_from_entry_point + 6 caller sets
(INIT/HOT/PER_TURN/COLD/PER_DISCUSSION/PER_REQUEST),
load_frequency_overrides (tomllib), estimate_call_frequency with
3-tier precedence (override > entry-point > unknown).

Phase 6 Decomposition Cost: 6 cost-model constants (per spec 7.5),
per_call_cost_us formula, FREQUENCY_MULTIPLIER (7 frequencies),
current_total_us, componentize_factor lookup, unify_factor lookup,
recommended_direction (5-step precedence with frozen whole_struct
-> hold override), generate_rationale auto-string, and
compute_decomposition_cost main entry.

33 new unit tests passing (Phase 5: 11, Phase 6: 22).
96 total tests passing.

Phase 7 (Cross-audit integration) next.
2026-06-22 01:40:32 -04:00
ed c1d2f0e454 feat(audit): implement Phase 3 MemoryDim + Phase 4 APD (11 tasks)
Phase 3: MemoryDim classifier with canonical mappings (23 entries,
includes ToolSpec/ChatMessage/ProviderHistory now that they're real),
file-of-origin heuristic (5 buckets), TOML override loader,
classify_memory_dim() with 3-tier precedence.

Phase 4: APD with 4 threshold constants, 5 pattern detectors
(whole_struct, field_by_field, hot_cold_split, bulk_batched,
dominant_pattern), detect_access_pattern() main entry.

30 new unit tests passing (Phase 3: 11, Phase 4: 19).
63 total tests passing.

Phase 5 (CFE - Call Frequency Estimator) next.
2026-06-22 01:26:06 -04:00
ed 200396e4a5 feat(audit): implement Phase 2 PCG (5 tasks: skeleton + P1+P2+P3+build_pcg)
Phase 2 PCG: ProducerConsumerGraph (bipartite aggregate<->function)
+ 3 AST passes (P1 return-type, P2 parameter-type, P3 field-access)
+ build_pcg() main entry returning Result[ProducerConsumerGraph].

14 new unit tests passing (2 PCG + 3 P1 + 3 P2 + 3 P3 + 3 build_pcg).

The build_pcg() function tolerates syntax errors per the stdlib
I/O boundary pattern (records ErrorInfo, continues).

Phase 2 complete: 33 unit tests passing. Phase 3 (MemoryDim
classifier with canonical mappings) next.
2026-06-22 01:18:54 -04:00
ed ef207cf684 feat(audit): complete Phase 1 data model (8 dataclasses, 12 new tests)
Tasks 1.3-1.10: AccessPatternEvidence, FrequencyEvidence,
ResultCoverage, TypeAliasCoverage, CrossAuditFinding,
CrossAuditFindings, DecompositionCost, OptimizationCandidate,
AggregateProfile. All frozen dataclasses per error_handling.md
Pattern 1 (immutability for cross-thread safety).

Phase 1 complete: 19 unit tests passing (5 enum tests + 14
dataclass tests). AggregateProfile is the central artifact with
14 required fields + 2 optional (mermaid, markdown).

Phase 2 (PCG - 3 AST passes + build_pcg()) next.
2026-06-22 01:10:57 -04:00
ed 1680182953 feat(audit): add FunctionRef dataclass (frozen, 4 fields)
fqname, file, line, role. Used in ProducerConsumerGraph edges
and per-aggregate producer/consumer lists. Per error_handling.md
Pattern 1 (immutability for cross-thread safety).
2 unit tests passing.
2026-06-22 01:05:17 -04:00
ed 5dca69f0d7 feat(audit): add 5 enums for the v2 data model
AggregateKind (4 values), MemoryDim (7), AccessPattern (5),
Frequency (7), RecommendedDirection (4). All Literal types
for stable postfix DSL output (string-valued, no enum-name
lookup table needed in the parser).

5 unit tests passing. The 9 supporting dataclasses + the
AggregateProfile central artifact go in Tasks 1.2-1.10.
2026-06-22 00:46:00 -04:00
ed 28ed3deafb chore(audit): create empty tests/test_code_path_audit.py v2
Module docstring + from __future__ import annotations. No tests
yet; the data model tests go in next (Phase 1).
2026-06-22 00:42:29 -04:00