ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity
4,039 Commits 36 Branches 1 Tag
548c4fef6372b43ee28272da7d1b82a49712d5d9
Commit Graph
4039 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ed 195b0f451e conductor(plan): nagent_review_v3 mark Phase 14 complete + track status 2026-06-20 08:54:35 -04:00
ed b49be82048 conductor(track): nagent_review_v3 Phase 14 format verification + final 2026-06-20 08:53:11 -04:00
ed a55dfd05c3 conductor(plan): nagent_review_v3 mark Phase 13 complete 2026-06-20 08:46:54 -04:00
ed e150088d24 conductor(track): nagent_review_v3 Phase 13 refresh side artifacts 2026-06-20 08:46:05 -04:00
ed 952d0645fe TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5 
Phase 5 = mcp_client Batch C: 8 more INTERNAL_BROAD_CATCH sites
  - L610 ts_cpp_get_definition, L624 ts_cpp_get_signature, L645 ts_cpp_update_definition
  - L695 py_get_skeleton, L713 py_get_code_outline, L739 py_get_symbol_info
  - L768 py_get_definition, L788 py_update_definition

Target: mcp_client BC 24 -> 16 after Batch C.
 2026-06-20 08:42:27 -04:00
ed 4d7c0f10f7 conductor(plan): mark Phase 4 complete (Batch B: 8 BC sites; BC 32->24) 2026-06-20 08:42:14 -04:00
ed 6bb7f92275 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4: refactor(mcp_client): migrate 8 Batch B sites to Result[T] 
Phase 4 Batch B (8 INTERNAL_BROAD_CATCH sites in mcp_client.py):

Added _result variants inside the Result Variants region:
  - get_git_diff_result (subprocess.run + CalledProcessError)
  - ts_c_get_skeleton_result (ASTParser.get_skeleton)
  - ts_c_get_code_outline_result (ASTParser.get_code_outline)
  - ts_c_get_definition_result (ASTParser.get_definition)
  - ts_c_get_signature_result (ASTParser.get_signature)
  - ts_c_update_definition_result (ASTParser.update_definition)
  - ts_cpp_get_skeleton_result (ASTParser.get_skeleton with lang=cpp)
  - ts_cpp_get_code_outline_result (ASTParser.get_code_outline with lang=cpp)

Plus 5 internal _ast_* helpers (extract ASTParser boilerplate).

Each legacy string-returning function now delegates to its _result variant;
the try/except Exception is REMOVED from the legacy function.

Updated test_baseline_result.py:
  - Phase 3 tests loosened (BC<=32, total MIG<=80)
  - Phase 4 tests added (BC=24, total MIG=72, modules import cleanly)

Audit: mcp_client BC 32 -> 24. Total MIG 80 -> 72.
 2026-06-20 08:41:32 -04:00
ed dd10a6803b conductor(plan): nagent_review_v3 mark Phase 12 complete 2026-06-20 08:37:29 -04:00
ed 448319f822 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 4 
Re-read lines 462-540 (The Broad-Except Distinction). Same migration
pattern as Phase 3 Batch A: each legacy string-returning tool function
delegates to its _result variant. The try/except Exception in the
legacy function is REMOVED; the new Result variant captures ErrorInfo
with kind=INTERNAL and the original exception.

Phase 4 = mcp_client Batch B: 8 INTERNAL_BROAD_CATCH sites (lines 473-593)
  - L473 get_git_diff
  - L492 ts_c_get_skeleton, L509 ts_c_get_code_outline, L523 ts_c_get_definition
  - L537 ts_c_get_signature, L555 ts_c_update_definition
  - L576 ts_cpp_get_skeleton, L593 ts_cpp_get_code_outline

Target: mcp_client BC 32 -> 24 after Batch B.
 2026-06-20 08:37:21 -04:00
ed db7d94de88 conductor(track): nagent_review_v3 §11 Collisions case study cluster 2026-06-20 08:37:07 -04:00
ed 64f8840ed3 conductor(plan): mark Phase 3 complete (Batch A: 8 BC sites migrated) 2026-06-20 08:36:28 -04:00
ed faa6ec6e51 test(baseline): add 3 Phase 3 invariant tests (Batch A complete) 
TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3.

Phase 3 tests assert:
1. mcp_client BC count 40 -> 32 (Batch A migrated 8 sites)
2. Total MIG 88 -> 80 (88 - 8 Batch A)
3. PHASE1_AUDIT_BASELINE.json still has 88 baseline (immutable)

Total: 10 tests pass (4 Phase 1 + 3 Phase 2 + 3 Phase 3).
 2026-06-20 08:35:44 -04:00
ed a0908f8915 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L451 set_file_slice to Result[T] (Phase 3 site 8) 
Added set_file_slice_result(Result[str]) inside the Result Variants region.
Legacy set_file_slice (str) now delegates to set_file_slice_result.

Audit: mcp_client BC count 33 -> 32 (Batch A complete: -8 sites).
 2026-06-20 08:33:31 -04:00
ed c7e2ceffcd conductor(plan): nagent_review_v3 mark Phase 11 complete 2026-06-20 08:33:30 -04:00
ed f53c82e60c conductor(track): nagent_review_v3 §10 PEP case study cluster 2026-06-20 08:33:08 -04:00
ed dc903ab371 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L430 get_file_slice to Result[T] (Phase 3 site 7) 
Added get_file_slice_result(Result[str]) inside the Result Variants region.
Legacy get_file_slice (str) now delegates to get_file_slice_result.

Audit: mcp_client BC count 34 -> 33.
 2026-06-20 08:32:54 -04:00
ed 0274f35dea TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L414 get_file_summary to Result[T] (Phase 3 site 6) 
Added get_file_summary_result(Result[str]) inside the Result Variants region.
Legacy get_file_summary (str) now delegates to get_file_summary_result.

Audit: mcp_client BC count 35 -> 34.
 2026-06-20 08:32:21 -04:00
ed 7378a69787 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L395 edit_file to Result[T] (Phase 3 site 5) 
Added edit_file_result(Result[str]) inside the Result Variants region.
Legacy edit_file (str) now delegates to edit_file_result.

Audit: mcp_client BC count 36 -> 35.
 2026-06-20 08:31:44 -04:00
ed 8e6f202846 conductor(plan): nagent_review_v3 mark Phase 10 complete 2026-06-20 08:29:59 -04:00
ed 54e62b1037 conductor(track): nagent_review_v3 §9 Case-study methodology cluster 2026-06-20 08:29:36 -04:00
ed da9c5419ef TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L266 read_file to Result[T] (Phase 3 site 4) 
Legacy read_file (str) now delegates to read_file_result (Result[str]).
The try/except Exception is REMOVED.

Audit: mcp_client BC count 37 -> 36.
 2026-06-20 08:29:16 -04:00
ed dc41cb3775 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L254 list_directory to Result[T] (Phase 3 site 3) 
Legacy list_directory (str) now delegates to list_directory_result (Result[str]).
The try/except Exception is REMOVED.

Audit: mcp_client BC count 38 -> 37.
 2026-06-20 08:28:38 -04:00
ed 409ab5ae1f TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L229 search_files to Result[T] (Phase 3 site 2) 
Legacy search_files (str) now delegates to search_files_result (Result[str]).
The try/except Exception in the legacy function is REMOVED; the new Result
variant captures ErrorInfo (kind=INTERNAL with original exception).

Audit: mcp_client BC count 39 -> 38.
 2026-06-20 08:27:43 -04:00
ed d876744fc5 conductor(plan): nagent_review_v3 mark Phase 9 complete 2026-06-20 08:26:43 -04:00
ed ad19be002d conductor(track): nagent_review_v3 §8 Operating rules cluster 2026-06-20 08:26:18 -04:00
ed 263711284f TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3: refactor(mcp_client): migrate L191 _resolve_and_check to Result[T] (Phase 3 site 1) 
Legacy _resolve_and_check (Path|None, str tuple) now delegates to
_resolve_and_check_result (Result[Path]). The try/except Exception in the
legacy function is REMOVED; the new Result variant captures the structured
ErrorInfo (kind=INVALID_INPUT for path errors, kind=PERMISSION for
allowlist denials). Error messages are propagated via ui_message().

Updated tests/test_py_struct_tools.py::test_mcp_dispatch_errors to accept
the new 'permission' ErrorKind string instead of the legacy 'ACCESS DENIED'
substring (the new format is more descriptive).

Audit: mcp_client BC count 40 -> 39.
 2026-06-20 08:25:27 -04:00
ed d6f5d711be conductor(plan): nagent_review_v3 mark Phase 8 complete 2026-06-20 08:24:05 -04:00
ed ffa21d5ccc conductor(track): nagent_review_v3 §7 Robustness cluster 2026-06-20 08:23:41 -04:00
ed ae1a180028 conductor(plan): nagent_review_v3 mark Phase 7 complete 2026-06-20 08:20:28 -04:00
ed ca67bb6464 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 3 
Re-read lines 462-540 (The Broad-Except Distinction). Key points for Phase 3:
- Broad catch + log = INTERNAL_SILENT_SWALLOW violation (logging NOT a drain)
- Broad catch + return Result(data=..., errors=[ErrorInfo(...)]) = BOUNDARY_CONVERSION (canonical)
- Broad catch + pass/return None = INTERNAL_SILENT_SWALLOW / INTERNAL_OPTIONAL_RETURN (violation)
- Broad catch + HTTPException in _api_* = BOUNDARY_FASTAPI (compliant)

Phase 3 = mcp_client Batch A: 8 INTERNAL_BROAD_CATCH sites in tool file/edit ops
  (L191 _resolve_and_check, L229 search_files, L254 list_directory, L266 read_file,
   L395 edit_file, L414 get_file_summary, L430 get_file_slice, L451 set_file_slice).

Per the canonical pattern, each site must convert to Result[T] with the tool's
specific exception types captured into ErrorInfo.
 2026-06-20 08:20:07 -04:00
ed 0dad59fd08 conductor(track): nagent_review_v3 §6 Delegation rewrite cluster 2026-06-20 08:20:06 -04:00
ed 7713bf8ac3 conductor(plan): mark Phase 2 complete (4d391fd4) 2026-06-20 08:19:01 -04:00
ed 4d391fd42f test(baseline): add 3 Phase 2 invariant tests (audit gate baseline) 
TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 2.

Phase 2 tests assert the BASELINE state:
1. test_phase2_baseline_audit_runs: audit --include-baseline --json exits 0
2. test_phase2_all_3_targets_have_migration_sites: each baseline file has >0 MIG
3. test_phase2_per_file_baseline_counts_match_inventory: counts = 46/33/9

Total: 7 tests pass (4 Phase 1 + 3 Phase 2).
 2026-06-20 08:18:37 -04:00
ed 89368d4f26 conductor(plan): nagent_review_v3 mark Phase 6 complete 2026-06-20 08:17:51 -04:00
ed dd8428a30f conductor(track): nagent_review_v3 §5 Provider expansion cluster 2026-06-20 08:17:30 -04:00
ed d06c4fdb52 conductor(plan): mark Phase 1 complete (169a58d6) 2026-06-20 08:16:24 -04:00
ed 169a58d68a conductor(gui_2): Phase 1 checkpoint — 3-file inventory + 4 invariant tests 
TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 1.

Tasks:
- 1.1: Run audit --include-baseline --json > PHASE1_AUDIT_BASELINE.json
- 1.2: Walk audit + write 3 inventory docs (46+33+9 = 88 sites)
- 1.3: Add 4 Phase 1 invariant tests in tests/test_baseline_result.py

Per-file migration-target counts (from audit):
  mcp_client.py: 46 (40 BC + 5 SS + 1 UNCLEAR)
  ai_client.py:  33 (17 BC + 9 SS + 7 RETHROW)
  rag_engine.py:  9 ( 5 BC + 1 SS + 3 RETHROW)
  Total: 88 sites

Stay-as-is counts:
  mcp_client.py: 9 (all INTERNAL_COMPLIANT)
  ai_client.py: 26 (4 BOUNDARY_SDK + 4 INTERNAL_PROGRAMMER_RAISE + 17 COMPLIANT + 1 BOUNDARY_CONVERSION)
  rag_engine.py: 6 (5 INTERNAL_PROGRAMMER_RAISE + 1 COMPLIANT)
 2026-06-20 08:16:02 -04:00
ed 62f40d9410 conductor(plan): nagent_review_v3 mark Phase 5 complete 2026-06-20 08:15:04 -04:00
ed ea8fa94e14 conductor(track): nagent_review_v3 §4 Project-local roots cluster 2026-06-20 08:14:37 -04:00
ed 589a79f91a conductor(plan): nagent_review_v3 mark Phase 4 complete 2026-06-20 08:11:53 -04:00
ed 9ab2d07c8e conductor(track): nagent_review_v3 §3 Hooks cluster 2026-06-20 08:11:29 -04:00
ed cdcec0b917 conductor(plan): record t0_3 checkpoint SHA (c8e912f2) 2026-06-20 08:10:02 -04:00
ed c8e912f289 conductor(plan): mark Phase 0 complete (styleguide re-read + tracks.md active) 
Phase 0 tasks:
- 0.1 (6dd41b3e): tracks.md row 32 -> 'active 2026-06-20'
- 0.2 (227253b1): TIER-2 READ error_handling.md end-to-end (ack commit)
- 0.3 (this): Phase 0 checkpoint + state.toml updates
 2026-06-20 08:09:38 -04:00
ed 227253b150 TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 0 (Task 0.2 ack) 
Re-read in full (989 lines). Key sections reviewed for this track:
- The 5 Patterns (Nil-Sentinel, Zero-Init, Fail Early, AND over OR, Side-Channel)
- Drain Points section (the 5 patterns: HTTP error response, GUI error display,
  intentional app termination, telemetry emission, bounded retry)
- The Broad-Except Distinction (broad+log = SILENT_SWALLOW violation)
- Re-Raise Patterns 1/2/3 (catch+convert, catch+log+reraise, catch+cleanup+reraise)
- AI Agent Checklist (5 MUST-DO + 7 MUST-NOT-DO + 3 boundary patterns)
- Rule #0: MUST READ THIS STYLEGUIDE FIRST
- The pre-commit gate (4 audit scripts in --strict mode)

Per Rule #0: this commit message acknowledges the read. The full styleguide
content was reviewed end-to-end before any code work in Phase 0.
 2026-06-20 08:09:14 -04:00
ed 0cbe665aea conductor(plan): nagent_review_v3 mark Phase 3 complete 2026-06-20 08:08:50 -04:00
ed caf04ca5b6 conductor(track): nagent_review_v3 §2 Conversation safety net cluster 2026-06-20 08:08:14 -04:00
ed 6dd41b3e6d conductor(plan): mark result_migration_baseline_cleanup_20260620 as active 
TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 0.

Task 0.1 (Phase 0): update conductor/tracks.md row 32 from
'ready to start' to 'active 2026-06-20'.
 2026-06-20 08:07:59 -04:00
ed 52dfece9ca conductor(plan): nagent_review_v3 mark Phase 2 complete 2026-06-20 08:04:57 -04:00
ed c81ea78273 conductor(track): nagent_review_v3 §1 Campaigns cluster 2026-06-20 08:04:09 -04:00
ed f76d73e822 conductor(plan): nagent_review_v3 mark Phase 1 complete 2026-06-20 08:00:23 -04:00