 ed
|
0d0b433a2e
|
refactor(app_controller): remove redundant hasattr(f, ...) defensive checks
Phase 3 (partial): self.files guarantee (FR4 row 1)
Before: 13 hasattr(f, ...) defensive checks in src/app_controller.py
After: 0 (self.files is GUARANTEED List[FileItem] per init at 1996-2005)
Delta: -13 sites
Per the spec's FR4 row 1: 'After Phase 3, self.files is GUARANTEED
List[FileItem]. Every hasattr(f, "path") check is redundant. Remove it.'
The init code at src/app_controller.py:1996-2005 already does the correct
isinstance check + FileItem.from_dict() pattern, so all 13 hasattr checks
on self.files / self.context_files are redundant defensive code.
Verification:
- audit_weak_types --strict: OK (107 <= 112 baseline)
- py_check_syntax src/app_controller.py: OK
- 59 tests pass (type_aliases, openai_schemas, rag_engine, file_item, etc.)
OUT OF SCOPE (deferred):
- 18 hasattr(f, 'path') checks in src/gui_2.py (Phase 3 follow-up)
- Phase 4: _do_generate return type
- Phase 5: rag_engine.search() return type
- Phase 6: 30 Optional[T] returns
- Phase 7: 59 Any params + 10 dict[str, Any] params
See TRACK_COMPLETION_cruft_elimination_20260627.md for full scope.
|
2026-06-26 04:35:49 -04:00 |
|
|
ed
|
2a76889341
|
conductor(cruft_elimination): Phase 0 setup + baseline + styleguide ack
TIER-2 READ all 11 mandatory pre-flight files before <cruft_elimination_20260627>:
1. AGENTS.md
2. conductor/workflow.md
3. conductor/edit_workflow.md
4. conductor/tier2/githooks/forbidden-files.txt
5. conductor/tracks/tier2_leak_prevention_20260620/spec.md
6. conductor/product-guidelines.md (Core Value section)
7. conductor/code_styleguides/data_oriented_design.md (DOD + \u00a78.5)
8. conductor/code_styleguides/python.md (\u00a717 Banned Patterns)
9. conductor/code_styleguides/type_aliases.md
10. conductor/code_styleguides/error_handling.md
11. docs/guide_meta_boundary.md
Also read: agent_memory_dimensions.md, rag_integration_discipline.md,
cache_friendly_context.md, knowledge_artifacts.md, feature_flags.md,
workspace_paths.md, config_state_owner.md
Phase 0 baseline (measured 2026-06-27, master 88a1bdcb):
- Metadata: TypeAlias = dict[str, Any] at src/type_aliases.py:6 (Phase 1 target)
- hasattr(f, 'path') sites: 29 (gui_2.py:18, app_controller.py:10, aggregate.py:1)
- -> Optional[T] returns: 30 across 14 files
- Any params: 59
- dict[str, Any] params: 10
- Metadata params: 51
- All 7 audit gates pass --strict
- 17/18 per-aggregate dataclasses have from_dict() (NormalizedResponse is
an output type, not wire-boundary; doesn't need from_dict)
Branch: tier2/cruft_elimination_20260627 (from origin/master @ 88a1bdcb)
|
2026-06-26 04:17:55 -04:00 |
|