Private
Public Access
0
0
Commit Graph

4 Commits

Author SHA1 Message Date
ed 3260c141c6 fix(audit): make audit_tier2_leaks hermetic + harden test_palette_starts_hidden
audit_tier2_leaks bug: when test fixtures (tmp_path) are inside the
parent git repo, git's git diff and git ls-files look UP for a
parent .git/ directory and report the PARENT's modified files. This
made tests/test_audit_tier2_leaks.py fail because the audit reported
mcp_paths.toml + opencode.json as 'modified' even though those are in
the parent repo, not in the clean tmp_path fixture.

Fix: set GIT_DIR to a non-existent path (repo_root/.git) in the env
passed to git subprocesses. This forces git to fail, which the audit
treats as 'no modifications' / 'no tracked files'.

test_palette_starts_hidden hardening: live_gui is session-scoped so
other tests may leave the palette open. Pre-toggle the palette before
asserting it's hidden - converts a 'depends on test ordering' test
into a 'palette is closable' test.

Verification:
- tier-1-unit-core: ALL 5 batches PASS (was 5 failures)
- tier-3-live_gui: test_gui2_custom_callback_hook_works now PASSES
  (was FAILED); other live_gui flakes surface non-deterministically
  per batch run (pre-existing issue, not caused by this fix)
2026-06-21 23:36:50 -04:00
ed 3616d35a75 refactor(src): narrow exception types in Phase 5 batch (8 sites across 5 files)
Migrates the 8 try/except sites in UI + theme + tooling files
by narrowing the exception types from broad 'except Exception' to
specific stdlib/domain exceptions.

Files and sites:
1. src/command_palette.py:120 (1 site) - command.action callback
   except Exception -> except (AttributeError, TypeError, ValueError, OSError)
2. src/commands.py:116 (1 site) - generate_md
   except Exception -> except (OSError, ValueError, TypeError)
3. src/commands.py:147 (1 site) - save_all
   except Exception -> except (OSError, ValueError)
4. src/commands.py:271 (1 site) - reset_layout
   except Exception -> except OSError
5. src/diff_viewer.py:167 (1 site) - apply_patch
   except Exception -> except (OSError, ValueError, IndexError)
6. src/external_editor.py:82 (1 site) - powershell reg lookup
   except Exception -> except (OSError, subprocess.SubprocessError,
                               subprocess.TimeoutExpired)
7. src/markdown_helper.py:123 (1 site) - open link
   except Exception -> except (OSError, ValueError)
8. src/markdown_helper.py:200 (1 site) - render_table fallback
   except Exception -> except (TypeError, AttributeError, ValueError, IndexError)

Also updates tests/test_command_palette_sim.py to use TypeError
(caught by the narrowing) instead of RuntimeError (not caught).

Decisions:
- theme_2.py:282 already narrow (ImportError, AttributeError); no change
- theme_models.py:166 is RAISE (not except); keep as-is (documented)
- external_editor.py:47, 56 already narrow (FileNotFoundError); no change

Tests verified:
- tests/test_command_palette.py (13 tests) PASS
- tests/test_command_palette_sim.py (7 tests) PASS
- tests/test_diff_viewer.py (10 tests) PASS
- tests/test_external_editor.py (16 tests) PASS
- tests/test_external_editor_gui.py (5 tests) PASS
- tests/test_markdown_helper_* (16 tests) PASS
2026-06-17 19:15:51 -04:00
ed d7449ae417 feat(palette): add Up/Down arrow navigation and Enter key selection
- Process arrow keys BEFORE input_text so the input field does not consume them
- Up/Down arrow keys navigate the result list (clamped to bounds)
- Enter and KeypadEnter execute the currently selected command
- Refactored _close_palette and _execute helpers (action call is now wrapped in try/except via _execute)
- Added 3 new tests: close helper resets state, execute runs and catches exceptions, top_n is meaningful for navigation
2026-06-02 22:41:59 -04:00
ed 436f4cfdfc test(palette): add live_gui integration tests via toggle custom_callback 2026-06-02 22:03:33 -04:00