ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor: doc final sync for sub-tracks 2 (partial), 3, 4 + conftest fix

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-06-06 21:45:27 -04:00
parent ae3b433e5e
commit f09cd4a733
3 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/startup_speedup_20260606/plan.md
+13 -1
View File
@@ -303,7 +303,19 @@ The user confirmed: *"I'll address those bugs later, tests were prob too fragile
- [x] **Warmup completion notification works** — `controller.is_warmup_done()` returns True within 10s of startup; Hook API diagnostics endpoint exposes `warmup_status` (commit `b464d1fe`); conftest uses `wait_for_warmup(timeout=60.0)` to ensure warmup completes before tests run
- [x] **User action latency is zero for warmup-dependent operations** — manual smoke test switching providers / opening palette / rendering NERV is instant (all heavy SDKs are in `sys.modules` by the time the user makes their first action)
**Status:** Track SHIPPED at `12cec6ae` (Phase 9 checkpoint); sub-track 1 (Phase 6 full completion) SHIPPED at `253e1798`. 3 post-shipping bugfix commits applied (`8c4791d0`, `88fc42bb`, `52ea2693`). **Final ship commit: `253e1798`.**
**Status:** Track SHIPPED at `12cec6ae` (Phase 9 checkpoint); sub-track 1 (Phase 6 full completion) SHIPPED at `253e1798`. 3 post-shipping bugfix commits applied (`8c4791d0`, `88fc42bb`, `52ea2693`).
**Sub-track work after track SHIP (2026-06-07):**
- **Sub-track 3 (Hook API warmup endpoints) at `8fea8fe9`:** Added `GET /api/warmup_status` and `GET /api/warmup_wait?timeout=N` endpoints in `src/api_hooks.py`. Added `get_warmup_status()` and `get_warmup_wait(timeout)` methods in `src/api_hook_client.py`. 7 tests in `tests/test_api_hooks_warmup.py` (5 unit + 2 live_gui). All pass.
- **Sub-track 4 (GUI status indicator) at `f3d071e0`:** Added `render_warmup_status_indicator(app)` and `_on_warmup_complete_callback(app, status)` module-level functions in `src/gui_2.py`. Registered callback in `App._post_init`. 6 tests in `tests/test_gui_warmup_indicator.py` (5 unit + 1 live_gui). All pass.
- **Conftest atexit fix at `8957c9a5`:** Registered an `atexit` handler that captures the `_io_pool` reference via closure and calls `shutdown(wait=False)` at process exit. Fixes the `run_tests_batched.py` hang between batches (where `ThreadPoolExecutor.__del__ -> shutdown(wait=True)` was blocking on stuck warmup jobs).
- **Sub-track 2 (audit violations) PARTIAL at `ae3b433e`:** Removed top-level `import tomli_w` from `src/models.py`; now loaded on-demand in `save_config()`. 1 of 63 audit violations fixed. 62 remain (pydantic in models.py; tree_sitter in file_cache.py; websockets/cost_tracker/session_logger in api_hooks.py; 48 in app_controller.py + gui_2.py; 4 in sloppy.py). The remaining violations are large refactors that exceed the scope of a single sub-track.
**Final ship commit: `253e1798`.** After sub-track work, the latest commit is `ae3b433e`.
---
conductor/tracks/startup_speedup_20260606/state.toml
+4 -3
View File
@@ -129,9 +129,10 @@ test_failure_notes = "Pre-existing failures unrelated to this work: 1) test_api_
# for the original 9-phase plan. These can be picked up in separate
# tracks.
sub_track_1_phase_6_full = { status = "completed", commit_sha = "253e1798", description = "Bulk ad-hoc thread migration (Phase 6 completion): 15 sites migrated to self.submit_io(...). ZERO new threading.Thread() in src/." }
sub_track_2_audit_violations = { status = "pending", commit_sha = "", description = "Migrate remaining 63 audit violations in src/models.py (tomli_w, pydantic) + sloppy.py (win32gui, src.* indirect). Out of scope for this track." }
sub_track_3_warmup_endpoints = { status = "pending", commit_sha = "", description = "Add dedicated /api/warmup_status and /api/warmup_wait?timeout=N Hook API endpoints + register in _gettable_fields. Builds on Phase 7 minimal (b464d1fe) which only added warmup field to existing diagnostics endpoint." }
sub_track_4_gui_status_toast = { status = "pending", commit_sha = "", description = "GUI status bar indicator + completion toast. Deferred from Phase 7 (T7B). Pure ImGui work in src/gui_2.py + toast system. Polls warmup_status each frame; on completion, queue toast via existing toast system." }
sub_track_2_audit_violations = { status = "partial", commit_sha = "ae3b433e", description = "Migrate 63 audit violations. PARTIAL (1/63 done): tomli_w removed from src/models.py. 62 violations remain: pydantic in models.py, tree_sitter in file_cache.py, websockets/cost_tracker/session_logger in api_hooks.py, 48 in app_controller.py + gui_2.py, 4 in sloppy.py. The remaining violations are large refactors (especially gui_2.py and app_controller.py) that exceed the scope of a single sub-track; addressed as future work." }
sub_track_3_warmup_endpoints = { status = "completed", commit_sha = "8fea8fe9", description = "Add dedicated /api/warmup_status and /api/warmup_wait?timeout=N Hook API endpoints + register in _gettable_fields. Builds on Phase 7 minimal (b464d1fe) which only added warmup field to existing diagnostics endpoint. 7 tests added (5 unit + 2 live_gui), all pass." }
sub_track_4_gui_status_toast = { status = "completed", commit_sha = "f3d071e0", description = "GUI status bar indicator + completion toast. 6 tests added (5 unit + 1 live_gui), all pass. Polls warmup_status each frame; on completion, shows 3s transient 'ready' tag in status_success color. No separate toast window (state transition is the notification)." }
conftest_atexit_fix = { status = "completed", commit_sha = "8957c9a5", description = "Register atexit handler that calls _io_pool.shutdown(wait=False) at process exit. Fixes the run_tests_batched.py hang between batches where ThreadPoolExecutor.__del__ was blocking on shutdown(wait=True) for stuck warmup jobs." }
[ad_hoc_threads]
# Filled by Phase 6 T6.1 audit and completed in sub-track 1 (253e1798)