fix(exception): NG1 fixed - 4 INTERNAL_OPTIONAL_RETURN violations migrated to Result[T]

This commit is contained in:
ed
2026-06-24 17:24:55 -04:00
parent b3c569ff4f
commit ee4287ae4d
3 changed files with 32 additions and 15 deletions
+8 -4
View File
@@ -214,9 +214,13 @@ def log_tool_output(content: str) -> Optional[str]:
Returns the path of the written file.
[C: tests/test_session_logger_optimization.py:test_log_tool_output_returns_none_if_no_session, tests/test_session_logger_optimization.py:test_log_tool_output_saves_in_session_outputs]
"""
r = log_tool_output_result(content)
return r.data if r.ok else None
def log_tool_output_result(content: str) -> Result[str]:
global _output_seq
if _session_dir is None:
return None
return Result(data=None, errors=[ErrorInfo(kind=ErrorKind.NOT_FOUND, message="No active session directory", source="session_logger.log_tool_output_result")])
with _output_seq_lock:
_output_seq += 1
@@ -227,9 +231,9 @@ def log_tool_output(content: str) -> Optional[str]:
try:
out_path.write_text(content, encoding="utf-8")
return str(out_path)
except (OSError, UnicodeEncodeError):
return None
return Result(data=str(out_path))
except (OSError, UnicodeEncodeError) as e:
return Result(data=None, errors=[ErrorInfo(kind=ErrorKind.INTERNAL, message=f"Failed to write tool output: {e}", source="session_logger.log_tool_output_result", original=e)])
def log_cli_call(command: str, stdin_content: Optional[str], stdout_content: Optional[str], stderr_content: Optional[str], latency: float) -> Result[bool]:
"""Log details of a CLI subprocess execution."""