Private
Public Access
docs(track-completion): correct line count + add Phase 4 PATCH note (per Tier 1 review)
Per Tier 1 review of post_module_taxonomy_de_cruft_20260627:
1. Line count correction: src/models.py is 38 lines per Python
splitlines (not 30 as originally reported). The PowerShell
Measure-Object -Line command reported 30 due to a counting
difference for CRLF-terminated files. The corrected line count
is in:
- TRACK_COMPLETION post_module_taxonomy_de_cruft_20260627.md
(multiple sections updated)
- state.toml (src_models_py_lines = 38)
- spec_corrections block (VC9 deviation rationale updated from
10-line delta to 18-line delta)
2. Phase 4 PATCH note: Added a note documenting that the Tier 1
review caught 6 missed consumer sites in
tests/test_models_no_top_level_pydantic.py and
tests/test_project_switch_persona_preset.py that still imported
GenerateRequest/ConfirmRequest from src.models after the
Phase 4 move. The forward-fix commit 9651514c updated all 6
sites. The test bodies are now correct; the live_gui fixture
issue is a pre-existing test infrastructure problem documented
separately.
The forward-fix is documented in TRACK_COMPLETION §'Test Results'
and the Known Issues section.
After this correction:
- VC10 is now fully satisfied (all 85 + 44 + 6 = 135 consumer
sites use direct imports; 0 references to moved classes via
src.models)
- VC9 deviation is accurately documented (38 lines vs <=20 target;
18-line delta is documented)
This commit is contained in:
@@ -53,7 +53,7 @@ phase_6_complete = true
|
||||
critical_bugs_fixed = 2
|
||||
decruft_tasks_complete = 4
|
||||
im_gui_standardization = "no-op (0 begin/end calls in the 4 files)"
|
||||
src_models_py_lines = 30
|
||||
src_models_py_lines = 38
|
||||
v2_shipped_merged = true
|
||||
v2_shipped_merge_commit = "91a61288"
|
||||
atomic_commits = 11
|
||||
@@ -66,8 +66,8 @@ spec_claimed = "LEGACY_NAMES bug in scripts/generate_type_registry.py"
|
||||
actual_bug_location = "scripts/audit_no_models_config_io.py (function find_violations references undefined LEGACY_NAMES; should be LEGACY_PRIVATE_NAMES + LEGACY_PUBLIC_NAMES)"
|
||||
spec_claimed_2 = "5 ImGui LEAK files to be deleted"
|
||||
actual = "4 deleted; patch_modal.py is the data module per the v2 spec's data/view/ops split (corrected in v2 spec VC2 update)"
|
||||
spec_claimed_3 = "vc10: src/models.py reduced to <=30 lines (achieved: 30 lines; aspirational target was <=20; 10-line delta is the PROVIDERS __getattr__ + docstring + legacy Metadata alias)"
|
||||
actual = "30 lines; documented in TRACK_COMPLETION as VC9 deviation"
|
||||
spec_claimed_3 = "vc10: src/models.py reduced to <=20 lines (achieved: 38 lines; 18-line delta is the PROVIDERS __getattr__ + 17-line docstring + legacy Metadata alias)"
|
||||
actual = "38 lines (per Python splitlines; PowerShell Measure-Object -Line reports 30 due to different counting of CRLF-terminated lines); documented in TRACK_COMPLETION as VC9 deviation"
|
||||
|
||||
[im_gui_verification]
|
||||
imgui_begin_calls_in_4_files = 0
|
||||
|
||||
Reference in New Issue
Block a user